Patch Detail
Show a patch.
GET /api/1.1/patches/21282/?format=api
{ "id": 21282, "url": "https://patchwork.libcamera.org/api/1.1/patches/21282/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21282/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240916140241.47845-3-kieran.bingham@ideasonboard.com>", "date": "2024-09-16T14:02:39", "name": "[2/4] libcamera: pipeline: rkisp1: Fix typo in todo task", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "06d82c55785d7a5e62b8daecab69bba6fc0699c9", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21282/mbox/", "series": [ { "id": 4601, "url": "https://patchwork.libcamera.org/api/1.1/series/4601/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4601", "date": "2024-09-16T14:02:37", "name": "MediaPipeline: Complex input device support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4601/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21282/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21282/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA40DC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Sep 2024 14:02:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D71E363502;\n\tMon, 16 Sep 2024 16:02:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 239F3634F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Sep 2024 16:02:49 +0200 (CEST)", "from charm.lan (unknown\n\t[IPv6:2001:4bc9:a45:b0af:726e:a88f:9f07:34be])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07923DF3;\n\tMon, 16 Sep 2024 16:01:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J6ferGuL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726495288;\n\tbh=ErhgNr2NGcVwE/J0bp++WnI+oorHAvu55mM4+1Mhweo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=J6ferGuL3BoA1j7nJugcVDUAhijS7VwMVx41KlKtOWWE37GnUmvNtlAvIRuZFdo3r\n\tW7uv3kYJxHaTwcd7eXSJEdza/IsNIG7ib9TUMp1SvUGa7y5WIJ/CbhCEfOCw2ezFoF\n\tCV63AWvq4WWFzA+/Sii74ju8SWrKaUg263DHA/YM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 2/4] libcamera: pipeline: rkisp1: Fix typo in todo task", "Date": "Mon, 16 Sep 2024 16:02:39 +0200", "Message-ID": "<20240916140241.47845-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.46.0", "In-Reply-To": "<20240916140241.47845-1-kieran.bingham@ideasonboard.com>", "References": "<20240916140241.47845-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The delay values should be managed correctly. Not the dealys.\n\nCorrect accordingly, but I also hope we'll resolve this\ntask soon too.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c02c7cf374e9..2fee84e56d4d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tdata->properties_ = data->sensor_->properties();\n \n \t/*\n-\t * \\todo Read dealy values from the sensor itself or from a\n+\t * \\todo Read delay values from the sensor itself or from a\n \t * a sensor database. For now use generic values taken from\n \t * the Raspberry Pi and listed as generic values.\n \t */\n", "prefixes": [ "2/4" ] }