Patch Detail
Show a patch.
GET /api/1.1/patches/21274/?format=api
{ "id": 21274, "url": "https://patchwork.libcamera.org/api/1.1/patches/21274/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21274/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240915232420.2106705-4-paul.elder@ideasonboard.com>", "date": "2024-09-15T23:24:20", "name": "[v4,3/3] py: Add bindings for ControlId enum name", "commit_ref": "505e49b76ed4f3040182f66a1c3884ea1648a612", "pull_url": null, "state": "accepted", "archived": false, "hash": "50c930faa17f7e1b5cf3469c2771e3b1e15121d1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21274/mbox/", "series": [ { "id": 4598, "url": "https://patchwork.libcamera.org/api/1.1/series/4598/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4598", "date": "2024-09-15T23:24:17", "name": "libcamera: controls: Add enum information to ControlId", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4598/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21274/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21274/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A4E4C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 15 Sep 2024 23:24:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF7B263500;\n\tMon, 16 Sep 2024 01:24:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD43F634FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Sep 2024 01:24:32 +0200 (CEST)", "from pyrite.hamster-moth.ts.net (unknown\n\t[IPv6:2001:4bc9:a45:b0af:31d1:7a87:7f90:977b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA4A4D90;\n\tMon, 16 Sep 2024 01:23:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MPXvHk0H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726442592;\n\tbh=jahOa5LnjgjhjjhoBNQxC+BykSS5NvVWy4340U1+JWs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MPXvHk0HEfJ80iU2Qdgx60yuWaydsgTPa+h6uF0aE4i4jm9mBP5KDaC/e3IqqTQzf\n\tIFaoEZYmNpN0Mkqjp5/7M6dybC/yybINab7AUVZmYDRklAqXYrdREkbWqKqzSjjtBA\n\tp3UdLhpQp4s1SC3QafqX7EHwM6PPP4siFSNePuNo=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>, stefan.klug@ideasonboard.com, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v4 3/3] py: Add bindings for ControlId enum name", "Date": "Mon, 16 Sep 2024 01:24:20 +0200", "Message-Id": "<20240915232420.2106705-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240915232420.2106705-1-paul.elder@ideasonboard.com>", "References": "<20240915232420.2106705-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add python bindings for querying enum value names from a ControlId.\n\nExample usage:\n>>> cid\nlibcamera.ControlId(16, AwbMode, ControlType.Integer32)\n>>> cid.enumerators()\n{0: 'AwbAuto', 1: 'AwbIncandescent', 2: 'AwbTungsten', 3: 'AwbFluorescent', 4: 'AwbIndoor', 5: 'AwbDaylight', 6: 'AwbCloudy', 7: 'AwbCustom'}\n>>> cinfo\nlibcamera.ControlInfo([2..5])\n>>> cinfo.values\n[2, 3, 5]\n>>> [cid.enumerators()[v] for v in cinfo.values]\n['AwbTungsten', 'AwbFluorescent', 'AwbDaylight']\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nChanges in v4:\n- s/enum_str/enumerators/\n- s/enumToString/enumerators/\n- add example usage to commit message\n\nChanges in v3:\n- s/enumName/enumToString/\n- s/enum_name/enum_str/\n\nNew in v2\n---\n src/py/libcamera/py_main.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex ab33f38a8..983b76f6e 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -404,7 +404,8 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def(\"__repr__\", [](const ControlId &self) {\n \t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n \t\t\t\t.format(self.id(), self.name(), self.type());\n-\t\t});\n+\t\t})\n+\t\t.def(\"enumerators\", &ControlId::enumerators);\n \n \tpyControlInfo\n \t\t.def_property_readonly(\"min\", [](const ControlInfo &self) {\n", "prefixes": [ "v4", "3/3" ] }