Patch Detail
Show a patch.
GET /api/1.1/patches/21263/?format=api
{ "id": 21263, "url": "https://patchwork.libcamera.org/api/1.1/patches/21263/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21263/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240913154740.678284-1-paul.elder@ideasonboard.com>", "date": "2024-09-13T15:47:40", "name": "ipa: rkisp1: awb: Declare ControlInfo in AWB", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e24fb4c60a1fa4da8582651b09fd9c555401da01", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21263/mbox/", "series": [ { "id": 4590, "url": "https://patchwork.libcamera.org/api/1.1/series/4590/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4590", "date": "2024-09-13T15:47:40", "name": "ipa: rkisp1: awb: Declare ControlInfo in AWB", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4590/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21263/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21263/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F16DBC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Sep 2024 15:47:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF9B9634F5;\n\tFri, 13 Sep 2024 17:47:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F9D634F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Sep 2024 17:47:56 +0200 (CEST)", "from pyrite.hamster-moth.ts.net\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D7334EA5;\n\tFri, 13 Sep 2024 17:46:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nqs/a9O+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726242398;\n\tbh=uxV63thanafJMmplBdAZyxYNV9uTOh6rE6yj9a0T0Y8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Nqs/a9O+pznm85PPUxJ/3Y3s/sJSerC1HcsWh3anH2jckuqNiosaY/WvPwB5yuv6l\n\tUOAPjSiolMRcBLWPxgPcwr1KdCWAWpPE2S81t2CZ5OlyhbGSXhir+D/7JzH9+JAqci\n\tmPSNqedYLQX9FzQe0wRX0fvD0jh0DtaMlobDZHBk=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] ipa: rkisp1: awb: Declare ControlInfo in AWB", "Date": "Fri, 13 Sep 2024 17:47:40 +0200", "Message-Id": "<20240913154740.678284-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ControlInfo information for AwbEnable and ColourGains were declared\nand exposed in the top-level IPA. These should instead be exposed by the\nAWB part of the IPA, as it doesn't make sense to support these controls\nwhen AWB is disabled, for example.\n\nMove the declaration of these controls out of the top-level IPA and into\nAWB.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 2 --\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex edd36ef47..13247762f 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -52,6 +52,8 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n \tcmap[&controls::ColourTemperature] = ControlInfo(kMinColourTemperature,\n \t\t\t\t\t\t\t kMaxColourTemperature,\n \t\t\t\t\t\t\t kDefaultColourTemperature);\n+\tcmap[&controls::AwbEnable] = ControlInfo(false, true);\n+\tcmap[&controls::ColourGains] = ControlInfo(0.0f, 3.996f, 1.0f);\n \n \tMatrixInterpolator<double, 2, 1> gains;\n \tint ret = gains.readYaml(tuningData[\"gains\"], \"ct\", \"gains\");\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 56541190a..a20b83c98 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -116,8 +116,6 @@ const IPAHwSettings ipaHwSettingsV12{\n \n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n-\t{ &controls::AwbEnable, ControlInfo(false, true) },\n-\t{ &controls::ColourGains, ControlInfo(0.0f, 3.996f, 1.0f) },\n \t{ &controls::Sharpness, ControlInfo(0.0f, 10.0f, 1.0f) },\n \t{ &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },\n };\n", "prefixes": [] }