Patch Detail
Show a patch.
GET /api/1.1/patches/21240/?format=api
{ "id": 21240, "url": "https://patchwork.libcamera.org/api/1.1/patches/21240/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21240/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240911211816.73763-3-kieran.bingham@ideasonboard.com>", "date": "2024-09-11T21:18:14", "name": "[v2,2/4] libcamera: media_object: Add MediaLink string representations", "commit_ref": "a783562a34893fb1f96fea4ba6584d8e8e61d9b2", "pull_url": null, "state": "accepted", "archived": false, "hash": "ef4f5b882840ce45effdeeacad82fdb80ba40bc9", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21240/mbox/", "series": [ { "id": 4582, "url": "https://patchwork.libcamera.org/api/1.1/series/4582/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4582", "date": "2024-09-11T21:18:12", "name": "MediaLink: Provide a string representation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4582/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21240/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21240/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E14A6C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Sep 2024 21:18:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4882863505;\n\tWed, 11 Sep 2024 23:18:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E660618F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Sep 2024 23:18:27 +0200 (CEST)", "from charm.tail69b4.ts.net (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9793C83D;\n\tWed, 11 Sep 2024 23:17:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UYqZkRVI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726089429;\n\tbh=WG5DhPygWqfGsd6Ucmhf7drKBBA9r7zNXV+1M5jXYMk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=UYqZkRVI0czcJ63mvDJSdJQTe4qfC7AzkoeziOasja62NB9h2PzvEb0lQo4fdTr86\n\t4MaOZtXvFy1lWU6DnFCT6D567d6Y3X9A1x1TLldIfrMbWZ2UTIkET0V6IDAjNnd9Pk\n\tYVHGmnxjATSSLDuZEuJ4FofUXiiBhNKTgIvKcfHA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 2/4] libcamera: media_object: Add MediaLink string\n\trepresentations", "Date": "Wed, 11 Sep 2024 23:18:14 +0200", "Message-ID": "<20240911211816.73763-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.46.0", "In-Reply-To": "<20240911211816.73763-1-kieran.bingham@ideasonboard.com>", "References": "<20240911211816.73763-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Various parts of libcamera print the representation of a MediaLink by\ninline joining the parts to make a string representation.\n\nThis repeated use case can be supported with a common helper to print\nthe MediaLink in a common manner using the existing toString() and\noperator<< overload style to make it easier to report on MediaLink\ntypes.\n\nThis implementation will report in the following style:\n\n 'imx283 1-001a'[0] -> 'video-mux'[0]\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nv2:\n - Fix documentation\n - Use MediaPad helper \n\n include/libcamera/internal/media_object.h | 4 ++++\n src/libcamera/media_object.cpp | 25 +++++++++++++++++++++++\n 2 files changed, 29 insertions(+)", "diff": "diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex d80d5f4574c7..9356d204d6e5 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -48,6 +48,8 @@ public:\n \tunsigned int flags() const { return flags_; }\n \tint setEnabled(bool enable);\n \n+\tstd::string toString() const;\n+\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(MediaLink)\n \n@@ -61,6 +63,8 @@ private:\n \tunsigned int flags_;\n };\n \n+std::ostream &operator<<(std::ostream &out, const MediaLink &link);\n+\n class MediaPad : public MediaObject\n {\n public:\ndiff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\nindex 25f16707ab73..3e3772a628c2 100644\n--- a/src/libcamera/media_object.cpp\n+++ b/src/libcamera/media_object.cpp\n@@ -146,6 +146,31 @@ MediaLink::MediaLink(const struct media_v2_link *link, MediaPad *source,\n {\n }\n \n+/**\n+ * \\brief Generate a string representation of the MediaLink\n+ * \\return A string representing the MediaLink\n+ */\n+std::string MediaLink::toString() const\n+{\n+\tstd::stringstream ss;\n+\tss << *this;\n+\n+\treturn ss.str();\n+}\n+\n+/**\n+ * \\brief Insert a text representation of a Link into an output stream\n+ * \\param[in] out The output stream\n+ * \\param[in] link The MediaLink\n+ * \\return The output stream \\a out\n+ */\n+std::ostream &operator<<(std::ostream &out, const MediaLink &link)\n+{\n+\tout << *link.source() << \" -> \" << *link.sink();\n+\n+\treturn out;\n+}\n+\n /**\n * \\fn MediaLink::source()\n * \\brief Retrieve the link's source pad\n", "prefixes": [ "v2", "2/4" ] }