Patch Detail
Show a patch.
GET /api/1.1/patches/21237/?format=api
{ "id": 21237, "url": "https://patchwork.libcamera.org/api/1.1/patches/21237/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21237/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240911162400.1906661-3-paul.elder@ideasonboard.com>", "date": "2024-09-11T16:24:00", "name": "[v2,2/2] apps: cam: Print control array sizes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "56b64a74e43b6b692300d8d33f8ce218fd82f21e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21237/mbox/", "series": [ { "id": 4581, "url": "https://patchwork.libcamera.org/api/1.1/series/4581/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4581", "date": "2024-09-11T16:23:58", "name": "Add array information to ControlId", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4581/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21237/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21237/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDA65BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Sep 2024 16:24:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39A86634FC;\n\tWed, 11 Sep 2024 18:24:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA157634F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Sep 2024 18:24:12 +0200 (CEST)", "from pyrite.hamster-moth.ts.net\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D78B113D7;\n\tWed, 11 Sep 2024 18:22:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v5UQ4BGn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726071775;\n\tbh=fk8ScSQrWRcDyitoXqV6fKCf2iK1cbrMGJ79s8CEdgc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v5UQ4BGntmEsaiWPpimY/fKB9gGyzYXdnC261vZEeSHqXz2Qm45Ab2Ypa0LzwCAf4\n\tOBtpB0DBAYHdXSE54bhY1fDOz3OLJUasOVcAKseidaHsYXtauqwsQ1Cd/SyFzLx1FV\n\t0n+fMIYAHfF2WmbY3qnc90lU7+KMJRv0dnT8bE2Q=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 2/2] apps: cam: Print control array sizes", "Date": "Wed, 11 Sep 2024 18:24:00 +0200", "Message-Id": "<20240911162400.1906661-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240911162400.1906661-1-paul.elder@ideasonboard.com>", "References": "<20240911162400.1906661-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that controls can be queried for array information, print it in\n--list-controls when applicable.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/apps/cam/camera_session.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 37de6c9f3..9c7f84993 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -169,6 +169,11 @@ void CameraSession::listControls() const\n \t\t\t\tstd::cout << \" - \" << id->enumToString(val) << \" (\" << val << \")\" << std::endl;\n \t\t\t}\n \t\t}\n+\n+\t\tif (id->isArray()) {\n+\t\t\tstd::size_t size = id->size();\n+\t\t\tstd::cout << \" Size: \" << (size == std::numeric_limits<std::size_t>::max() ? \"n\" : std::to_string(size)) << std::endl;\n+\t\t}\n \t}\n }\n \n", "prefixes": [ "v2", "2/2" ] }