Patch Detail
Show a patch.
GET /api/1.1/patches/21231/?format=api
{ "id": 21231, "url": "https://patchwork.libcamera.org/api/1.1/patches/21231/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21231/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240911093600.671979-4-paul.elder@ideasonboard.com>", "date": "2024-09-11T09:36:00", "name": "[v3,3/3] py: Add bindings for ControlId enum name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9565707ec14fe4f8481304ddbbf97d75495af0a2", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21231/mbox/", "series": [ { "id": 4579, "url": "https://patchwork.libcamera.org/api/1.1/series/4579/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4579", "date": "2024-09-11T09:35:57", "name": "libcamera: controls: Add enum information to ControlId", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4579/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21231/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21231/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 698FFC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Sep 2024 09:36:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14C0163500;\n\tWed, 11 Sep 2024 11:36:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DF59634FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Sep 2024 11:36:18 +0200 (CEST)", "from pyrite.hamster-moth.ts.net\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D44A111D6;\n\tWed, 11 Sep 2024 11:35:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QMYGHdwG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726047301;\n\tbh=6ZXWUodmfH/b6r8gKECpJITCPI5z60rFpay3/WIP/l8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QMYGHdwGwMYkDiO3Bhktb89p/TasoEwOpDv1LKjI3FXo8kC93mZfISKRofaBLnmfi\n\tntI6kdHaPooM5MTrpcSluhf5vOfdgKz+BWXMO4hzhf5VDTkQA49vpWUSBi8ViadHWN\n\tfCaduWPo8zpkRDudbNAYl4KvHRKx2uDLmQ3iRRIQ=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>, stefan.klug@ideasonboard.com, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 3/3] py: Add bindings for ControlId enum name", "Date": "Wed, 11 Sep 2024 11:36:00 +0200", "Message-Id": "<20240911093600.671979-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20240911093600.671979-1-paul.elder@ideasonboard.com>", "References": "<20240911093600.671979-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add python bindings for querying enum value names from a ControlId.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nChanges in v3:\n- s/enumName/enumToString/\n- s/enum_name/enum_str/\n\nNew in v2\n---\n src/py/libcamera/py_main.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex ab33f38a8..f2897b11c 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -404,7 +404,8 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def(\"__repr__\", [](const ControlId &self) {\n \t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n \t\t\t\t.format(self.id(), self.name(), self.type());\n-\t\t});\n+\t\t})\n+\t\t.def(\"enum_str\", &ControlId::enumToString);\n \n \tpyControlInfo\n \t\t.def_property_readonly(\"min\", [](const ControlInfo &self) {\n", "prefixes": [ "v3", "3/3" ] }