Patch Detail
Show a patch.
GET /api/1.1/patches/21214/?format=api
{ "id": 21214, "url": "https://patchwork.libcamera.org/api/1.1/patches/21214/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21214/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240910133130.1374459-1-paul.elder@ideasonboard.com>", "date": "2024-09-10T13:31:30", "name": "test: controls: control_info: Add test for enum controls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5a14883664cb2a383e91154383ae29865a1fded8", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21214/mbox/", "series": [ { "id": 4573, "url": "https://patchwork.libcamera.org/api/1.1/series/4573/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4573", "date": "2024-09-10T13:31:30", "name": "test: controls: control_info: Add test for enum controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4573/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21214/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21214/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83DB9C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Sep 2024 13:31:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A9C0634F7;\n\tTue, 10 Sep 2024 15:31:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9183A618FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Sep 2024 15:31:54 +0200 (CEST)", "from pyrite.hamster-moth.ts.net\n\t(213-229-8-243.static.upcbusiness.at [213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9768F63F;\n\tTue, 10 Sep 2024 15:30:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zvk7MxqW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725975037;\n\tbh=6pAFk0dRkk07bWADoBkdyGp11rSOmrOD+Covbky7K0o=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Zvk7MxqWMBGWK8rDTCpVGvSZi2XVIHi8YJ+hCmojMrfOeyW+wtVohU0k40Xh8MtZE\n\tgmLRVhYTtYsy1/uO3Z09KzmtBPzrSvDpBIElCKtVfSwBLQAJoNigjdiFBWwy2Y5MQr\n\tGqajkBny84RX09kh1oO0lZgoWFvSnzKusQOY9H1o=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] test: controls: control_info: Add test for enum controls", "Date": "Tue, 10 Sep 2024 15:31:30 +0200", "Message-Id": "<20240910133130.1374459-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a test for enum controls to test that the ranges and values are set\nproperly.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n test/controls/control_info.cpp | 39 ++++++++++++++++++++++++++++++++++\n 1 file changed, 39 insertions(+)", "diff": "diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nindex e1bb43f0e..460aaa345 100644\n--- a/test/controls/control_info.cpp\n+++ b/test/controls/control_info.cpp\n@@ -6,6 +6,7 @@\n */\n \n #include <iostream>\n+#include <vector>\n \n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n@@ -79,6 +80,44 @@ protected:\n \t\t\treturn TestFail;\n \t\t}\n \n+\t\t/*\n+\t\t * Test information retrieval from an enum control.\n+\t\t */\n+\t\tControlInfo awbMode(static_cast<int32_t>(controls::AwbTungsten),\n+\t\t\t\t static_cast<int32_t>(controls::AwbDaylight));\n+\t\tif (awbMode.min().get<int32_t>() != controls::AwbTungsten ||\n+\t\t awbMode.max().get<int32_t>() != controls::AwbDaylight) {\n+\t\t\tcout << \"Invalid control range for AwbMode\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstd::vector<ControlValue> modes = {\n+\t\t\tstatic_cast<int32_t>(controls::AwbTungsten),\n+\t\t\tstatic_cast<int32_t>(controls::AwbFluorescent),\n+\t\t\tstatic_cast<int32_t>(controls::AwbDaylight),\n+\t\t};\n+\t\tControlInfo awbModes(Span<const ControlValue>{ modes });\n+\n+\t\tif (awbModes.min() != modes.front() ||\n+\t\t awbModes.def() != modes.front() ||\n+\t\t awbModes.max() != modes.back()) {\n+\t\t\tcout << \"Invalid control range for AwbModes\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (awbModes.values().size() != modes.size()) {\n+\t\t\tcout << \"Invalid size for AwbModes\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tunsigned int i = 0;\n+\t\tfor (const auto &value : awbModes.values()) {\n+\t\t\tif (value != modes.at(i++)) {\n+\t\t\t\tcout << \"Invalid control values for AwbModes\" << endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\t\t}\n+\n \t\treturn TestPass;\n \t}\n };\n", "prefixes": [] }