Patch Detail
Show a patch.
GET /api/1.1/patches/21201/?format=api
{ "id": 21201, "url": "https://patchwork.libcamera.org/api/1.1/patches/21201/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21201/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240909091431.3688159-1-chenghaoyang@google.com>", "date": "2024-09-09T09:14:29", "name": "[v3] libcamera: Make FrameBuffer status default to FrameError", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "97c50bac13d2eaacce6907e98001ce9a7bb724de", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21201/mbox/", "series": [ { "id": 4569, "url": "https://patchwork.libcamera.org/api/1.1/series/4569/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4569", "date": "2024-09-09T09:14:29", "name": "[v3] libcamera: Make FrameBuffer status default to FrameError", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4569/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21201/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21201/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCCFFC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Sep 2024 09:14:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60B16634F7;\n\tMon, 9 Sep 2024 11:14:39 +0200 (CEST)", "from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB054634E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Sep 2024 11:14:37 +0200 (CEST)", "by mail-pj1-x102e.google.com with SMTP id\n\t98e67ed59e1d1-2d8b679d7f2so3218518a91.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 09 Sep 2024 02:14:37 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-2dadc110504sm6119025a91.38.2024.09.09.02.14.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 09 Sep 2024 02:14:35 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"OdPWlziH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725873276; x=1726478076;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=KiXtHgF+ZgjV/hrHXVdJzSFyP9QVE0fRDNll+nwWCKQ=;\n\tb=OdPWlziHPjDmcys2I8/cER/LkIObZmIyo+FZBubSIllk+xsqkDviAzDXlK49Dbiv5Z\n\taVypzShTuu9R4lI3oDrOAuEYmkQTxf1K5qrWfEd0XDYpPgyWn56MaKdJcIoJB6hnFvXr\n\tN6gSDNaP6drA5rg5x7dycrk9LnE4uZf1cv2js=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725873276; x=1726478076;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=KiXtHgF+ZgjV/hrHXVdJzSFyP9QVE0fRDNll+nwWCKQ=;\n\tb=cS79oY1beIquMDGhoTZS6uwU5ND2qYDi99ntPhzVvzxMjldfDOTVXlKksQqKKPGGPj\n\tqntDSZ23PKGgTkSQsrBM4Uf05T6F+V8sMmAtuqOdDxm9FQ9W2wOQE12Myg+INKFrvl6f\n\tWLj5zlD2Ty6qACep9TmxvKf5nkCe0WcF6tReD7SDDr+Fe2qCUwojvAo+o+pr/BVVnsD/\n\tXA+mmaprY8XYBzpTlcn4+7ezKHWmgCgR541fkLmqc11K/9OGhHuBfabym2rZ0CU85/nE\n\tsSWwDy5DObaBbqskzUQLcfbNDmwWfoXpa0T+PlTucVLgLrpq9TqtEEjoKGIN755D626y\n\t58IQ==", "X-Gm-Message-State": "AOJu0YzDFxYFd+GUBYbacIHN82RpzfRyvB75UE6+maN+1VDLz2SVcLtb\n\tEP9Zr4DGCqlSnDIUN7DKagrt4rJechLuf01cML2bcG0FUBONup4loDWy9a0Tw1TB67FMV2itxjQ\n\t=", "X-Google-Smtp-Source": "AGHT+IFXukipr0CS64xASssHs7Bs1ztnxfZW7nImsyQVDpSOw+TeOroxeNBZ9UsgEO2hNzoX2nKAEQ==", "X-Received": "by 2002:a17:90a:a414:b0:2d8:efd1:22e4 with SMTP id\n\t98e67ed59e1d1-2dad50c99f5mr13286066a91.26.1725873275661; \n\tMon, 09 Sep 2024 02:14:35 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Han-Lin Chen <hanlinchen@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v3] libcamera: Make FrameBuffer status default to FrameError", "Date": "Mon, 9 Sep 2024 09:14:29 +0000", "Message-ID": "<20240909091431.3688159-1-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.0.469.g59c65b2a67-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Han-Lin Chen <hanlinchen@chromium.org>\n\nTo make sure platforms follow V4L2 spec and frame buffers go through\nV4L2VideoDevice, setting default values to FrameMetadata's member\nvariables. Especially, status is defaulted to be FrameError.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/framebuffer.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex ff839243..ececc123 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -32,9 +32,9 @@ struct FrameMetadata {\n \t\tunsigned int bytesused;\n \t};\n \n-\tStatus status;\n-\tunsigned int sequence;\n-\tuint64_t timestamp;\n+\tStatus status = FrameError;\n+\tunsigned int sequence = 0;\n+\tuint64_t timestamp = 0;\n \n \tSpan<Plane> planes() { return planes_; }\n \tSpan<const Plane> planes() const { return planes_; }\n", "prefixes": [ "v3" ] }