Patch Detail
Show a patch.
GET /api/1.1/patches/21200/?format=api
{ "id": 21200, "url": "https://patchwork.libcamera.org/api/1.1/patches/21200/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21200/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240909053425.3075699-1-chenghaoyang@google.com>", "date": "2024-09-09T05:34:19", "name": "[v2] libcamera: Make FrameBuffer status default to FrameSuccess", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6ce4ba706b0c2630486938c7cd8dc89f67e3faac", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21200/mbox/", "series": [ { "id": 4568, "url": "https://patchwork.libcamera.org/api/1.1/series/4568/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4568", "date": "2024-09-09T05:34:19", "name": "[v2] libcamera: Make FrameBuffer status default to FrameSuccess", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4568/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21200/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21200/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 774ADBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 9 Sep 2024 05:34:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45CE5634F4;\n\tMon, 9 Sep 2024 07:34:34 +0200 (CEST)", "from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com\n\t[IPv6:2607:f8b0:4864:20::102b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00BAF618F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 9 Sep 2024 07:34:31 +0200 (CEST)", "by mail-pj1-x102b.google.com with SMTP id\n\t98e67ed59e1d1-2d86f713557so2573276a91.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 08 Sep 2024 22:34:31 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(0.223.81.34.bc.googleusercontent.com. [34.81.223.0])\n\tby smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-2db043c0750sm3562440a91.23.2024.09.08.22.34.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Sep 2024 22:34:29 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"L9PJEmeg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725860069; x=1726464869;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=rehFMwW4+BdjvhkxY3Rz4PT0hq32lSEnVkVCylbtHgs=;\n\tb=L9PJEmegNpnxgYeeeccVUwrFdxn96UjJqnr4njGOrXggLHvnJ3D8/KeJZkvVzed9eW\n\tYJFtck9vmdH9kfy/aT+putTLQS5P3+Gg/y/ZM+t8/5tjVDhM1DHsB1fWVxQMUNj7Ks7b\n\t/iEZjFBh6zQx6nS8JNte6cuLoNKWntrqPJ/8M=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725860069; x=1726464869;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=rehFMwW4+BdjvhkxY3Rz4PT0hq32lSEnVkVCylbtHgs=;\n\tb=wAa2fl8Ex74/P6+JQH+KXnhP32jr9Qn9eQNg8lubiINZuZ3TQnFfXPp3138TfTM/x/\n\t+rMVpZ6oLXo7IWMoaefEVzrLVXPkmXGe2Fyn9UwQuv3Wyjcjg9F3DaKMnItugmqiawJM\n\thdDMctjN1hkhR4W0djbiaCweOJEmJvC7ZqrnMchNW5NC/CT9PuPuXcGZu35DQnR2BmoX\n\tfqp4ctZ5KJJsPe/f0mHxbizUdbSKW4dZwVOVFBi+cqSL8vdaagAikY5YE6RK5QyWuMDN\n\tJ7aJcm/vMuqWBv13OeE6B38jTFhOs+tv4RWald3TZDUk27K0P7onuel1o21I5Btzd2NL\n\t1/0Q==", "X-Gm-Message-State": "AOJu0YxxTLTcsu329ngbIJ+GhfRDd9gPNvkEFmsFuCp2xspmpuzMlGOB\n\tvp5T0v+avX3WlgfcD8V95b34GFGNxvq/vj+IkWsaVDrBPZSRn53ZKeWukXYEjIDRYmyF3U01scM\n\t=", "X-Google-Smtp-Source": "AGHT+IGkumPClh4K54120RpLVPKw3ACnvZ4GfIIAwXszSAMyd4KRvNBiYCg5blHdGtjDvho6EbJrNA==", "X-Received": "by 2002:a17:90b:196:b0:2d3:c664:e253 with SMTP id\n\t98e67ed59e1d1-2dad4ef6033mr13757495a91.10.1725860069496; \n\tSun, 08 Sep 2024 22:34:29 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Han-Lin Chen <hanlinchen@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH v2] libcamera: Make FrameBuffer status default to\n\tFrameSuccess", "Date": "Mon, 9 Sep 2024 05:34:19 +0000", "Message-ID": "<20240909053425.3075699-1-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.0.469.g59c65b2a67-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Han-Lin Chen <hanlinchen@chromium.org>\n\nTo solve issues when platforms not following V4L2 spec and frame\nbuffers not going through V4L2VideoDevice, setting default values\nto FrameMetadata's member variables.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n include/libcamera/framebuffer.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex ff839243..8dae747c 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -32,9 +32,9 @@ struct FrameMetadata {\n \t\tunsigned int bytesused;\n \t};\n \n-\tStatus status;\n-\tunsigned int sequence;\n-\tuint64_t timestamp;\n+\tStatus status = FrameSuccess;\n+\tunsigned int sequence = 0;\n+\tuint64_t timestamp = 0;\n \n \tSpan<Plane> planes() { return planes_; }\n \tSpan<const Plane> planes() const { return planes_; }\n", "prefixes": [ "v2" ] }