Patch Detail
Show a patch.
GET /api/1.1/patches/21185/?format=api
{ "id": 21185, "url": "https://patchwork.libcamera.org/api/1.1/patches/21185/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21185/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240906120927.4071508-13-mzamazal@redhat.com>", "date": "2024-09-06T12:09:21", "name": "[v6,12/18] libcamera: software_isp: Call Algorithm::process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "10c08d184e3c57ce307d826163eb8311b880a778", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21185/mbox/", "series": [ { "id": 4566, "url": "https://patchwork.libcamera.org/api/1.1/series/4566/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4566", "date": "2024-09-06T12:09:09", "name": "Software ISP refactoring", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4566/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21185/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21185/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 951E7BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Sep 2024 12:10:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85259634FA;\n\tFri, 6 Sep 2024 14:10:36 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E43A634FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Sep 2024 14:10:22 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-438-3N6ebnBbMDSYOXCgfgBSTA-1;\n\tFri, 06 Sep 2024 08:10:19 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id AB6231956096; Fri, 6 Sep 2024 12:10:17 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.65])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id B08AF1956086; Fri, 6 Sep 2024 12:10:15 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"E6uR2zvh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725624620;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=RbyAJlXBktvqX7d9o7V2fel/xt8W2HigLsJ6IKCxoWs=;\n\tb=E6uR2zvhvq0hw6CUv2EC/qzYFoOv0vj6jjPTp/2+e3kFzdgbKL73iw7rudpSlTfwCjth85\n\tfMMHWsZq9tnhH//ykQYdaWOSQcL6dAdunQxTHJ4SpEo72spPnFTYhDO01/NBT1gz8n/4YE\n\tmyj2FbDXoz973IVNejYlK+OtRl79XPc=", "X-MC-Unique": "3N6ebnBbMDSYOXCgfgBSTA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v6 12/18] libcamera: software_isp: Call Algorithm::process", "Date": "Fri, 6 Sep 2024 14:09:21 +0200", "Message-ID": "<20240906120927.4071508-13-mzamazal@redhat.com>", "In-Reply-To": "<20240906120927.4071508-1-mzamazal@redhat.com>", "References": "<20240906120927.4071508-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds Algorithm::process call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nAs software ISP currently doesn't produce any metadata, a dummy and\nunused metadata instance is created to satisfy Algorithm::process API.\nThis should be changed in future.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 3a0cb6e0..5beec45a 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -287,10 +287,21 @@ void IPASoftSimple::fillParamsBuffer(const uint32_t frame)\n \t\talgo->prepare(context_, frame, frameContext, params_);\n }\n \n-void IPASoftSimple::processStats([[maybe_unused]] const uint32_t frame,\n+void IPASoftSimple::processStats(const uint32_t frame,\n \t\t\t\t [[maybe_unused]] const uint32_t bufferId,\n \t\t\t\t const ControlList &sensorControls)\n {\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\t/*\n+\t * Software ISP currently does not produce any metadata. Use an empty\n+\t * ControlList for now.\n+\t *\n+\t * \\todo Implement proper metadata handling\n+\t */\n+\tControlList metadata(controls::controls);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->process(context_, frame, frameContext, stats_, metadata);\n+\n \tSwIspStats::Histogram histogram = stats_->yHistogram;\n \tif (ignoreUpdates_ > 0)\n \t\tblackLevel_.update(histogram);\n", "prefixes": [ "v6", "12/18" ] }