Patch Detail
Show a patch.
GET /api/1.1/patches/21158/?format=api
{ "id": 21158, "url": "https://patchwork.libcamera.org/api/1.1/patches/21158/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21158/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240903161059.246075-2-stefan.klug@ideasonboard.com>", "date": "2024-09-03T16:10:54", "name": "[v2,1/2] utils: checkstyle: Add a python formatter", "commit_ref": "8ffaf376bb53f6c4433e1fda4078f66dc5e69af5", "pull_url": null, "state": "accepted", "archived": false, "hash": "6e0f1ec086024a1564aaa86cfea5355e9be90f67", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21158/mbox/", "series": [ { "id": 4560, "url": "https://patchwork.libcamera.org/api/1.1/series/4560/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4560", "date": "2024-09-03T16:10:53", "name": "Python improvements to checkstyle.py", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4560/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21158/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21158/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6A9DC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Sep 2024 16:11:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62E2C634A6;\n\tTue, 3 Sep 2024 18:11:10 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11B15634A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Sep 2024 18:11:09 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6c8f:1e7a:f75:b6f6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1958916A;\n\tTue, 3 Sep 2024 18:09:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OTzRa3vi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725379797;\n\tbh=2RY8m2fug+NPxeEmCWbkkP5sKJBe9MfIIN74EVqNOPw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OTzRa3vieffe+a/NdAHtA7DKgzHpgdBqz++Q1fcUuZ8iUs/TnX2sAWegnKXdEdDd+\n\tbQC4tYv7vwapcYECgYO3Jx44I/e7oFplRp+zbYB5TOWg/ZGiR7AWEYoX0OyMWYflUC\n\tuAJpTCA82+/7Z1J6yCc19+1PoXJXv3RxK6N9RQj0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 1/2] utils: checkstyle: Add a python formatter", "Date": "Tue, 3 Sep 2024 18:10:54 +0200", "Message-ID": "<20240903161059.246075-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240903161059.246075-1-stefan.klug@ideasonboard.com>", "References": "<20240903161059.246075-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Reporting style issues on python files is great, automatically fixing them is\neven better. Add a call to autopep8 for python files. This fixes the same\nissues as the ones reported by pycodestyle.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/checkstyle.py | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex c9e41d4149f7..1ee211c3bb9b 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -943,6 +943,21 @@ class IncludeOrderFormatter(Formatter):\n return '\\n'.join(lines)\n \n \n+class Pep8Formatter(Formatter):\n+ patterns = ('*.py',)\n+\n+ @classmethod\n+ def format(cls, filename, data):\n+ try:\n+ ret = subprocess.run(['autopep8', '--ignore=E501', '-'],\n+ input=data.encode('utf-8'), stdout=subprocess.PIPE)\n+ except FileNotFoundError:\n+ issues.append(StyleIssue(0, None, None, 'Please install autopep8 to format python additions'))\n+ return issues\n+\n+ return ret.stdout.decode('utf-8')\n+\n+\n class StripTrailingSpaceFormatter(Formatter):\n patterns = ('*.c', '*.cpp', '*.h', '*.py', 'meson.build')\n \n", "prefixes": [ "v2", "1/2" ] }