Patch Detail
Show a patch.
GET /api/1.1/patches/21154/?format=api
{ "id": 21154, "url": "https://patchwork.libcamera.org/api/1.1/patches/21154/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21154/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240903104018.3289112-2-chenghaoyang@chromium.org>", "date": "2024-09-03T10:39:17", "name": "[v4,1/3] libcamera: Add rectangle two-point constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bf7c3623e53907c2d7186ff1ca30e15305e23f91", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21154/mbox/", "series": [ { "id": 4559, "url": "https://patchwork.libcamera.org/api/1.1/series/4559/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4559", "date": "2024-09-03T10:39:16", "name": "Add Face Detection Controls", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4559/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21154/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21154/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86322BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Sep 2024 10:40:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D9C5634E9;\n\tTue, 3 Sep 2024 12:40:25 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A394634E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Sep 2024 12:40:22 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-42bb7298bdeso57621595e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Sep 2024 03:40:22 -0700 (PDT)", "from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42bb6deb239sm170546025e9.5.2024.09.03.03.40.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 03 Sep 2024 03:40:21 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"QSFcnAHM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725360021; x=1725964821;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dLRDrex9H8OhgXs/1LaRi31s0x2nDQspD1Ge9HvfBaQ=;\n\tb=QSFcnAHMHJRLiRO4NJQW2YO/b5iNJHUs8juPRK+4ygMXZPeFM/hjFDpmG5TFvUQJ+U\n\tlsmM2+Koy20rU+39/d6xaMsqoDVKwx+UFlpjKr8xPFPCugPWkr9uaJXzRv28qWFs7q30\n\tR3D/ZAO8i0H3IyHUE0tLBxe5eO5x4d75xoseY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725360021; x=1725964821;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dLRDrex9H8OhgXs/1LaRi31s0x2nDQspD1Ge9HvfBaQ=;\n\tb=VkUpeAAqD6PshzUgIHjb3XQT+/quNQPzhi7dLQe36G+QgH6PVjz72+cwHg5Ysm3gI3\n\tfJGJi4hw1A9BLK4lnBr5ATt8CjbwRPAUZ96tAe2SgYOTWEvyxxpyKgnS9jUkfTrRUxyl\n\tQGRPZfy/dUA6inG9zLiHrfsfDiaQFTwT2PKIGgyWENc6kRPfxImXmEnqnB+6N4dBtLVU\n\toyX8PUa1VUrcZ/VquGkRWRnuvkHE4xfN7GWudsGaLEOj/5qRMOT4KOSUqbUvs5aM5StA\n\ta1nmtuP8sH72lYRkSZ0gtz6voDLMTqU91AMAqPdsGlQfvSKFY5u0nnYAJkVa+uRqXAR2\n\tuoCg==", "X-Gm-Message-State": "AOJu0YxqyL9/4yq+x8hvCkS9uS2/U+cnOf8fLqgRAP5O2xNoDDQzaih5\n\t830l8kVrRONyQM783hzGaXduFFFiiIEnFc+MGFSssGOE0IObpxbLsvTIcxQ5s/YP9vMjYeLMwCM\n\tOUQ==", "X-Google-Smtp-Source": "AGHT+IG3Tjoh88Q/PglJtdjLbsuRAaHGXabsqM9BOmDWMOg1H+NInAB7wI0VaURBfzhbEIbGz7aabQ==", "X-Received": "by 2002:adf:f608:0:b0:374:c05f:2313 with SMTP id\n\tffacd0b85a97d-374c05f2775mr6967226f8f.45.1725360021317; \n\tTue, 03 Sep 2024 03:40:21 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Yudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v4 1/3] libcamera: Add rectangle two-point constructor", "Date": "Tue, 3 Sep 2024 10:39:17 +0000", "Message-ID": "<20240903104018.3289112-2-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.46.0.469.g59c65b2a67-goog", "In-Reply-To": "<20240903104018.3289112-1-chenghaoyang@chromium.org>", "References": "<20240903104018.3289112-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n\nAdd a Rectangle constructor that accepts two points:\ntopLeft and bottomRight.\n\nSigned-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\nCo-developed-by: Harvey Yang <chenghaoyang@chromium.org>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/geometry.h | 2 ++\n src/libcamera/geometry.cpp | 14 ++++++++++++++\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 3e6f0f5d7..dc56f180f 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -262,6 +262,8 @@ public:\n \t{\n \t}\n \n+\tconstexpr Rectangle(const Point &topLeft, const Point &bottomRight);\n+\n \tint x;\n \tint y;\n \tunsigned int width;\ndiff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 000151364..029b8dad2 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -629,6 +629,20 @@ std::ostream &operator<<(std::ostream &out, const SizeRange &sr)\n * \\param[in] size The desired Rectangle size\n */\n \n+/**\n+ * \\fn Rectangle::Rectangle(const Point &topLeft, const Point &bottomRight)\n+ * \\brief Construct a Rectangle with the two given points\n+ * \\param[in] topLeft The top-left corner\n+ * \\param[in] bottomRight The bottom-right corner\n+ */\n+constexpr Rectangle::Rectangle(const Point &topLeft, const Point &bottomRight)\n+\t: x(topLeft.x), y(topLeft.y),\n+\t width(bottomRight.x - x),\n+\t height(bottomRight.y - y)\n+{\n+\tASSERT(bottomRight.x >= x && bottomRight.y >= y);\n+}\n+\n /**\n * \\var Rectangle::x\n * \\brief The horizontal coordinate of the rectangle's top-left corner\n", "prefixes": [ "v4", "1/3" ] }