Patch Detail
Show a patch.
GET /api/1.1/patches/21137/?format=api
{ "id": 21137, "url": "https://patchwork.libcamera.org/api/1.1/patches/21137/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21137/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240902154212.1281257-8-mzamazal@redhat.com>", "date": "2024-09-02T15:42:00", "name": "[v3,07/18] libcamera: libipa: Remove unused includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "805da8b1bfb590b62f8dc5fc8f02c6722f2fd59b", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21137/mbox/", "series": [ { "id": 4556, "url": "https://patchwork.libcamera.org/api/1.1/series/4556/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4556", "date": "2024-09-02T15:41:53", "name": "Remove unused includes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4556/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21137/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21137/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CB20BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 2 Sep 2024 15:42:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05519634ED;\n\tMon, 2 Sep 2024 17:42:51 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF65E634E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 2 Sep 2024 17:42:48 +0200 (CEST)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-554-otaTjECaOtSYi4orLGpOYA-1;\n\tMon, 02 Sep 2024 11:42:44 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id EF9691954128; Mon, 2 Sep 2024 15:42:43 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.69])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 632D01955F1B; Mon, 2 Sep 2024 15:42:42 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RjtRaVDS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725291767;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=DX4AIl8wG+M4MdaVnNOf1apBhr9URzfyb+ZcD+/HcsY=;\n\tb=RjtRaVDSGS8h73HrRpXGjhQiXC5W1EEoVPTb6WppNwZnboUFjR0XN2iLy3swTGolTZtLAw\n\tCJp5JgiFIIyCGCbXHvMB9LpF3FsER4bPEU8LJz74i5JBh+Za7ZXPibbiYkWgHq1adjxnO1\n\tXQ2Yp5svBc7yBfdXrocdVl0np/zmvMU=", "X-MC-Unique": "otaTjECaOtSYi4orLGpOYA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 07/18] libcamera: libipa: Remove unused includes", "Date": "Mon, 2 Sep 2024 17:42:00 +0200", "Message-ID": "<20240902154212.1281257-8-mzamazal@redhat.com>", "In-Reply-To": "<20240902154212.1281257-1-mzamazal@redhat.com>", "References": "<20240902154212.1281257-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes that are not used can be removed. And two identified\nmissing includes (directly used but available only through other\nincludes) are added.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/libipa/histogram.h | 1 -\n src/ipa/libipa/matrix.h | 1 -\n src/ipa/libipa/matrix_interpolator.cpp | 7 -------\n src/ipa/libipa/matrix_interpolator.h | 2 --\n src/ipa/libipa/pwl.cpp | 2 --\n src/ipa/libipa/pwl.h | 3 ---\n src/ipa/libipa/vector.h | 4 ++--\n 7 files changed, 2 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex 032adca0..6fd64168 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -7,7 +7,6 @@\n \n #pragma once\n \n-#include <assert.h>\n #include <limits.h>\n #include <stdint.h>\n #include <type_traits>\ndiff --git a/src/ipa/libipa/matrix.h b/src/ipa/libipa/matrix.h\nindex 8aa8f343..5471e697 100644\n--- a/src/ipa/libipa/matrix.h\n+++ b/src/ipa/libipa/matrix.h\n@@ -7,7 +7,6 @@\n #pragma once\n \n #include <algorithm>\n-#include <cmath>\n #include <sstream>\n #include <vector>\n \ndiff --git a/src/ipa/libipa/matrix_interpolator.cpp b/src/ipa/libipa/matrix_interpolator.cpp\nindex 04ca177f..d5188f8a 100644\n--- a/src/ipa/libipa/matrix_interpolator.cpp\n+++ b/src/ipa/libipa/matrix_interpolator.cpp\n@@ -6,15 +6,8 @@\n */\n #include \"matrix_interpolator.h\"\n \n-#include <algorithm>\n-#include <string>\n-\n #include <libcamera/base/log.h>\n \n-#include \"libcamera/internal/yaml_parser.h\"\n-\n-#include \"matrix.h\"\n-\n /**\n * \\file matrix_interpolator.h\n * \\brief Helper class for interpolating maps of matrices\ndiff --git a/src/ipa/libipa/matrix_interpolator.h b/src/ipa/libipa/matrix_interpolator.h\nindex 087c4fd1..afbce538 100644\n--- a/src/ipa/libipa/matrix_interpolator.h\n+++ b/src/ipa/libipa/matrix_interpolator.h\n@@ -7,10 +7,8 @@\n \n #pragma once\n \n-#include <algorithm>\n #include <map>\n #include <string>\n-#include <tuple>\n \n #include <libcamera/base/log.h>\n \ndiff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\nindex 9b213754..88fe2022 100644\n--- a/src/ipa/libipa/pwl.cpp\n+++ b/src/ipa/libipa/pwl.cpp\n@@ -8,10 +8,8 @@\n \n #include \"pwl.h\"\n \n-#include <assert.h>\n #include <cmath>\n #include <sstream>\n-#include <stdexcept>\n \n /**\n * \\file pwl.h\ndiff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\nindex b6f93494..d4ec9f4f 100644\n--- a/src/ipa/libipa/pwl.h\n+++ b/src/ipa/libipa/pwl.h\n@@ -7,14 +7,11 @@\n #pragma once\n \n #include <algorithm>\n-#include <cmath>\n #include <functional>\n #include <string>\n #include <utility>\n #include <vector>\n \n-#include \"libcamera/internal/yaml_parser.h\"\n-\n #include \"vector.h\"\n \n namespace libcamera {\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 556e0967..8612a06a 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -6,10 +6,10 @@\n */\n #pragma once\n \n-#include <algorithm>\n #include <array>\n #include <cmath>\n-#include <sstream>\n+#include <optional>\n+#include <ostream>\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/span.h>\n", "prefixes": [ "v3", "07/18" ] }