Patch Detail
Show a patch.
GET /api/1.1/patches/21123/?format=api
{ "id": 21123, "url": "https://patchwork.libcamera.org/api/1.1/patches/21123/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21123/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240830152721.1420313-20-mzamazal@redhat.com>", "date": "2024-08-30T15:27:16", "name": "[v2,19/20] libcamera: includes: Remove unused includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "50ab0ea766b75b6d943dc5b01d2647d8c38d09fb", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21123/mbox/", "series": [ { "id": 4552, "url": "https://patchwork.libcamera.org/api/1.1/series/4552/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4552", "date": "2024-08-30T15:26:57", "name": "Remove unused includes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4552/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21123/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21123/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 202F0C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 15:28:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 878D4634EA;\n\tFri, 30 Aug 2024 17:28:25 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5ABC6634EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 17:28:04 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-651-KUiRFNQXOcOFId9cwsCsCg-1;\n\tFri, 30 Aug 2024 11:28:01 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 05AC71955D4C for <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 15:28:01 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id AD1C61956048; Fri, 30 Aug 2024 15:27:59 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"PWY0tsYX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725031683;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=vSXfMI5XMHAkJFEnEPXS0s5Hnd66WG1oxMV7zMAbFwc=;\n\tb=PWY0tsYXCOv2krFvieU306IHeervztLBFy2WXC9zvVWXE7WVT2gSLLSogiV8sIjOOBGqXj\n\tGirLWYAucF9nPoqZYF3KLgS4KZK/qndw3us4CUHnMuvJmFc/Vpe0c9UsHmsnMUpuC+HONo\n\t+iBEM1akZ2x4uhmkk+cw8TIaRqxaeaA=", "X-MC-Unique": "KUiRFNQXOcOFId9cwsCsCg-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v2 19/20] libcamera: includes: Remove unused includes", "Date": "Fri, 30 Aug 2024 17:27:16 +0200", "Message-ID": "<20240830152721.1420313-20-mzamazal@redhat.com>", "In-Reply-To": "<20240830152721.1420313-1-mzamazal@redhat.com>", "References": "<20240830152721.1420313-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/base/event_dispatcher.h | 2 --\n include/libcamera/base/log.h | 1 -\n include/libcamera/base/memfd.h | 2 --\n include/libcamera/base/signal.h | 1 -\n include/libcamera/base/span.h | 1 -\n include/libcamera/base/timer.h | 1 -\n include/libcamera/base/utils.h | 1 -\n include/libcamera/framebuffer.h | 1 -\n include/libcamera/internal/camera_manager.h | 1 -\n include/libcamera/internal/camera_sensor.h | 1 -\n include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n include/libcamera/internal/dma_buf_allocator.h | 2 --\n include/libcamera/internal/formats.h | 1 -\n include/libcamera/internal/ipa_data_serializer.h | 4 ----\n include/libcamera/internal/ipa_proxy.h | 2 --\n include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n include/libcamera/internal/media_device.h | 1 -\n include/libcamera/internal/pipeline_handler.h | 3 ---\n include/libcamera/internal/shared_mem_object.h | 1 -\n include/libcamera/pixel_format.h | 1 -\n include/libcamera/request.h | 1 -\n include/libcamera/stream.h | 1 -\n include/libcamera/transform.h | 2 --\n 23 files changed, 33 deletions(-)", "diff": "diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\nindex e9a09c6e..408f8da6 100644\n--- a/include/libcamera/base/event_dispatcher.h\n+++ b/include/libcamera/base/event_dispatcher.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <vector>\n-\n #include <libcamera/base/private.h>\n \n namespace libcamera {\ndiff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex df27df03..62093012 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -7,7 +7,6 @@\n \n #pragma once\n \n-#include <chrono>\n #include <sstream>\n \n #include <libcamera/base/private.h>\ndiff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\nindex b0edd2de..705d9929 100644\n--- a/include/libcamera/base/memfd.h\n+++ b/include/libcamera/base/memfd.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <stddef.h>\n-\n #include <libcamera/base/flags.h>\n #include <libcamera/base/unique_fd.h>\n \ndiff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\nindex 849fbbda..bbff1495 100644\n--- a/include/libcamera/base/signal.h\n+++ b/include/libcamera/base/signal.h\n@@ -10,7 +10,6 @@\n #include <functional>\n #include <list>\n #include <type_traits>\n-#include <vector>\n \n #include <libcamera/base/bound_method.h>\n \ndiff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\nindex c3e63f69..92cce4f0 100644\n--- a/include/libcamera/base/span.h\n+++ b/include/libcamera/base/span.h\n@@ -10,7 +10,6 @@\n #include <array>\n #include <iterator>\n #include <limits>\n-#include <stddef.h>\n #include <type_traits>\n \n namespace libcamera {\ndiff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\nindex 5ef45959..9646a0fe 100644\n--- a/include/libcamera/base/timer.h\n+++ b/include/libcamera/base/timer.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <chrono>\n-#include <stdint.h>\n \n #include <libcamera/base/private.h>\n \ndiff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 734ff81e..98c683a7 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -10,7 +10,6 @@\n #include <algorithm>\n #include <chrono>\n #include <iterator>\n-#include <memory>\n #include <ostream>\n #include <sstream>\n #include <string>\ndiff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 5ae2270b..ff839243 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -7,7 +7,6 @@\n \n #pragma once\n \n-#include <assert.h>\n #include <limits>\n #include <memory>\n #include <stdint.h>\ndiff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\nindex e098cb69..0150ca61 100644\n--- a/include/libcamera/internal/camera_manager.h\n+++ b/include/libcamera/internal/camera_manager.h\n@@ -9,7 +9,6 @@\n \n #include <libcamera/camera_manager.h>\n \n-#include <map>\n #include <memory>\n #include <sys/types.h>\n #include <vector>\ndiff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex fc44ab98..a42c15fa 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -23,7 +23,6 @@\n #include <libcamera/ipa/core_ipa_interface.h>\n \n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n namespace libcamera {\ndiff --git a/include/libcamera/internal/device_enumerator_sysfs.h b/include/libcamera/internal/device_enumerator_sysfs.h\nindex a5bfc711..4ccc9845 100644\n--- a/include/libcamera/internal/device_enumerator_sysfs.h\n+++ b/include/libcamera/internal/device_enumerator_sysfs.h\n@@ -7,7 +7,6 @@\n \n #pragma once\n \n-#include <memory>\n #include <string>\n \n #include \"libcamera/internal/device_enumerator.h\"\ndiff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\nindex 36ec1696..d2a0a0d1 100644\n--- a/include/libcamera/internal/dma_buf_allocator.h\n+++ b/include/libcamera/internal/dma_buf_allocator.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <stddef.h>\n-\n #include <libcamera/base/flags.h>\n #include <libcamera/base/unique_fd.h>\n \ndiff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex 71895cd8..6a3e9c16 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <array>\n-#include <map>\n #include <vector>\n \n #include <libcamera/geometry.h>\ndiff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\nindex 337c948c..13470a89 100644\n--- a/include/libcamera/internal/ipa_data_serializer.h\n+++ b/include/libcamera/internal/ipa_data_serializer.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <deque>\n-#include <iostream>\n #include <string.h>\n #include <tuple>\n #include <type_traits>\n@@ -22,8 +20,6 @@\n #include <libcamera/geometry.h>\n #include <libcamera/ipa/ipa_interface.h>\n \n-#include \"libcamera/internal/byte_stream_buffer.h\"\n-#include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/control_serializer.h\"\n \n namespace libcamera {\ndiff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex 0f564d99..983bcc5f 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -7,9 +7,7 @@\n \n #pragma once\n \n-#include <memory>\n #include <string>\n-#include <vector>\n \n #include <libcamera/ipa/ipa_interface.h>\n \ndiff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\nindex 4a0f6d57..8c972613 100644\n--- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n+++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n@@ -9,7 +9,6 @@\n \n #include <map>\n #include <memory>\n-#include <vector>\n \n #include \"libcamera/internal/ipc_pipe.h\"\n #include \"libcamera/internal/ipc_unixsocket.h\"\ndiff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\nindex bf2e475d..e412d3a0 100644\n--- a/include/libcamera/internal/media_device.h\n+++ b/include/libcamera/internal/media_device.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <map>\n-#include <sstream>\n #include <string>\n #include <vector>\n \ndiff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex cad5812f..c37e6d02 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -9,7 +9,6 @@\n \n #include <memory>\n #include <queue>\n-#include <set>\n #include <string>\n #include <sys/types.h>\n #include <vector>\n@@ -20,8 +19,6 @@\n #include <libcamera/controls.h>\n #include <libcamera/stream.h>\n \n-#include \"libcamera/internal/ipa_proxy.h\"\n-\n namespace libcamera {\n \n class Camera;\ndiff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex 2ab0189f..e9f1dacd 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -8,7 +8,6 @@\n */\n #pragma once\n \n-#include <stddef.h>\n #include <stdint.h>\n #include <string>\n #include <sys/mman.h>\ndiff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\nindex ea60fe72..1b4d8c7c 100644\n--- a/include/libcamera/pixel_format.h\n+++ b/include/libcamera/pixel_format.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <ostream>\n-#include <set>\n #include <stdint.h>\n #include <string>\n \ndiff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 2c78d9bb..e214a9d1 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -12,7 +12,6 @@\n #include <ostream>\n #include <stdint.h>\n #include <string>\n-#include <unordered_set>\n \n #include <libcamera/base/class.h>\n #include <libcamera/base/signal.h>\ndiff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex d510238a..071b7169 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <map>\n-#include <memory>\n #include <ostream>\n #include <string>\n #include <vector>\ndiff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nindex a88f809e..4517412a 100644\n--- a/include/libcamera/transform.h\n+++ b/include/libcamera/transform.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <string>\n-\n namespace libcamera {\n \n enum class Orientation;\n", "prefixes": [ "v2", "19/20" ] }