Patch Detail
Show a patch.
GET /api/1.1/patches/21117/?format=api
{ "id": 21117, "url": "https://patchwork.libcamera.org/api/1.1/patches/21117/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21117/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240830152721.1420313-16-mzamazal@redhat.com>", "date": "2024-08-30T15:27:12", "name": "[v2,15/20] libcamera: libcamera: Remove unused includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2d1a689a1ac0990900082f211180fff441524a3b", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21117/mbox/", "series": [ { "id": 4552, "url": "https://patchwork.libcamera.org/api/1.1/series/4552/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4552", "date": "2024-08-30T15:26:57", "name": "Remove unused includes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4552/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21117/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21117/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35EDDC32DA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 15:28:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A20D634E0;\n\tFri, 30 Aug 2024 17:28:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF340634E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 17:27:56 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-330-hoRfMvdUNHGmTCRtcuVGnA-1;\n\tFri, 30 Aug 2024 11:27:54 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 761041955D4C for <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 15:27:53 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5316A1955F40; Fri, 30 Aug 2024 15:27:52 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"OZltvbu8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725031675;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=t0XXIy6FoNHTn2xpxmNvFCoW2WkxlaT9Uzbi7AfrBMM=;\n\tb=OZltvbu8dCE6A9ag1IJsS9/3qU6Edx86Hoysr8PNXyJWonatrY/UymeT1OOr4IT1Z8wPiV\n\tGY56Czms1SmHbvJmcu9sLGiRkqqTx28+DDI3anlVBQCoaWx0D7XnX8x5jZqJ0gMvhSHNJU\n\tbpRbo35iJXNNxsEF/fM1Qtwb9IEjZfg=", "X-MC-Unique": "hoRfMvdUNHGmTCRtcuVGnA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v2 15/20] libcamera: libcamera: Remove unused includes", "Date": "Fri, 30 Aug 2024 17:27:12 +0200", "Message-ID": "<20240830152721.1420313-16-mzamazal@redhat.com>", "In-Reply-To": "<20240830152721.1420313-1-mzamazal@redhat.com>", "References": "<20240830152721.1420313-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/base/event_dispatcher_poll.cpp | 1 -\n src/libcamera/camera.cpp | 2 --\n src/libcamera/controls.cpp | 1 -\n src/libcamera/converter/converter_v4l2_m2m.cpp | 1 -\n src/libcamera/formats.cpp | 3 ---\n src/libcamera/ipa_module.cpp | 1 -\n src/libcamera/ipa_proxy.cpp | 1 -\n src/libcamera/orientation.cpp | 1 -\n src/libcamera/pipeline_handler.cpp | 1 -\n src/libcamera/process.cpp | 1 -\n src/libcamera/sensor/camera_sensor.cpp | 2 --\n src/libcamera/shared_mem_object.cpp | 1 -\n src/libcamera/stream.cpp | 2 --\n 13 files changed, 18 deletions(-)", "diff": "diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\nindex b737ca7a..86a26f36 100644\n--- a/src/libcamera/base/event_dispatcher_poll.cpp\n+++ b/src/libcamera/base/event_dispatcher_poll.cpp\n@@ -7,7 +7,6 @@\n \n #include <libcamera/base/event_dispatcher_poll.h>\n \n-#include <algorithm>\n #include <chrono>\n #include <iomanip>\n #include <poll.h>\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 382a68f7..88210ff3 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -9,7 +9,6 @@\n \n #include <array>\n #include <atomic>\n-#include <iomanip>\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/thread.h>\n@@ -21,7 +20,6 @@\n \n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_controls.h\"\n-#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/request.h\"\n \ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 11d35321..67400797 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -7,7 +7,6 @@\n \n #include <libcamera/controls.h>\n \n-#include <iomanip>\n #include <sstream>\n #include <string>\n #include <string.h>\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 006ba9f7..e4f656da 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -8,7 +8,6 @@\n \n #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n \n-#include <algorithm>\n #include <limits.h>\n \n #include <libcamera/base/log.h>\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 1d1d9a30..3ee89590 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -7,9 +7,6 @@\n \n #include \"libcamera/internal/formats.h\"\n \n-#include <algorithm>\n-#include <errno.h>\n-\n #include <libcamera/base/log.h>\n #include <libcamera/base/utils.h>\n \ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 0756b691..86d88a86 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -8,7 +8,6 @@\n #include \"libcamera/internal/ipa_module.h\"\n \n #include <algorithm>\n-#include <array>\n #include <ctype.h>\n #include <dlfcn.h>\n #include <elf.h>\ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex 69975d8f..85004737 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -7,7 +7,6 @@\n \n #include \"libcamera/internal/ipa_proxy.h\"\n \n-#include <string.h>\n #include <sys/stat.h>\n #include <sys/types.h>\n #include <unistd.h>\ndiff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\nindex fd191197..bf960249 100644\n--- a/src/libcamera/orientation.cpp\n+++ b/src/libcamera/orientation.cpp\n@@ -8,7 +8,6 @@\n #include <libcamera/orientation.h>\n \n #include <array>\n-#include <string>\n \n /**\n * \\file orientation.h\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 1fc22d6a..a63d3503 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -22,7 +22,6 @@\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n-#include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/request.h\"\n #include \"libcamera/internal/tracepoints.h\"\ndiff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 86d27b2d..c0f4d49f 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -10,7 +10,6 @@\n #include <algorithm>\n #include <dirent.h>\n #include <fcntl.h>\n-#include <iostream>\n #include <list>\n #include <signal.h>\n #include <string.h>\ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex c6d7f801..1382081a 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -10,7 +10,6 @@\n \n #include <algorithm>\n #include <float.h>\n-#include <iomanip>\n #include <limits.h>\n #include <math.h>\n #include <string.h>\n@@ -24,7 +23,6 @@\n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n-#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/sysfs.h\"\n \n /**\ndiff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\nindex d4c7991a..65b53919 100644\n--- a/src/libcamera/shared_mem_object.cpp\n+++ b/src/libcamera/shared_mem_object.cpp\n@@ -10,7 +10,6 @@\n \n #include \"libcamera/internal/shared_mem_object.h\"\n \n-#include <stddef.h>\n #include <stdint.h>\n #include <sys/mman.h>\n #include <sys/types.h>\ndiff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 053cc4b8..e70688f6 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -9,9 +9,7 @@\n \n #include <algorithm>\n #include <array>\n-#include <iomanip>\n #include <limits.h>\n-#include <sstream>\n \n #include <libcamera/request.h>\n \n", "prefixes": [ "v2", "15/20" ] }