Patch Detail
Show a patch.
GET /api/1.1/patches/21113/?format=api
{ "id": 21113, "url": "https://patchwork.libcamera.org/api/1.1/patches/21113/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21113/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240830152721.1420313-11-mzamazal@redhat.com>", "date": "2024-08-30T15:27:07", "name": "[v2,10/20] libcamera: v4l2: Remove unused includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9fb914b461c6da29271e23a4f78c2f32ecb792fb", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21113/mbox/", "series": [ { "id": 4552, "url": "https://patchwork.libcamera.org/api/1.1/series/4552/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4552", "date": "2024-08-30T15:26:57", "name": "Remove unused includes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4552/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21113/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21113/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 007BBC32D6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 15:27:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 423FF634CD;\n\tFri, 30 Aug 2024 17:27:58 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B560B634CB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 17:27:47 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-47-p2LG4WyiOXCreEX2oDSNWQ-1;\n\tFri, 30 Aug 2024 11:27:45 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid A7E921955D53 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 15:27:44 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 378B51955F43; Fri, 30 Aug 2024 15:27:42 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UHGAODi/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725031666;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=s6063w1R0fX9t1o4dkx/6Pu0BRIXYFXQ9EyZmMjjVr8=;\n\tb=UHGAODi/6dp3PwvDQ7u8v/9tBD1buLyoyuMVqlzdzc2NLt3TSyaS+HSnqWUWovUgY4epmy\n\tmGMcc0EFxMrKvjw5U1//XqzWAdE4G0NTYotwyq65fU94BpEIbrjK3dZS1Ny1M8Lh++ECtP\n\tPia+4vsRutV5QrMkUwKaH65dXMdFWYY=", "X-MC-Unique": "p2LG4WyiOXCreEX2oDSNWQ-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v2 10/20] libcamera: v4l2: Remove unused includes", "Date": "Fri, 30 Aug 2024 17:27:07 +0200", "Message-ID": "<20240830152721.1420313-11-mzamazal@redhat.com>", "In-Reply-To": "<20240830152721.1420313-1-mzamazal@redhat.com>", "References": "<20240830152721.1420313-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The includes that are not used can be removed.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/v4l2_device.cpp | 2 --\n src/libcamera/v4l2_subdevice.cpp | 1 -\n src/libcamera/v4l2_videodevice.cpp | 1 -\n src/v4l2/v4l2_camera.h | 1 -\n src/v4l2/v4l2_camera_proxy.cpp | 1 -\n src/v4l2/v4l2_compat.cpp | 1 -\n src/v4l2/v4l2_compat_manager.cpp | 1 -\n 7 files changed, 8 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 4a2048cf..68add4f2 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -8,8 +8,6 @@\n #include \"libcamera/internal/v4l2_device.h\"\n \n #include <fcntl.h>\n-#include <iomanip>\n-#include <limits.h>\n #include <map>\n #include <stdlib.h>\n #include <string.h>\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 82824433..6eaa8f01 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -8,7 +8,6 @@\n #include \"libcamera/internal/v4l2_subdevice.h\"\n \n #include <fcntl.h>\n-#include <iomanip>\n #include <regex>\n #include <sstream>\n #include <string.h>\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 6f32521f..76742e18 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -10,7 +10,6 @@\n #include <algorithm>\n #include <array>\n #include <fcntl.h>\n-#include <iomanip>\n #include <sstream>\n #include <string.h>\n #include <sys/ioctl.h>\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 278cc33e..e4e9a626 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -8,7 +8,6 @@\n #pragma once\n \n #include <deque>\n-#include <utility>\n \n #include <libcamera/base/mutex.h>\n #include <libcamera/base/semaphore.h>\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 3f7c00a2..a020a2b0 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -8,7 +8,6 @@\n #include \"v4l2_camera_proxy.h\"\n \n #include <algorithm>\n-#include <array>\n #include <errno.h>\n #include <numeric>\n #include <set>\ndiff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp\nindex 6c9dca72..ff833f57 100644\n--- a/src/v4l2/v4l2_compat.cpp\n+++ b/src/v4l2/v4l2_compat.cpp\n@@ -8,7 +8,6 @@\n #include \"v4l2_compat_manager.h\"\n \n #include <assert.h>\n-#include <errno.h>\n #include <fcntl.h>\n #include <stdarg.h>\n #include <sys/ioctl.h>\ndiff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\nindex 6a00afb5..f53fb300 100644\n--- a/src/v4l2/v4l2_compat_manager.cpp\n+++ b/src/v4l2/v4l2_compat_manager.cpp\n@@ -10,7 +10,6 @@\n #include <dlfcn.h>\n #include <fcntl.h>\n #include <map>\n-#include <stdarg.h>\n #include <string.h>\n #include <sys/eventfd.h>\n #include <sys/mman.h>\n", "prefixes": [ "v2", "10/20" ] }