Patch Detail
Show a patch.
GET /api/1.1/patches/21082/?format=api
{ "id": 21082, "url": "https://patchwork.libcamera.org/api/1.1/patches/21082/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21082/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240830125311.1702053-4-stefan.klug@ideasonboard.com>", "date": "2024-08-30T12:53:00", "name": "[3/3] utils: checkstyle: Add a python formatter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5398a9480bdb0e95e5cebc3cd1bb26be61687730", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21082/mbox/", "series": [ { "id": 4550, "url": "https://patchwork.libcamera.org/api/1.1/series/4550/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4550", "date": "2024-08-30T12:52:57", "name": "Python improvements to checkstyle.py", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4550/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21082/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21082/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAAE7C32C2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 12:53:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A580634CB;\n\tFri, 30 Aug 2024 14:53:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3666D634CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 14:53:28 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:cdac:b850:c793:ea45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CDDA227;\n\tFri, 30 Aug 2024 14:52:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OxpwADAi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725022339;\n\tbh=5DyUirRWXcKgZ9sFV/gFzJ9MFHuB7wY4kgwZ3tjYRrs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OxpwADAint9ON1C7L/NhSch8BSjCTcY60K516N4WD4uX3non42pbG7dSpD0XXelGh\n\tYe0CeV54PBRsnj+fQB7N78vwFdyw4BV2A3znApBFnO6xlVOOoTen0JnpcdWGZNki4Q\n\tu8f4TcmU50T2O2wevYclGMSyEW1B8OJYc9Vh9UfE=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 3/3] utils: checkstyle: Add a python formatter", "Date": "Fri, 30 Aug 2024 14:53:00 +0200", "Message-ID": "<20240830125311.1702053-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240830125311.1702053-1-stefan.klug@ideasonboard.com>", "References": "<20240830125311.1702053-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Reporting style issues on python files is great, automatically fixing\nthem is even better. Add a call to autopep8 for python files.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/checkstyle.py | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 5901f1a71562..ed15145b64a4 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -954,6 +954,21 @@ class StripTrailingSpaceFormatter(Formatter):\n return ''.join(lines)\n \n \n+class Pep8Formatter(Formatter):\n+ patterns = ('*.py',)\n+\n+ @classmethod\n+ def format(cls, filename, data):\n+ try:\n+ ret = subprocess.run(['autopep8', '--ignore=E501', '-'],\n+ input=data.encode('utf-8'), stdout=subprocess.PIPE)\n+ except FileNotFoundError:\n+ issues.append(StyleIssue(0, None, None, 'Please install autopep8 to format python additions'))\n+ return issues\n+\n+ return ret.stdout.decode('utf-8')\n+\n+\n # ------------------------------------------------------------------------------\n # Style checking\n #\n", "prefixes": [ "3/3" ] }