Patch Detail
Show a patch.
GET /api/1.1/patches/21058/?format=api
{ "id": 21058, "url": "https://patchwork.libcamera.org/api/1.1/patches/21058/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21058/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240830072554.180672-3-mzamazal@redhat.com>", "date": "2024-08-30T07:25:38", "name": "[v5,02/18] libcamera: software_isp: Move BlackLevel to libcamera::ipa::soft", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "29ac88f49c9b51c01da757fcad51d9da3db51e2f", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21058/mbox/", "series": [ { "id": 4548, "url": "https://patchwork.libcamera.org/api/1.1/series/4548/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4548", "date": "2024-08-30T07:25:36", "name": "Software ISP refactoring", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4548/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21058/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21058/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54BD1C32C2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Aug 2024 07:26:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDF69634CB;\n\tFri, 30 Aug 2024 09:26:14 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DFFC63458\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2024 09:26:12 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-691-RPYJ8WfxOQe-NGSra4w2cg-1;\n\tFri, 30 Aug 2024 03:26:09 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 742F31955D4F; Fri, 30 Aug 2024 07:26:08 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.65])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6281419560A3; Fri, 30 Aug 2024 07:26:06 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"L2n/CeYD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725002771;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=SxcxrWdqckPYJJM31vXC2zzG/WyUmEsjDhhR7dm2j24=;\n\tb=L2n/CeYDahV8r62JVWU6crdd/jf95iUK9YZDI293kqVySpwPlJpC7WvZ5vR/045UGR9vB5\n\teYYWIMkRBZDNQ/+747B2QMGCZ1pRFt6lXuoVBZvXZipIyJv2nsxVLc6bldtvgusupT1Uft\n\toVTaa3hXCgRO7kj/aqS7KSEVVnRof94=", "X-MC-Unique": "RPYJ8WfxOQe-NGSra4w2cg-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v5 02/18] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft", "Date": "Fri, 30 Aug 2024 09:25:38 +0200", "Message-ID": "<20240830072554.180672-3-mzamazal@redhat.com>", "In-Reply-To": "<20240830072554.180672-1-mzamazal@redhat.com>", "References": "<20240830072554.180672-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "IPA modules use custom namespaces for all their internal components to\navoid namespace clashes. The simple IPA module for the software ISP uses\nlibcamera::ipa::soft for this purpose. It however defines an internal\nclass named BlackLevel in the root of the libcamera namespace, making it\nprone to clashes. Move it to the ipa::soft namespace along with the rest\nof the code.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/ipa/simple/black_level.cpp | 5 +++++\n src/ipa/simple/black_level.h | 4 ++++\n 2 files changed, 9 insertions(+)", "diff": "diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\nindex cc490eb5..37e0109c 100644\n--- a/src/ipa/simple/black_level.cpp\n+++ b/src/ipa/simple/black_level.cpp\n@@ -15,6 +15,8 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftBL)\n \n+namespace ipa::soft {\n+\n /**\n * \\class BlackLevel\n * \\brief Object providing black point level for software ISP\n@@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)\n \t\t}\n \t};\n }\n+\n+} /* namespace ipa::soft */\n+\n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\nindex 5e032f9f..a04230c9 100644\n--- a/src/ipa/simple/black_level.h\n+++ b/src/ipa/simple/black_level.h\n@@ -14,6 +14,8 @@\n \n namespace libcamera {\n \n+namespace ipa::soft {\n+\n class BlackLevel\n {\n public:\n@@ -26,4 +28,6 @@ private:\n \tbool blackLevelSet_;\n };\n \n+} /* namespace ipa::soft */\n+\n } /* namespace libcamera */\n", "prefixes": [ "v5", "02/18" ] }