Patch Detail
Show a patch.
GET /api/1.1/patches/21038/?format=api
{ "id": 21038, "url": "https://patchwork.libcamera.org/api/1.1/patches/21038/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21038/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240827014044.24673-7-laurent.pinchart@ideasonboard.com>", "date": "2024-08-27T01:40:40", "name": "[v4,6/9] pipeline: rkisp1: Use the extensible parameters format", "commit_ref": "b43a06d1244784d0df96b0a8b3afe67f92eafc21", "pull_url": null, "state": "accepted", "archived": false, "hash": "d58b301a2af8365da1e587946f1c79ec6c9b24d1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21038/mbox/", "series": [ { "id": 4544, "url": "https://patchwork.libcamera.org/api/1.1/series/4544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4544", "date": "2024-08-27T01:40:34", "name": "rkisp1: Support BLS on i.MX8MP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21038/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21038/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2AE3C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Aug 2024 01:41:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 666AE63444;\n\tTue, 27 Aug 2024 03:41:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87CBD6343F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Aug 2024 03:40:57 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAE821583;\n\tTue, 27 Aug 2024 03:39:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N7QCiKM4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724722791;\n\tbh=9iWi9iVXEA7NOAgXLN51N1InWv69N2GH3UK1TDiQ7G0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=N7QCiKM42d8rN8wNRIP4vU+TMcdgPOKVrPFMxe5CCL5ivX+9mEiJW01H45dWpFdnk\n\t8OlwrkQRzrc0PNjkkWZJS3biQNQTj+6PQop1R1QPRpfuvjhXaNUo5qtpZezsSzlP9j\n\tGkTJq7M14KIkKERy9Q7T83f2zqjnYvcgkYjWtWRE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v4 6/9] pipeline: rkisp1: Use the extensible parameters\n\tformat", "Date": "Tue, 27 Aug 2024 04:40:40 +0300", "Message-ID": "<20240827014044.24673-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "References": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nNow that the IPA module supports the extensible parameters format,\nswitch to it when available. If the kernel driver doesn't support the\nnew format, setFormat() will adjust paramFormat to the legacy format,\nwhich will be passed to the IPA module, preserving backward\ncompatibility.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ef38d86dc4b4..710d957394c3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -794,7 +794,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t}\n \n \tV4L2DeviceFormat paramFormat;\n-\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n+\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n \tret = param_->setFormat(¶mFormat);\n \tif (ret)\n \t\treturn ret;\n", "prefixes": [ "v4", "6/9" ] }