Patch Detail
Show a patch.
GET /api/1.1/patches/21034/?format=api
{ "id": 21034, "url": "https://patchwork.libcamera.org/api/1.1/patches/21034/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21034/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240827014044.24673-3-laurent.pinchart@ideasonboard.com>", "date": "2024-08-27T01:40:36", "name": "[v4,2/9] ipa: rkisp1: Pass parameters buffer format to IPA module", "commit_ref": "db1571169285ce7eac3f5b7e2d823d5d710d12ee", "pull_url": null, "state": "accepted", "archived": false, "hash": "5dae63a597ccc37c41b42e516e27b2c0912dce79", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21034/mbox/", "series": [ { "id": 4544, "url": "https://patchwork.libcamera.org/api/1.1/series/4544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4544", "date": "2024-08-27T01:40:34", "name": "rkisp1: Support BLS on i.MX8MP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21034/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21034/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4CC3C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Aug 2024 01:40:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24B9663437;\n\tTue, 27 Aug 2024 03:40:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6AB861E4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Aug 2024 03:40:51 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFB36B0B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Aug 2024 03:39:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gq3bX9lv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724722784;\n\tbh=G1ImeoAXS7tCv/Y+eHyq5itrkxDjj92MPKWzt4tOtAQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gq3bX9lvePi8w+OiZBAuWnKGyMlEslv3hxm/UrHtfeIVpc/+oandRIGwWn2ksAlPb\n\tqfnUBgtNgG/B0pvcmPSTaclwt5i8TNfDLz3nMe6p4BI7MTeKwMLwjDQo8flEFQc36g\n\tlFahqPGA1FjNZfKVZ4r3q6SXCm7FK7Dx/VJcomqM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v4 2/9] ipa: rkisp1: Pass parameters buffer format to IPA\n\tmodule", "Date": "Tue, 27 Aug 2024 04:40:36 +0300", "Message-ID": "<20240827014044.24673-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "References": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The rkisp1 driver supports two formats for the ISP parameters buffer,\nthe legacy fixed format and the new extensible format. In preparation of\nsupport for the new format, pass the parameters buffer format from the\npipeline handler to the IPA module and store it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\nChanges since v3:\n\n- Store parameter format in IPASessionConfiguration\n---\n include/libcamera/ipa/rkisp1.mojom | 1 +\n src/ipa/rkisp1/ipa_context.cpp | 5 +++++\n src/ipa/rkisp1/ipa_context.h | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 2 ++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n 5 files changed, 10 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 1009e970a1b5..585d38572aa2 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -11,6 +11,7 @@ import \"include/libcamera/ipa/core.mojom\";\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n+\tuint32 paramFormat;\n };\n \n interface IPARkISP1Interface {\ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex 9f3f576afcf7..730a55b4465a 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -105,6 +105,11 @@ namespace libcamera::ipa::rkisp1 {\n * \\brief Indicates if the camera is configured to capture raw frames\n */\n \n+/**\n+ * \\var IPASessionConfiguration::paramFormat\n+ * \\brief The fourcc of the parameters buffers format\n+ */\n+\n /**\n * \\struct IPAActiveState\n * \\brief Active state for algorithms\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 061efc0c578e..24c4b2471bb4 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -59,6 +59,7 @@ struct IPASessionConfiguration {\n \t} sensor;\n \n \tbool raw;\n+\tuint32_t paramFormat;\n };\n \n struct IPAActiveState {\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 23e0826cc335..de2998ab57fe 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -226,6 +226,8 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n \tcontext_.activeState = {};\n \tcontext_.frameContexts.clear();\n \n+\tcontext_.configuration.paramFormat = ipaConfig.paramFormat;\n+\n \tconst IPACameraSensorInfo &info = ipaConfig.sensorInfo;\n \tconst ControlInfo vBlank = sensorControls_.find(V4L2_CID_VBLANK)->second;\n \tcontext_.configuration.sensor.defVBlank = vBlank.def().get<int32_t>();\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex eec5bf949bed..1cdb9a44f900 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -814,6 +814,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \tipaConfig.sensorControls = data->sensor_->controls();\n+\tipaConfig.paramFormat = paramFormat.fourcc;\n \n \tret = data->ipa_->configure(ipaConfig, streamConfig, &data->controlInfo_);\n \tif (ret) {\n", "prefixes": [ "v4", "2/9" ] }