Patch Detail
Show a patch.
GET /api/1.1/patches/21028/?format=api
{ "id": 21028, "url": "https://patchwork.libcamera.org/api/1.1/patches/21028/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21028/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240826161709.524293-10-jacopo.mondi@ideasonboard.com>", "date": "2024-08-26T16:17:08", "name": "[v3,9/9] pipeline: rkisp1: Use the extensible parameters format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d58b301a2af8365da1e587946f1c79ec6c9b24d1", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21028/mbox/", "series": [ { "id": 4541, "url": "https://patchwork.libcamera.org/api/1.1/series/4541/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4541", "date": "2024-08-26T16:16:59", "name": "rkisp1: Support BLS on i.MX8MP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4541/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21028/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21028/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36A01C32D7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Aug 2024 16:17:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1DB663433;\n\tMon, 26 Aug 2024 18:17:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D5AC6342E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 18:17:26 +0200 (CEST)", "from ideasonboard.com (mob-5-90-142-90.net.vodafone.it\n\t[5.90.142.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CBC66CA;\n\tMon, 26 Aug 2024 18:16:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RTFA5Zlf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724688979;\n\tbh=mYNN89ou63Kt+Sc/Q6IL6E+laIzr8XRb/n55wmXSID4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RTFA5Zlf/SDtzm8C4Zal+4uYElDqZ1RmBoJyXNkgpWq9EWQ6Gdhg1ZJ+QUhDJvm0o\n\tPNUxbfbdTzxBOjZsyelPdurJ0j5cjN3RAQZn24GHW+kNMOCG8FhIdJPj9QVxv2UOMl\n\tp0XmxViaRMCxq7feHGpdlI2To49Ayup9c7hcDEC0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 9/9] pipeline: rkisp1: Use the extensible parameters\n\tformat", "Date": "Mon, 26 Aug 2024 18:17:08 +0200", "Message-ID": "<20240826161709.524293-10-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "References": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the IPA module supports the extensible parameters format,\nswitch to it when available. If the kernel driver doesn't support the\nnew format, setFormat() will adjust paramFormat to the legacy format,\nwhich will be passed to the IPA module, preserving backward\ncompatibility.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ef38d86dc4b4..710d957394c3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -794,7 +794,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t}\n \n \tV4L2DeviceFormat paramFormat;\n-\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n+\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n \tret = param_->setFormat(¶mFormat);\n \tif (ret)\n \t\treturn ret;\n", "prefixes": [ "v3", "9/9" ] }