Patch Detail
Show a patch.
GET /api/1.1/patches/21022/?format=api
{ "id": 21022, "url": "https://patchwork.libcamera.org/api/1.1/patches/21022/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21022/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240826161709.524293-4-jacopo.mondi@ideasonboard.com>", "date": "2024-08-26T16:17:02", "name": "[v3,3/9] ipa: rkisp1: Pass parameters buffer format to IPA module", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "114598703d4f885e6d7e798ea57e061d2046348d", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21022/mbox/", "series": [ { "id": 4541, "url": "https://patchwork.libcamera.org/api/1.1/series/4541/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4541", "date": "2024-08-26T16:16:59", "name": "rkisp1: Support BLS on i.MX8MP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4541/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21022/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21022/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8229BC32C2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Aug 2024 16:17:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B79956343D;\n\tMon, 26 Aug 2024 18:17:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 017246190C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 18:17:19 +0200 (CEST)", "from ideasonboard.com (mob-5-90-142-90.net.vodafone.it\n\t[5.90.142.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ABF76CA;\n\tMon, 26 Aug 2024 18:16:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AqwX1j9P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724688973;\n\tbh=2o1C5PI3SHYxGepQDwn/7fap4ddUKy6obyHnoFG4+fs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AqwX1j9Pjhg6KZAuxa3ay7UOeLM8PlT5MGcQs+sqYDcbGvQ0E6m7eE+LOQosJEFWS\n\tJvPedQK+virPXR/pYD0qKw4PUHNmvXMhpId9ovYSE7+8gz1hH8cv3DffuPcpgG1c2q\n\tIYp3D/9KYsvK5XZa37yOUIpvDaCyQSD0jWax8KNE=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 3/9] ipa: rkisp1: Pass parameters buffer format to IPA\n\tmodule", "Date": "Mon, 26 Aug 2024 18:17:02 +0200", "Message-ID": "<20240826161709.524293-4-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "References": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThe rkisp1 driver supports two formats for the ISP parameters buffer,\nthe legacy fixed format and the new extensible format. In preparation of\nsupport for the new format, pass the parameters buffer format from the\npipeline handler to the IPA module and store it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/ipa/rkisp1.mojom | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 2 ++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n 3 files changed, 4 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 1009e970a1b5..585d38572aa2 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -11,6 +11,7 @@ import \"include/libcamera/ipa/core.mojom\";\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n+\tuint32 paramFormat;\n };\n \n interface IPARkISP1Interface {\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 23e0826cc335..71698bc47391 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -79,6 +79,7 @@ private:\n \tstd::map<unsigned int, MappedFrameBuffer> mappedBuffers_;\n \n \tControlInfoMap sensorControls_;\n+\tuint32_t paramFormat_;\n \n \t/* Local parameter storage */\n \tstruct IPAContext context_;\n@@ -208,6 +209,7 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n \t\t\t ControlInfoMap *ipaControls)\n {\n \tsensorControls_ = ipaConfig.sensorControls;\n+\tparamFormat_ = ipaConfig.paramFormat;\n \n \tconst auto itExp = sensorControls_.find(V4L2_CID_EXPOSURE);\n \tint32_t minExposure = itExp->second.min().get<int32_t>();\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex eec5bf949bed..1cdb9a44f900 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -814,6 +814,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\treturn ret;\n \n \tipaConfig.sensorControls = data->sensor_->controls();\n+\tipaConfig.paramFormat = paramFormat.fourcc;\n \n \tret = data->ipa_->configure(ipaConfig, streamConfig, &data->controlInfo_);\n \tif (ret) {\n", "prefixes": [ "v3", "3/9" ] }