Patch Detail
Show a patch.
GET /api/1.1/patches/21017/?format=api
{ "id": 21017, "url": "https://patchwork.libcamera.org/api/1.1/patches/21017/?format=api", "web_url": "https://patchwork.libcamera.org/patch/21017/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240826152224.362773-8-stefan.klug@ideasonboard.com>", "date": "2024-08-26T15:22:05", "name": "[v1,7/8] ipa: rkisp1: Add sensor info to context", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "674a2dccee19bb67124d55365a7f97cc6e46c4b4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/21017/mbox/", "series": [ { "id": 4540, "url": "https://patchwork.libcamera.org/api/1.1/series/4540/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4540", "date": "2024-08-26T15:21:58", "name": "Implement polynomial lsc loader", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4540/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/21017/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/21017/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7421AC32D5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Aug 2024 15:22:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 076176341F;\n\tMon, 26 Aug 2024 17:22:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9BB663421\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 17:22:48 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:58b7:f3d:c9d4:defa])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74181480;\n\tMon, 26 Aug 2024 17:21:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kkhgAput\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724685702;\n\tbh=pGM8kPhrhD0ndwxqtoZupK9hT5l70hRKV3008QELl2g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kkhgAputIdVrG/gRxBr+dGVdXJAbDDA/1p80n+/y3CPzAxL/y8xDr71gK2qw0Z+fU\n\t5xsfNaTRgQR+tvqtw1UyFVmTtk82kXT/Gp7A7X/XKT7eaKUUyiLa3GXQVJjkNcFrk9\n\tj7UYn0pxwqbOUfSKAJhyfXDXvroUdfF17BoTThZc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 7/8] ipa: rkisp1: Add sensor info to context", "Date": "Mon, 26 Aug 2024 17:22:05 +0200", "Message-ID": "<20240826152224.362773-8-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240826152224.362773-1-stefan.klug@ideasonboard.com>", "References": "<20240826152224.362773-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For the LSC algorithm to dynamically calculate the LSC tables based on\nthe sensor size and the crop rectangle it needs access to that data.\nProvide access to it by adding the sensorInfo object to the context.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/ipa_context.h | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 4 +++-\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 061efc0c578e..18c294798524 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -17,6 +17,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n #include <libcamera/geometry.h>\n+#include <libcamera/ipa/core_ipa_interface.h>\n \n #include <libipa/camera_sensor_helper.h>\n #include <libipa/fc_queue.h>\n@@ -178,6 +179,7 @@ struct IPAFrameContext : public FrameContext {\n \n struct IPAContext {\n \tconst IPAHwSettings *hw;\n+\tIPACameraSensorInfo sensorInfo;\n \tIPASessionConfiguration configuration;\n \tIPAActiveState activeState;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 23e0826cc335..c671629956c7 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -111,7 +111,7 @@ const ControlInfoMap::Map rkisp1Controls{\n } /* namespace */\n \n IPARkISP1::IPARkISP1()\n-\t: context_({ {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n+\t: context_({ {}, {}, {}, {}, { kMaxFrameContexts }, {}, {} })\n {\n }\n \n@@ -143,6 +143,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n \n+\tcontext_.sensorInfo = sensorInfo;\n+\n \tcontext_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!context_.camHelper) {\n \t\tLOG(IPARkISP1, Error)\n", "prefixes": [ "v1", "7/8" ] }