Patch Detail
Show a patch.
GET /api/1.1/patches/20991/?format=api
{ "id": 20991, "url": "https://patchwork.libcamera.org/api/1.1/patches/20991/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20991/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240822153527.25320-3-laurent.pinchart+renesas@ideasonboard.com>", "date": "2024-08-22T15:35:22", "name": "[v2,2/7] media: sun4i_csi: Implement link validate for sun4i_csi subdev", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "7fded6812403679eeb9ef43e3441224436dad3ed", "submitter": { "id": 204, "url": "https://patchwork.libcamera.org/api/1.1/people/204/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart+renesas@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20991/mbox/", "series": [ { "id": 4533, "url": "https://patchwork.libcamera.org/api/1.1/series/4533/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4533", "date": "2024-08-22T15:35:20", "name": "media: v4l2: Improve media link validation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4533/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20991/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20991/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19348C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Aug 2024 15:35:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9377A633D1;\n\tThu, 22 Aug 2024 17:35:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C993633D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Aug 2024 17:35:33 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E79FBB2A;\n\tThu, 22 Aug 2024 17:34:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CMu3/vJC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724340870;\n\tbh=g4UzTpjAkmH1/8Mi3biEb/L7TovlNwHywY7DzG7f2wA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CMu3/vJCap9NxISUHX76T7sb86mhw9cppcfHGK4Kfq3oCcT0Fs5ZKqxmg+xNrlYNp\n\t7h3kpp95yRA6UbDdsKkLakgRMU+jp7xtXuHZ787PFTq3nACMjIznAWabsQRJxwYntl\n\t5WrufxQtDSIySkDEmv1+0/1x6XCbe3fA938Z75N4=", "From": "Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Chen-Yu Tsai <wens@csie.org>, Eugen Hristev <eugen.hristev@collabora.com>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMaxime Ripard <mripard@kernel.org>, Sakari Ailus <sakari.ailus@iki.fi>,\n\tTomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n\tlinux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,\n\tstable@vger.kernel.org", "Subject": "[PATCH v2 2/7] media: sun4i_csi: Implement link validate for\n\tsun4i_csi subdev", "Date": "Thu, 22 Aug 2024 18:35:22 +0300", "Message-ID": "<20240822153527.25320-3-laurent.pinchart+renesas@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240822153527.25320-1-laurent.pinchart+renesas@ideasonboard.com>", "References": "<20240822153527.25320-1-laurent.pinchart+renesas@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The sun4i_csi driver doesn't implement link validation for the subdev it\nregisters, leaving the link between the subdev and its source\nunvalidated. Fix it, using the v4l2_subdev_link_validate() helper.\n\nFixes: 577bbf23b758 (\"media: sunxi: Add A10 CSI driver\")\nCc: stable@vger.kernel.org\nSigned-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>\nAcked-by: Chen-Yu Tsai <wens@csie.org>\n---\n drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c\nindex 097a3a08ef7d..dbb26c7b2f8d 100644\n--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c\n+++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c\n@@ -39,6 +39,10 @@ static const struct media_entity_operations sun4i_csi_video_entity_ops = {\n \t.link_validate = v4l2_subdev_link_validate,\n };\n \n+static const struct media_entity_operations sun4i_csi_subdev_entity_ops = {\n+\t.link_validate = v4l2_subdev_link_validate,\n+};\n+\n static int sun4i_csi_notify_bound(struct v4l2_async_notifier *notifier,\n \t\t\t\t struct v4l2_subdev *subdev,\n \t\t\t\t struct v4l2_async_connection *asd)\n@@ -214,6 +218,7 @@ static int sun4i_csi_probe(struct platform_device *pdev)\n \tsubdev->internal_ops = &sun4i_csi_subdev_internal_ops;\n \tsubdev->flags = V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;\n \tsubdev->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;\n+\tsubdev->entity.ops = &sun4i_csi_subdev_entity_ops;\n \tsubdev->owner = THIS_MODULE;\n \tsnprintf(subdev->name, sizeof(subdev->name), \"sun4i-csi-0\");\n \tv4l2_set_subdevdata(subdev, csi);\n", "prefixes": [ "v2", "2/7" ] }