Patch Detail
Show a patch.
GET /api/1.1/patches/20990/?format=api
{ "id": 20990, "url": "https://patchwork.libcamera.org/api/1.1/patches/20990/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20990/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240822153527.25320-2-laurent.pinchart+renesas@ideasonboard.com>", "date": "2024-08-22T15:35:21", "name": "[v2,1/7] media: microchip-isc: Drop v4l2_subdev_link_validate() for video devices", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "5638369025b6fabd1f4b3a72f7491e811c97776b", "submitter": { "id": 204, "url": "https://patchwork.libcamera.org/api/1.1/people/204/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart+renesas@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20990/mbox/", "series": [ { "id": 4533, "url": "https://patchwork.libcamera.org/api/1.1/series/4533/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4533", "date": "2024-08-22T15:35:20", "name": "media: v4l2: Improve media link validation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4533/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20990/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20990/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96834C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Aug 2024 15:35:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C26A9633D3;\n\tThu, 22 Aug 2024 17:35:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7EDA633CB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Aug 2024 17:35:31 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D3948D0;\n\tThu, 22 Aug 2024 17:34:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ljINV/A+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724340868;\n\tbh=IauAKKLLKtIroMXis0ibbuul9unL6FHlSgiNK/zpnac=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ljINV/A+wacBAFJaqIif+y5mZY5DRl9s+ghzAWOrzcteFJiRPktPRMOCXlMtPrPZ3\n\tsOqy5QmOcJZ7jQeVsSnRXUFIE7RgyMGAG+tYOdv+INHDAaOXthNAEL1V/Of0grV+qO\n\tIDlHExE9DrcmloCdG/C6Y+z0BZbmMlv2So3Wb1HE=", "From": "Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Chen-Yu Tsai <wens@csie.org>, Eugen Hristev <eugen.hristev@collabora.com>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMaxime Ripard <mripard@kernel.org>, Sakari Ailus <sakari.ailus@iki.fi>,\n\tTomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n\tlinux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev", "Subject": "[PATCH v2 1/7] media: microchip-isc: Drop\n\tv4l2_subdev_link_validate() for video devices", "Date": "Thu, 22 Aug 2024 18:35:21 +0300", "Message-ID": "<20240822153527.25320-2-laurent.pinchart+renesas@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240822153527.25320-1-laurent.pinchart+renesas@ideasonboard.com>", "References": "<20240822153527.25320-1-laurent.pinchart+renesas@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The v4l2_subdev_link_validate() function is a helper designed to\nvalidate links whose sink is a subdev. When called on a link whose sink\nis a video device, it only prints a warning and returns. As the\nmicrochip-isc driver implements manual validate of the subdev to video\ndevice link, we can just dropp the v4l2_subdev_link_validate() to avoid\nthe warning.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>\n---\n .../platform/microchip/microchip-isc-base.c | 19 ++++---------------\n 1 file changed, 4 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c\nindex f3a5cbacadbe..28e56f6a695d 100644\n--- a/drivers/media/platform/microchip/microchip-isc-base.c\n+++ b/drivers/media/platform/microchip/microchip-isc-base.c\n@@ -902,8 +902,11 @@ static int isc_set_fmt(struct isc_device *isc, struct v4l2_format *f)\n \treturn 0;\n }\n \n-static int isc_validate(struct isc_device *isc)\n+static int isc_link_validate(struct media_link *link)\n {\n+\tstruct video_device *vdev =\n+\t\tmedia_entity_to_video_device(link->sink->entity);\n+\tstruct isc_device *isc = video_get_drvdata(vdev);\n \tint ret;\n \tint i;\n \tstruct isc_format *sd_fmt = NULL;\n@@ -1906,20 +1909,6 @@ int microchip_isc_pipeline_init(struct isc_device *isc)\n }\n EXPORT_SYMBOL_GPL(microchip_isc_pipeline_init);\n \n-static int isc_link_validate(struct media_link *link)\n-{\n-\tstruct video_device *vdev =\n-\t\tmedia_entity_to_video_device(link->sink->entity);\n-\tstruct isc_device *isc = video_get_drvdata(vdev);\n-\tint ret;\n-\n-\tret = v4l2_subdev_link_validate(link);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\treturn isc_validate(isc);\n-}\n-\n static const struct media_entity_operations isc_entity_operations = {\n \t.link_validate = isc_link_validate,\n };\n", "prefixes": [ "v2", "1/7" ] }