Patch Detail
Show a patch.
GET /api/1.1/patches/2097/?format=api
{ "id": 2097, "url": "https://patchwork.libcamera.org/api/1.1/patches/2097/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2097/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191004163734.15594-2-jacopo@jmondi.org>", "date": "2019-10-04T16:37:29", "name": "[libcamera-devel,v2,1/6] ipa: vimc: Rename ipa_dummy to ipa_vimc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b98fc412b807c012e0ca7aec123eb87acc1c7e74", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2097/mbox/", "series": [ { "id": 519, "url": "https://patchwork.libcamera.org/api/1.1/series/519/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=519", "date": "2019-10-04T16:37:28", "name": "test: Add IPA interface test support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/519/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2097/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2097/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2FDC60BC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Oct 2019 18:35:58 +0200 (CEST)", "from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 23827200009;\n\tFri, 4 Oct 2019 16:35:57 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 4 Oct 2019 18:37:29 +0200", "Message-Id": "<20191004163734.15594-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191004163734.15594-1-jacopo@jmondi.org>", "References": "<20191004163734.15594-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/6] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 04 Oct 2019 16:35:59 -0000" }, "content": "The DummyIPA is actually a test IPA module for the virtual media\ncontroller driver VIMC. Rename it accordingly to its usage.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} | 10 +++++-----\n src/ipa/meson.build | 10 +++++-----\n test/ipa/ipa_test.cpp | 2 +-\n 3 files changed, 11 insertions(+), 11 deletions(-)\n rename src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} (71%)", "diff": "diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_vimc.cpp\nsimilarity index 71%\nrename from src/ipa/ipa_dummy.cpp\nrename to src/ipa/ipa_vimc.cpp\nindex 9d0cbdc8b1ad..abc06e7f5fd5 100644\n--- a/src/ipa/ipa_dummy.cpp\n+++ b/src/ipa/ipa_vimc.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n+ * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n */\n \n #include <iostream>\n@@ -12,15 +12,15 @@\n \n namespace libcamera {\n \n-class IPADummy : public IPAInterface\n+class IPAVimc : public IPAInterface\n {\n public:\n \tint init();\n };\n \n-int IPADummy::init()\n+int IPAVimc::init()\n {\n-\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n+\tstd::cout << \"initializing vimc IPA!\" << std::endl;\n \treturn 0;\n }\n \n@@ -39,7 +39,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \n IPAInterface *ipaCreate()\n {\n-\treturn new IPADummy();\n+\treturn new IPAVimc();\n }\n };\n \ndiff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex f09915bc1388..b5bcd7b2c3db 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -1,12 +1,12 @@\n-ipa_dummy_sources = [\n- ['ipa_dummy', 'LGPL-2.1-or-later'],\n- ['ipa_dummy_isolate', 'Proprietary'],\n+ipa_vimc_sources = [\n+ ['ipa_vimc', 'LGPL-2.1-or-later'],\n+ ['ipa_vimc_isolate', 'Proprietary'],\n ]\n \n ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n \n-foreach t : ipa_dummy_sources\n- ipa = shared_module(t[0], 'ipa_dummy.cpp',\n+foreach t : ipa_vimc_sources\n+ ipa = shared_module(t[0], 'ipa_vimc.cpp',\n name_prefix : '',\n include_directories : libcamera_includes,\n install : true,\ndiff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\nindex b9e1bd61c299..8f9b2d8058ec 100644\n--- a/test/ipa/ipa_test.cpp\n+++ b/test/ipa/ipa_test.cpp\n@@ -62,7 +62,7 @@ protected:\n \t\t\t\"GPL-2.0-or-later\",\n \t\t};\n \n-\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n+\t\tcount += runTest(\"src/ipa/ipa_vimc.so\", testInfo);\n \n \t\tif (count < 0)\n \t\t\treturn TestFail;\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }