Patch Detail
Show a patch.
GET /api/1.1/patches/20924/?format=api
{ "id": 20924, "url": "https://patchwork.libcamera.org/api/1.1/patches/20924/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20924/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240815081622.174210-12-mzamazal@redhat.com>", "date": "2024-08-15T08:16:15", "name": "[v4,11/18] libcamera: software_isp: Call Algorithm::prepare", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "135e8cfe6eec24c9d9f9369f8cefffc819cdd834", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20924/mbox/", "series": [ { "id": 4520, "url": "https://patchwork.libcamera.org/api/1.1/series/4520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4520", "date": "2024-08-15T08:16:04", "name": "Software ISP refactoring", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20924/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20924/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 107B7C32D6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Aug 2024 08:17:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60809633C2;\n\tThu, 15 Aug 2024 10:17:23 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAD55633C1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Aug 2024 10:17:19 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-224-LZn_eucvNmuwLM4kxBc0IQ-1;\n\tThu, 15 Aug 2024 04:17:16 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 565E91955F3F; Thu, 15 Aug 2024 08:17:15 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.128])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 2835219560A3; Thu, 15 Aug 2024 08:17:12 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hN41r7QZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723709839;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LzExjFmOMWaQshd+wHdnRR6XuJZ3FZ5MPMv6UWL7yfs=;\n\tb=hN41r7QZuyYAhKn5VLBsUPo5hcGgzqrgnLEyGWIVHdAYW2Vk1ckXMfmpU1hprwyFLPYL8z\n\tEPyEAQ1ikC3iNVSkaIy3r7ChHMXKf67ibbsKt1dP/UOFSXoCum1uGQSSRm4KwM+eSi9wEH\n\tRvRhdpMGnMVsYbt13tJpoLxF1om+U4s=", "X-MC-Unique": "LZn_eucvNmuwLM4kxBc0IQ-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v4 11/18] libcamera: software_isp: Call Algorithm::prepare", "Date": "Thu, 15 Aug 2024 10:16:15 +0200", "Message-ID": "<20240815081622.174210-12-mzamazal@redhat.com>", "In-Reply-To": "<20240815081622.174210-1-mzamazal@redhat.com>", "References": "<20240815081622.174210-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds Algorithm::prepare call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n include/libcamera/ipa/soft.mojom | 1 +\n src/ipa/simple/soft_simple.cpp | 8 ++++++++\n src/libcamera/software_isp/software_isp.cpp | 1 +\n 3 files changed, 10 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 0ca2869c..bc70d4e4 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -24,6 +24,7 @@ interface IPASoftInterface {\n \t\t=> (int32 ret);\n \n \t[async] queueRequest(uint32 frame, libcamera.ControlList sensorControls);\n+\t[async] prepare(uint32 frame);\n \t[async] processStats(uint32 frame,\n uint32 bufferId,\n libcamera.ControlList sensorControls);\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex eb3bbd92..d52242be 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -79,6 +79,7 @@ public:\n \tvoid stop() override;\n \n \tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n+\tvoid prepare(const uint32_t frame) override;\n \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n \t\t\t const ControlList &sensorControls) override;\n \n@@ -279,6 +280,13 @@ void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &contro\n \t\talgo->queueRequest(context_, frame, frameContext, controls);\n }\n \n+void IPASoftSimple::prepare(const uint32_t frame)\n+{\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->prepare(context_, frame, frameContext, params_);\n+}\n+\n void IPASoftSimple::processStats([[maybe_unused]] const uint32_t frame,\n \t\t\t\t [[maybe_unused]] const uint32_t bufferId,\n \t\t\t\t const ControlList &sensorControls)\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex eda18947..dbf27f31 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -352,6 +352,7 @@ void SoftwareIsp::stop()\n */\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n+\tipa_->prepare(frame);\n \tdebayer_->invokeMethod(&DebayerCpu::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n", "prefixes": [ "v4", "11/18" ] }