Patch Detail
Show a patch.
GET /api/1.1/patches/20921/?format=api
{ "id": 20921, "url": "https://patchwork.libcamera.org/api/1.1/patches/20921/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20921/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240815081622.174210-9-mzamazal@redhat.com>", "date": "2024-08-15T08:16:12", "name": "[v4,08/18] libcamera: software_isp: Create algorithms", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fe91538189980a8bddaf0ef98f5a8266d0d598f3", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20921/mbox/", "series": [ { "id": 4520, "url": "https://patchwork.libcamera.org/api/1.1/series/4520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4520", "date": "2024-08-15T08:16:04", "name": "Software ISP refactoring", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20921/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20921/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6504DC32A9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Aug 2024 08:17:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3AE2633C8;\n\tThu, 15 Aug 2024 10:17:16 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 700D8633C1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Aug 2024 10:17:14 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-52-NPU6JGNTOWa22maZPMOPng-1;\n\tThu, 15 Aug 2024 04:17:08 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5C14F1955F06; Thu, 15 Aug 2024 08:17:07 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.128])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1322B19560A3; Thu, 15 Aug 2024 08:17:04 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Cobbd8x4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723709833;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=4OojRvR7hV5VSh6rZzOTFwKTXnvVsUvy9KHsSwPlpII=;\n\tb=Cobbd8x4PscBpfKKuITrskLmlXlrdujg/xHjmGn8f4e/kx/vR+j2ejBN+/MMH+57C7gX5+\n\tR9UQmr7b7S6hifHxnp7CrvmhN67QGZ7O4tZrjSztnxJazyIaVlT9z7e3GMELcs8WyJFnzV\n\tW9zpSKvqBpRE7OWsI3ctVZEdb27Ccio=", "X-MC-Unique": "NPU6JGNTOWa22maZPMOPng-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v4 08/18] libcamera: software_isp: Create algorithms", "Date": "Thu, 15 Aug 2024 10:16:12 +0200", "Message-ID": "<20240815081622.174210-9-mzamazal@redhat.com>", "In-Reply-To": "<20240815081622.174210-1-mzamazal@redhat.com>", "References": "<20240815081622.174210-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We are ready to introduce algorithms now. First, let's create\nalgorithms. The algorithms are not called yet, calls to them will be\nadded in followup patches.\n\nThe maximum number of contexts is set to the same value as in hardware\npipelines.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/algorithms/meson.build | 4 ++++\n src/ipa/simple/data/uncalibrated.yaml | 1 +\n src/ipa/simple/meson.build | 7 +++++--\n src/ipa/simple/soft_simple.cpp | 14 ++++++++++++++\n 4 files changed, 24 insertions(+), 2 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/meson.build", "diff": "diff --git a/src/ipa/simple/algorithms/meson.build b/src/ipa/simple/algorithms/meson.build\nnew file mode 100644\nindex 00000000..31d26e43\n--- /dev/null\n+++ b/src/ipa/simple/algorithms/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+soft_simple_ipa_algorithms = files([\n+])\ndiff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\nindex ff981a1a..2cdc39a8 100644\n--- a/src/ipa/simple/data/uncalibrated.yaml\n+++ b/src/ipa/simple/data/uncalibrated.yaml\n@@ -2,4 +2,5 @@\n %YAML 1.1\n ---\n version: 1\n+algorithms:\n ...\ndiff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\nindex 7757f99b..dcd7c70a 100644\n--- a/src/ipa/simple/meson.build\n+++ b/src/ipa/simple/meson.build\n@@ -1,5 +1,8 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+subdir('algorithms')\n+subdir('data')\n+\n ipa_name = 'ipa_soft_simple'\n \n soft_simple_sources = files([\n@@ -8,6 +11,8 @@ soft_simple_sources = files([\n 'black_level.cpp',\n ])\n \n+soft_simple_sources += soft_simple_ipa_algorithms\n+\n mod = shared_module(ipa_name, soft_simple_sources,\n name_prefix : '',\n include_directories : [ipa_includes],\n@@ -24,6 +29,4 @@ if ipa_sign_module\n build_by_default : true)\n endif\n \n-subdir('data')\n-\n ipa_names += ipa_name\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 12b5245e..79ed4891 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -54,12 +54,15 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n * enough to prevent the exposure from wobbling around the optimal value.\n */\n static constexpr float kExposureSatisfactory = 0.2;\n+/* Maximum number of frame contexts to be held */\n+static constexpr uint32_t kMaxFrameContexts = 16;\n \n class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n \t\t: params_(nullptr), stats_(nullptr), blackLevel_(BlackLevel()),\n+\t\t context_({ {}, {}, { kMaxFrameContexts } }),\n \t\t ignoreUpdates_(0)\n \t{\n \t}\n@@ -93,6 +96,8 @@ private:\n \tstatic constexpr unsigned int kGammaLookupSize = 1024;\n \tstd::array<uint8_t, kGammaLookupSize> gammaTable_;\n \tint lastBlackLevel_ = -1;\n+\t/* Local parameter storage */\n+\tstruct IPAContext context_;\n \n \tint32_t exposureMin_, exposureMax_;\n \tint32_t exposure_;\n@@ -139,6 +144,15 @@ int IPASoftSimple::init(const IPASettings &settings,\n \tunsigned int version = (*data)[\"version\"].get<uint32_t>(0);\n \tLOG(IPASoft, Debug) << \"Tuning file version \" << version;\n \n+\tif (!data->contains(\"algorithms\")) {\n+\t\tLOG(IPASoft, Error) << \"Tuning file doesn't contain algorithms\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tint ret = createAlgorithms(context_, (*data)[\"algorithms\"]);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tparams_ = nullptr;\n \tstats_ = nullptr;\n \n", "prefixes": [ "v4", "08/18" ] }