Patch Detail
Show a patch.
GET /api/1.1/patches/20917/?format=api
{ "id": 20917, "url": "https://patchwork.libcamera.org/api/1.1/patches/20917/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20917/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240815081622.174210-5-mzamazal@redhat.com>", "date": "2024-08-15T08:16:08", "name": "[v4,04/18] libcamera: software_isp: Let IPASoftSimple inherit Module", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1f94dd095867e0d340f4969251ad580576b6443f", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20917/mbox/", "series": [ { "id": 4520, "url": "https://patchwork.libcamera.org/api/1.1/series/4520/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4520", "date": "2024-08-15T08:16:04", "name": "Software ISP refactoring", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4520/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20917/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20917/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12344C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Aug 2024 08:17:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87ED2633BF;\n\tThu, 15 Aug 2024 10:17:04 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AC6A633BA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 Aug 2024 10:17:02 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-677-U6DqzKpyN-WGZPCn2xbj4Q-1;\n\tThu, 15 Aug 2024 04:16:57 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 6A2211956064; Thu, 15 Aug 2024 08:16:56 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.128])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 0C73E19560A3; Thu, 15 Aug 2024 08:16:53 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"M9dETOSm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723709821;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=MX9NCOwcE1ykHIPz/zU/TVZmkBNqq1TkDXFuf3lnGdo=;\n\tb=M9dETOSm25Ez8Q+8w9dmjRS7Dghp6Nt3IB1nTd3RfWfPAgNrKmAYmi3jUprv4y9K8Fk6a3\n\tSO6ZjttzGeHCZvs4uX4wswvwqANXveIxt0VJa5ntptEwDwvEGVr+r1zvOAw/rmNP/4j7pe\n\towetEp5t00wnDc/72O6OWf9U4j0mYOw=", "X-MC-Unique": "U6DqzKpyN-WGZPCn2xbj4Q-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v4 04/18] libcamera: software_isp: Let IPASoftSimple inherit\n\tModule", "Date": "Thu, 15 Aug 2024 10:16:08 +0200", "Message-ID": "<20240815081622.174210-5-mzamazal@redhat.com>", "In-Reply-To": "<20240815081622.174210-1-mzamazal@redhat.com>", "References": "<20240815081622.174210-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Module class is a base class for all IPA modules.\nIn addition, implement logPrefix() of the module for the softIPA.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b7746ce0..72321f44 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -30,6 +30,7 @@\n #include \"libipa/camera_sensor_helper.h\"\n \n #include \"black_level.h\"\n+#include \"module.h\"\n \n namespace libcamera {\n LOG_DEFINE_CATEGORY(IPASoft)\n@@ -54,7 +55,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n */\n static constexpr float kExposureSatisfactory = 0.2;\n \n-class IPASoftSimple : public ipa::soft::IPASoftInterface\n+class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n@@ -76,6 +77,9 @@ public:\n \n \tvoid processStats(const ControlList &sensorControls) override;\n \n+protected:\n+\tstd::string logPrefix() const override;\n+\n private:\n \tvoid updateExposure(double exposureMSV);\n \n@@ -421,6 +425,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)\n \tagain_ = std::clamp(again_, againMin_, againMax_);\n }\n \n+std::string IPASoftSimple::logPrefix() const\n+{\n+\treturn \"IPASoft\";\n+}\n+\n } /* namespace ipa::soft */\n \n /*\n", "prefixes": [ "v4", "04/18" ] }