Patch Detail
Show a patch.
GET /api/1.1/patches/20884/?format=api
{ "id": 20884, "url": "https://patchwork.libcamera.org/api/1.1/patches/20884/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20884/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240812115009.946036-11-mzamazal@redhat.com>", "date": "2024-08-12T11:49:59", "name": "[10/16] libcamera: software_isp: Remove per-frame params buffers TODO item", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a65233af8439b6abed215670c749403eef748d9c", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20884/mbox/", "series": [ { "id": 4511, "url": "https://patchwork.libcamera.org/api/1.1/series/4511/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4511", "date": "2024-08-12T11:49:49", "name": "Software ISP: Share params and stats buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4511/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20884/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20884/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C43E9C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Aug 2024 11:50:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55F0A633C9;\n\tMon, 12 Aug 2024 13:50:46 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60987633C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Aug 2024 13:50:38 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-626-k1XUCoR8NMGJfZcBtsFKrg-1;\n\tMon, 12 Aug 2024 07:50:35 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 1B7851955F3B for <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Aug 2024 11:50:35 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.57])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E2C2A19772C4; Mon, 12 Aug 2024 11:50:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Few57IY7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723463437;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=6fhFLPfLnFUhbehU4Z4FuXIeVjmixZwW2IeYtY9/7PA=;\n\tb=Few57IY7KsiAGznVMFUEESWBhPrE9wJTzSTn/lAIzsnnzgEmwRUIj4/3EJoQZk5Rah2Gzf\n\tlmQ8OH9WTLQaCkGxfGo/fdamRhpYUwCrfd3ocgRuQowTaNL3jWmLBVeIHT6HFCGgfkZlVi\n\tPGhE1OkW34Tw25zyOJteHKCFK77zw9w=", "X-MC-Unique": "k1XUCoR8NMGJfZcBtsFKrg-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 10/16] libcamera: software_isp: Remove per-frame params\n\tbuffers TODO item", "Date": "Mon, 12 Aug 2024 13:49:59 +0200", "Message-ID": "<20240812115009.946036-11-mzamazal@redhat.com>", "In-Reply-To": "<20240812115009.946036-1-mzamazal@redhat.com>", "References": "<20240812115009.946036-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Parameters are stored in per-frame buffers and shared properly now.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/software_isp/TODO | 18 ------------------\n 1 file changed, 18 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\nindex a50db668..db1115dd 100644\n--- a/src/libcamera/software_isp/TODO\n+++ b/src/libcamera/software_isp/TODO\n@@ -53,24 +53,6 @@ stats in hardware, such as the i.MX7), but please keep it on your radar.\n \n ---\n \n-5. Store ISP parameters in per-frame buffers\n-\n-> /**\n-> * \\fn void Debayer::process(FrameBuffer *input, FrameBuffer *output, DebayerParams params)\n-> * \\brief Process the bayer data into the requested format.\n-> * \\param[in] input The input buffer.\n-> * \\param[in] output The output buffer.\n-> * \\param[in] params The parameters to be used in debayering.\n-> *\n-> * \\note DebayerParams is passed by value deliberately so that a copy is passed\n-> * when this is run in another thread by invokeMethod().\n-> */\n-\n-Possibly something to address later, by storing ISP parameters in\n-per-frame buffers like we do for hardware ISPs.\n-\n----\n-\n 6. Input buffer copying configuration\n \n > DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats)\n", "prefixes": [ "10/16" ] }