Patch Detail
Show a patch.
GET /api/1.1/patches/20845/?format=api
{ "id": 20845, "url": "https://patchwork.libcamera.org/api/1.1/patches/20845/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20845/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>", "date": "2024-08-08T16:57:01", "name": "libcamera: libipa: camera_sensor: Add IMX283 black level", "commit_ref": "935f6ff2672a36c1e2b842bdcc23429a39ff535d", "pull_url": null, "state": "accepted", "archived": false, "hash": "2a1612b0c3e9acd211b4f02b0d873490fc99b4c2", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20845/mbox/", "series": [ { "id": 4503, "url": "https://patchwork.libcamera.org/api/1.1/series/4503/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4503", "date": "2024-08-08T16:57:01", "name": "libcamera: libipa: camera_sensor: Add IMX283 black level", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4503/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20845/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20845/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8693BC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Aug 2024 16:57:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 439796338D;\n\tThu, 8 Aug 2024 18:57:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB04A61955\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Aug 2024 18:57:05 +0200 (CEST)", "from Monstersaurus.tail69b4.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 233E3581;\n\tThu, 8 Aug 2024 18:56:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rG1Ofx6U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723136172;\n\tbh=EKojFQD5MAcAu2vAzuMnC0IBBb8hkZCjZ55B/vG20Xc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=rG1Ofx6UQsdc0vneBvRzUsJenMwUE4tz60JTVOOT4VY7DnChdnLD1esXlfenFmz2K\n\tnY32wzgZwfzM6E8Igqh3IBIrVrL2LfzxHLw8Ke+z+o5jK/CF0TlyHeEE00acVHJVbq\n\te861IzQz99jo4c6ZS/9qX1iGPLnr9C0ETcyaxYxw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level", "Date": "Thu, 8 Aug 2024 17:57:01 +0100", "Message-Id": "<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Configure the default sensor black level reported by the datasheet.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex c07b1a8dcaec..039109f9540d 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -549,6 +549,8 @@ class CameraSensorHelperImx283 : public CameraSensorHelper\n public:\n \tCameraSensorHelperImx283()\n \t{\n+\t\t/* From datasheet: 0x32 at 10bits. */\n+\t\tblackLevel_ = 3200;\n \t\tgainType_ = AnalogueGainLinear;\n \t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n \t}\n", "prefixes": [] }