Patch Detail
Show a patch.
GET /api/1.1/patches/20844/?format=api
{ "id": 20844, "url": "https://patchwork.libcamera.org/api/1.1/patches/20844/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20844/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240808140948.430419-6-dan.scally@ideasonboard.com>", "date": "2024-08-08T14:09:48", "name": "[v7,5/5] libcamera: camera: Hide Camera::create() from the public API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6c9872d3af02876273c17a966fb5e37b4a5aa52f", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20844/mbox/", "series": [ { "id": 4502, "url": "https://patchwork.libcamera.org/api/1.1/series/4502/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4502", "date": "2024-08-08T14:09:43", "name": "Split libcamera documentation in public and internal APIs", "version": 7, "mbox": "https://patchwork.libcamera.org/series/4502/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20844/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20844/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9765C32D5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Aug 2024 14:10:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8A13633BD;\n\tThu, 8 Aug 2024 16:10:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB26261955\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Aug 2024 16:10:05 +0200 (CEST)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A59A1648;\n\tThu, 8 Aug 2024 16:09:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cdXWJQDA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723126152;\n\tbh=iWC5leEoJr3surrVUwowe34p3yWYic+q7VhXfvX9DfE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cdXWJQDANcT5Hg2rYKpatj6MS0mlnpaSQgyoy2mXzq6EjIEcsJz5Bchw53b18SDeX\n\tv9ttCdH3J9o/ieWML13RNnfnzOHDX8j5ha8S0pOlE1AoY4xduJ6b1uLQu6+jsWhpxz\n\tH2/DYcWkerv+RLndwON92hWyWK50npZoKQaWCGQc=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v7 5/5] libcamera: camera: Hide Camera::create() from the\n\tpublic API", "Date": "Thu, 8 Aug 2024 15:09:48 +0100", "Message-Id": "<20240808140948.430419-6-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240808140948.430419-1-dan.scally@ideasonboard.com>", "References": "<20240808140948.430419-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThe Camera::create() function is internal. Hide it from the public API\ndocumentation.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges since v6:\n\n\tNone\n\n src/libcamera/camera.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex aca466c9..382a68f7 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -821,6 +821,7 @@ void Camera::Private::setState(State state)\n */\n \n /**\n+ * \\internal\n * \\brief Create a camera instance\n * \\param[in] d Camera private data\n * \\param[in] id The ID of the camera device\n", "prefixes": [ "v7", "5/5" ] }