Patch Detail
Show a patch.
GET /api/1.1/patches/20818/?format=api
{ "id": 20818, "url": "https://patchwork.libcamera.org/api/1.1/patches/20818/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20818/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240807121516.13608-3-laurent.pinchart@ideasonboard.com>", "date": "2024-08-07T12:15:15", "name": "[v2,2/3] utils: checkstyle.py: Validate SoB trailer against author", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "74bc70409e8ee7d8d19c6558822dd2b4c4ddacc0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20818/mbox/", "series": [ { "id": 4494, "url": "https://patchwork.libcamera.org/api/1.1/series/4494/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4494", "date": "2024-08-07T12:15:13", "name": "utils: checkstyle.py: Improve trailer validation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4494/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20818/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20818/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49060BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Aug 2024 12:15:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84FC9633AC;\n\tWed, 7 Aug 2024 14:15:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91C6463382\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Aug 2024 14:15:42 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A928C2EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Aug 2024 14:14:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i3NMd4+O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723032889;\n\tbh=e4NiVPk/ydUmg51/rtVAR8NFaiyyxvy5h6QbQWAr5uc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=i3NMd4+OUy5qjNyERQ0nD91IWJTu8JWvhwy8/kZZq6aNLfdZLVQkcDN0gd0pXAYlB\n\tP2/qNvLxuYnNBzwQNmMTV8Evd4JCNSgmhav6MKU942QOJBHT4aVHdQ0RmdcGbb+vc7\n\tjMJ5prnZIsJdwWqONjBmv3C4UXJNb79jotT2WeLw=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 2/3] utils: checkstyle.py: Validate SoB trailer against\n\tauthor", "Date": "Wed, 7 Aug 2024 15:15:15 +0300", "Message-ID": "<20240807121516.13608-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240807121516.13608-1-laurent.pinchart@ideasonboard.com>", "References": "<20240807121516.13608-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The TrailersChecker enforces the presence of a Signed-off-by tag in the\ntrailer, but doesn't verify that the tag matches the commit's author.\nAdd that verification, as required by the libcamera contribution\nprocess.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n utils/checkstyle.py | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex e8451846c0c2..560a2c1e8c58 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -525,10 +525,11 @@ class TrailersChecker(CommitChecker):\n continue\n \n if key == 'Signed-off-by':\n- sob_found = True\n+ if value == commit.author:\n+ sob_found = True\n \n if not sob_found:\n- issues.append(CommitIssue(f\"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst\"))\n+ issues.append(CommitIssue(f\"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst\"))\n \n return issues\n \n", "prefixes": [ "v2", "2/3" ] }