Patch Detail
Show a patch.
GET /api/1.1/patches/20796/?format=api
{ "id": 20796, "url": "https://patchwork.libcamera.org/api/1.1/patches/20796/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20796/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>", "date": "2024-08-05T14:36:46", "name": "[v5,10/18] libcamera: Consolidate all IPA headers in libcamera_ipa_headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1da2e3030a2a25a79550215364bf56609adec3f9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20796/mbox/", "series": [ { "id": 4488, "url": "https://patchwork.libcamera.org/api/1.1/series/4488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4488", "date": "2024-08-05T14:36:36", "name": "Split libcamera documentation in public and internal APIs", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20796/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20796/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72E1EC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Aug 2024 14:37:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39491633C8;\n\tMon, 5 Aug 2024 16:37:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84C1963398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:37:31 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0095E581\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:36:39 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VtMqXAgR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722868600;\n\tbh=KBwFDhHay3XV7bBWXBYUAofmofOWYOxmP+CKgFMsMVU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=VtMqXAgRInbP1zZBPJKhntYIMs5ouR2hPBO0DYaC8Zai9wQFHTmsMI5av5UCNrj7n\n\tKJeNJK35DH4ZATA2YwjavzAIfR/t5Yo78/XMsh/s9zncrjn4kyUc1HjiYF6h3HpIos\n\tLoKxheEostUaBEaVD9yNy5cFNMi+j8oJJAkw99yM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v5 10/18] libcamera: Consolidate all IPA headers in\n\tlibcamera_ipa_headers", "Date": "Mon, 5 Aug 2024 17:36:46 +0300", "Message-ID": "<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "References": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPA headers are listed in two different meson variables, one for\ngenerated headers, and one for the other headers. There's no real reason\nfor this split, consolidate all of them in the libcamera_ipa_headers\nvariable.\n\nWhile at it, don't add the IPA headers to the libcamera_internal_sources\nvariable, but list libcamera_ipa_headers in the sources for the shared\nlibrary. This moves the libcamera_internal_sources variable towards\nholding source files, not header files, to improve clarity of the build\nsystem.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/ipa/meson.build | 8 +++-----\n src/libcamera/meson.build | 3 +--\n 2 files changed, 4 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\nindex 3352d08fbd98..96fca42cc0b8 100644\n--- a/include/libcamera/ipa/meson.build\n+++ b/include/libcamera/ipa/meson.build\n@@ -11,8 +11,6 @@ libcamera_ipa_headers = files([\n install_headers(libcamera_ipa_headers,\n subdir : libcamera_ipa_include_dir)\n \n-libcamera_generated_ipa_headers = []\n-\n ipa_headers_install_dir = get_option('includedir') / libcamera_ipa_include_dir\n \n #\n@@ -31,7 +29,7 @@ ipa_mojom_core = custom_target(core_mojom_file.split('.')[0] + '_mojom_module',\n ])\n \n # core_ipa_interface.h\n-libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n+libcamera_ipa_headers += custom_target('core_ipa_interface_h',\n input : ipa_mojom_core,\n output : 'core_ipa_interface.h',\n depends : mojom_templates,\n@@ -47,7 +45,7 @@ libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n ])\n \n # core_ipa_serializer.h\n-libcamera_generated_ipa_headers += custom_target('core_ipa_serializer_h',\n+libcamera_ipa_headers += custom_target('core_ipa_serializer_h',\n input : ipa_mojom_core,\n output : 'core_ipa_serializer.h',\n depends : mojom_templates,\n@@ -152,7 +150,7 @@ foreach pipeline, file : pipeline_ipa_mojom_mapping\n 'mojom': mojom,\n }\n \n- libcamera_generated_ipa_headers += [header, serializer, proxy_header]\n+ libcamera_ipa_headers += [header, serializer, proxy_header]\n endforeach\n \n ipa_mojom_files = []\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 61a97c738ae8..86e8b88cc1b2 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n ])\n \n libcamera_public_sources += libcamera_public_headers\n-libcamera_internal_sources += libcamera_generated_ipa_headers\n libcamera_internal_sources += libcamera_tracepoint_header\n \n includes = [\n@@ -196,6 +195,7 @@ libcamera_deps += [\n libcamera = shared_library('libcamera',\n [\n libcamera_public_sources,\n+ libcamera_ipa_headers,\n libcamera_internal_sources,\n ],\n version : libcamera_version,\n@@ -216,7 +216,6 @@ libcamera_public = declare_dependency(sources : [\n # Internal dependency for components and plugins which can use private APIs\n libcamera_private = declare_dependency(sources : [\n libcamera_ipa_headers,\n- libcamera_generated_ipa_headers,\n ],\n dependencies : [\n libcamera_public,\n", "prefixes": [ "v5", "10/18" ] }