Patch Detail
Show a patch.
GET /api/1.1/patches/20794/?format=api
{ "id": 20794, "url": "https://patchwork.libcamera.org/api/1.1/patches/20794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>", "date": "2024-08-05T14:36:44", "name": "[v5,08/18] libcamera: Drop libcamera_generated_ipa_headers from sources", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "23573c6d04f129a960ddb42ebe50dc5dbfabeccd", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20794/mbox/", "series": [ { "id": 4488, "url": "https://patchwork.libcamera.org/api/1.1/series/4488/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4488", "date": "2024-08-05T14:36:36", "name": "Split libcamera documentation in public and internal APIs", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4488/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B072AC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Aug 2024 14:37:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CE3363393;\n\tMon, 5 Aug 2024 16:37:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAC2D63369\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:37:28 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21276581\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 16:36:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bEJ0Mkja\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722868597;\n\tbh=ZxkKQJrNm83Jt5vpY4pVPDXLXAyfTi9eBOoIehRCAdA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=bEJ0MkjaSUVFNLb4rs1O3bR3yLBGL0MPTaJbvpfUhyKQNQyX5KUxd6xXaEIvC0fte\n\tfSqT3iYmorEQ5PSPOu2HLcy6rAnLX1yVNfMX2e2uTh1UoZymG1RDkUCyKAHXNUcxKP\n\tSH/6LllMOzCK2SgrDHX05QTt08Of3WuzEI3Wv0J4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources", "Date": "Mon, 5 Aug 2024 17:36:44 +0300", "Message-ID": "<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "References": "<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera_generated_ipa_headers variable, containing the list of\ngenerated IPA headers, is listed in the sources of IPA modules, as well\nas IPA tests. This was done to ensure that the modules and tests get\nrebuilt when the generate IPA headers change. However, the dependency is\nalready handled through the libcamera_private dependency object,\nspecified for all those modules and tests. There's no need to list the\nIPA generated headers as sources. Drop them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/meson.build | 3 +--\n src/ipa/rkisp1/meson.build | 3 +--\n src/ipa/rpi/vc4/meson.build | 3 +--\n src/ipa/simple/meson.build | 3 +--\n src/ipa/vimc/meson.build | 3 +--\n src/libcamera/proxy/worker/meson.build | 3 +--\n test/ipa/meson.build | 2 +-\n test/ipa/rkisp1/meson.build | 2 +-\n 8 files changed, 8 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\nindex e76f97c07c87..34de6213aa83 100644\n--- a/src/ipa/ipu3/meson.build\n+++ b/src/ipa/ipu3/meson.build\n@@ -12,8 +12,7 @@ ipu3_ipa_sources = files([\n \n ipu3_ipa_sources += ipu3_ipa_algorithms\n \n-mod = shared_module(ipa_name,\n- [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n+mod = shared_module(ipa_name, ipu3_ipa_sources,\n name_prefix : '',\n include_directories : [ipa_includes],\n dependencies : [libcamera_private, libipa_dep],\ndiff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\nindex e8b266f1ccca..160ef52dd52e 100644\n--- a/src/ipa/rkisp1/meson.build\n+++ b/src/ipa/rkisp1/meson.build\n@@ -13,8 +13,7 @@ rkisp1_ipa_sources = files([\n \n rkisp1_ipa_sources += rkisp1_ipa_algorithms\n \n-mod = shared_module(ipa_name,\n- [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n+mod = shared_module(ipa_name, rkisp1_ipa_sources,\n name_prefix : '',\n include_directories : [ipa_includes],\n dependencies : [libcamera_private, libipa_dep],\ndiff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\nindex 63fc5925b06c..c10fa17e1ba4 100644\n--- a/src/ipa/rpi/vc4/meson.build\n+++ b/src/ipa/rpi/vc4/meson.build\n@@ -23,8 +23,7 @@ vc4_ipa_sources = files([\n \n vc4_ipa_includes += include_directories('..')\n \n-mod = shared_module(ipa_name,\n- [vc4_ipa_sources, libcamera_generated_ipa_headers],\n+mod = shared_module(ipa_name, vc4_ipa_sources,\n name_prefix : '',\n include_directories : vc4_ipa_includes,\n dependencies : [vc4_ipa_deps, libipa_dep],\ndiff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\nindex 33d1c96aa4f2..b297e1d2e677 100644\n--- a/src/ipa/simple/meson.build\n+++ b/src/ipa/simple/meson.build\n@@ -7,8 +7,7 @@ soft_simple_sources = files([\n 'black_level.cpp',\n ])\n \n-mod = shared_module(ipa_name,\n- [soft_simple_sources, libcamera_generated_ipa_headers],\n+mod = shared_module(ipa_name, soft_simple_sources,\n name_prefix : '',\n include_directories : [ipa_includes],\n dependencies : [libcamera_private, libipa_dep],\ndiff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\nindex d0b63eddd5f6..2cc5f80b0b69 100644\n--- a/src/ipa/vimc/meson.build\n+++ b/src/ipa/vimc/meson.build\n@@ -2,8 +2,7 @@\n \n ipa_name = 'ipa_vimc'\n \n-mod = shared_module(ipa_name,\n- ['vimc.cpp', libcamera_generated_ipa_headers],\n+mod = shared_module(ipa_name, 'vimc.cpp',\n name_prefix : '',\n include_directories : [ipa_includes],\n dependencies : [libcamera_private, libipa_dep],\ndiff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\nindex aa4d9cd7b5d8..b5ab9794c622 100644\n--- a/src/libcamera/proxy/worker/meson.build\n+++ b/src/libcamera/proxy/worker/meson.build\n@@ -17,8 +17,7 @@ foreach mojom : ipa_mojoms\n './' + '@INPUT@'\n ])\n \n- proxy = executable(mojom['name'] + '_ipa_proxy',\n- [worker, libcamera_generated_ipa_headers],\n+ proxy = executable(mojom['name'] + '_ipa_proxy', worker,\n install : true,\n install_dir : proxy_install_dir,\n dependencies : libcamera_private)\ndiff --git a/test/ipa/meson.build b/test/ipa/meson.build\nindex fe21ca58b64f..e9871aba44ee 100644\n--- a/test/ipa/meson.build\n+++ b/test/ipa/meson.build\n@@ -8,7 +8,7 @@ ipa_test = [\n ]\n \n foreach test : ipa_test\n- exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n+ exe = executable(test['name'], test['sources'],\n dependencies : [libcamera_private, libipa_dep],\n link_with : [test_libraries],\n include_directories : [test_includes_internal])\ndiff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\nindex 5b08e2939ce6..894523daf76b 100644\n--- a/test/ipa/rkisp1/meson.build\n+++ b/test/ipa/rkisp1/meson.build\n@@ -5,7 +5,7 @@ rkisp1_ipa_test = [\n ]\n \n foreach test : rkisp1_ipa_test\n- exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n+ exe = executable(test['name'], test['sources'],\n dependencies : [libcamera_private, libipa_dep],\n link_with : [test_libraries],\n include_directories : [test_includes_internal,\n", "prefixes": [ "v5", "08/18" ] }