Patch Detail
Show a patch.
GET /api/1.1/patches/20765/?format=api
{ "id": 20765, "url": "https://patchwork.libcamera.org/api/1.1/patches/20765/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20765/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240805070644.1536232-3-stefan.klug@ideasonboard.com>", "date": "2024-08-05T07:06:33", "name": "[v1,2/2] utils: tuning: Change Tuner.add() to accept a list of modules", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "433179319d41f819ddd54badef1cc212bb17cc60", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20765/mbox/", "series": [ { "id": 4484, "url": "https://patchwork.libcamera.org/api/1.1/series/4484/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4484", "date": "2024-08-05T07:06:31", "name": "Two small tuning script cleanups", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4484/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20765/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20765/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 068AFBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Aug 2024 07:06:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5C6563385;\n\tMon, 5 Aug 2024 09:06:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19CDD63380\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Aug 2024 09:06:55 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:30ff:e7b4:349c:44ce])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4C2DAB5;\n\tMon, 5 Aug 2024 09:06:03 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IxnFZ9Zq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722841563;\n\tbh=nFyuMgK8ILHuUZ4eQQhEHNKAJrJ9TXW3HPnljwhSQaI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IxnFZ9ZqiMOV8z+qzAJcWOIdlLaGvLz4WFLtcO3CwD43p+BKkbL6MpJJa6zkcQTe8\n\t7+2G19ooKctVv2ibcHNo3eHRhmstwAbov9hobiz9PTHssGuweJnWMt57M1C01DArXd\n\tmxAULCVZ2JpaTRh1xcrKf18LH8LnyKZZxIpLCxpE=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 2/2] utils: tuning: Change Tuner.add() to accept a list of\n\tmodules", "Date": "Mon, 5 Aug 2024 09:06:33 +0200", "Message-ID": "<20240805070644.1536232-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240805070644.1536232-1-stefan.klug@ideasonboard.com>", "References": "<20240805070644.1536232-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Change the first parameter of Tuner.add() to be a list of modules\ninstead of a single module. This allows more compact code and is in sync\nwith Tuner.set_output_order().\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/libtuning/libtuning.py | 4 ++--\n utils/tuning/raspberrypi_alsc_only.py | 2 +-\n utils/tuning/rkisp1.py | 10 +---------\n 3 files changed, 4 insertions(+), 12 deletions(-)", "diff": "diff --git a/utils/tuning/libtuning/libtuning.py b/utils/tuning/libtuning/libtuning.py\nindex e7c63535fefd..a167e39ef08e 100644\n--- a/utils/tuning/libtuning/libtuning.py\n+++ b/utils/tuning/libtuning/libtuning.py\n@@ -94,8 +94,8 @@ class Tuner(object):\n self.config = {}\n self.output = {}\n \n- def add(self, module):\n- self.modules.append(module)\n+ def add(self, modules):\n+ self.modules.extend(modules)\n \n def set_input_parser(self, parser):\n self.parser = parser\ndiff --git a/utils/tuning/raspberrypi_alsc_only.py b/utils/tuning/raspberrypi_alsc_only.py\nindex 777d800765e0..fe2b5b8b5a24 100755\n--- a/utils/tuning/raspberrypi_alsc_only.py\n+++ b/utils/tuning/raspberrypi_alsc_only.py\n@@ -14,7 +14,7 @@ from libtuning.generators import RaspberryPiOutput\n from raspberrypi.alsc import ALSC\n \n tuner = lt.Tuner('Raspberry Pi (ALSC only)')\n-tuner.add(ALSC)\n+tuner.add([ALSC])\n tuner.set_input_parser(RaspberryPiParser())\n tuner.set_output_formatter(RaspberryPiOutput())\n tuner.set_output_order([ALSC])\ndiff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex 5d7a69fc4a13..f5c42a61d15e 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -45,15 +45,7 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n smoothing_function=lt.smoothing.MedianBlur(3),)\n \n tuner = lt.Tuner('RkISP1')\n-tuner.add(agc)\n-tuner.add(awb)\n-tuner.add(blc)\n-tuner.add(ccm)\n-tuner.add(color_processing)\n-tuner.add(filter)\n-tuner.add(gamma_out)\n-tuner.add(lsc)\n-\n+tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc])\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n tuner.set_output_order([agc, awb, blc, ccm, color_processing,\n", "prefixes": [ "v1", "2/2" ] }