Patch Detail
Show a patch.
GET /api/1.1/patches/20700/?format=api
{ "id": 20700, "url": "https://patchwork.libcamera.org/api/1.1/patches/20700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240725092622.3835420-1-qi.hou@nxp.com>", "date": "2024-07-25T09:26:22", "name": "[v2] gstreamer: Fix critical warning \"gst_value_set_int_range_step: assertion 'start < end' failed\"", "commit_ref": "c9152bad5ce905f5a31dbd05b40195f02c0cc2a9", "pull_url": null, "state": "accepted", "archived": false, "hash": "99ebba02ffb96dd74985d749620f35626ccacd8a", "submitter": { "id": 195, "url": "https://patchwork.libcamera.org/api/1.1/people/195/?format=api", "name": "Qi Hou", "email": "qi.hou@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20700/mbox/", "series": [ { "id": 4460, "url": "https://patchwork.libcamera.org/api/1.1/series/4460/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4460", "date": "2024-07-25T09:26:22", "name": "[v2] gstreamer: Fix critical warning \"gst_value_set_int_range_step: assertion 'start < end' failed\"", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4460/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20700/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 561FBC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Jul 2024 09:26:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F8DB6336F;\n\tThu, 25 Jul 2024 11:26:49 +0200 (CEST)", "from AS8PR04CU009.outbound.protection.outlook.com\n\t(mail-westeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c201::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 522BF6199A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Jul 2024 11:26:47 +0200 (CEST)", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)\n\tby GV1PR04MB10606.eurprd04.prod.outlook.com (2603:10a6:150:207::15)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20;\n\tThu, 25 Jul 2024 09:26:45 +0000", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd]) by\n\tPAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd%4]) with mapi id 15.20.7784.017;\n\tThu, 25 Jul 2024 09:26:45 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"JPnA2tRW\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=lXhgZlIDcM1qz43EZHq0/HSBM2j4OskF2oyUBOY+SGALkaeVoQShUgP2k4hPPsaeJeVpviknKajVpU0QCANavRvlHEOERQR5DX1utVgp5PYcKHNuqmW+I5npY+3l1o8D46k3rGUT+MqUQSiDV15hz85+Zv7ma6vZi1ir+nxWjgWnEvs9/8+WSoVkASdQ+itMj4HDylhZq1zt1gOR2KUzGBd9A5zT+1ndOzctQoi1Iq4t0OC/sf/kHPtEfH0TNI6oGQJ+TWA9qFwGwMZWfEuxX1lcxYARwSDFwNBYnR3DlINVIkjrfOXec0R3irPEyVf2pZcAry3n+OV+wB32+i7CWw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=mCvLm8qlXxYWTmSfTbFdARnLJNe8frtmHvu4GaiItPc=;\n\tb=PDh4ya5+folICzH7OpxJceEIxrk52bcqOp9GBxqjVOQFhAjLNjx5UwVSfEIxA6CoBCiTrqwxs1asOnGXM5UtIVziD6G4VwIJ8Z802YDDHM4Glgu0FYoYnQGwKRXrqL+finAXzdV+CXsAhBT5TCTaNe362WLTVPFdtaaQlwqxZw3AjHYM69sebBHf5UajpEeQs1NzZ8a5dDhB16pQPEDEx6AARHfc25J8/+3KKK/1HMqqe5dRF+Yktjyj7jnsrfrBhgdslO7pOTSg2E8Unw/3PGaaX5yPo6SEYX1IvwnO3KNcYhSqL5qG7sgdwbI77IVTxO8/FNKDg9ltlps85y08pA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=mCvLm8qlXxYWTmSfTbFdARnLJNe8frtmHvu4GaiItPc=;\n\tb=JPnA2tRWb5wIzbxy+wL1hy/EYOlMiD/ejK5F+9VlTAk0IzJUbNHqp+KFSEbT/Y1RondDYbBnLXL3B5qX2TIJ8QZWLNat8WVivj9O/GNQlgWtZZMWE0xAAiJ3V3DeT+70RNPvW/gseLP1hOqJsw1fWvV63z4DoIFXoxZh9Q1H9k6X6WkjmtdcDm2MdvbsQcK8jgPPrdeGlj066V7a+pUfZMABaKzahD54Tk+n9NAuRtZVGj7BQXdCPNyVNRLKVxQr82xiWo76kpJXOLBOcLi3OMxPNmTuM2JNzlmvyOWfT4xq/RIWxEC0OrQ0+WAdy8Poee0TQWzMzdUoP4b1rEMj3w==", "From": "Hou Qi <qi.hou@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jared.hu@nxp.com,\n\tqi.hou@nxp.com,\n\tjulien.vuillaumier@nxp.com", "Subject": "[PATCH v2] gstreamer: Fix critical warning\n\t\"gst_value_set_int_range_step: assertion 'start < end' failed\"", "Date": "Thu, 25 Jul 2024 18:26:22 +0900", "Message-Id": "<20240725092622.3835420-1-qi.hou@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR04CA0212.apcprd04.prod.outlook.com\n\t(2603:1096:4:187::8) To PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8285:EE_|GV1PR04MB10606:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8787114a-6133-41db-3870-08dcac8be6dd", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|1800799024|52116014|376014|366016|38350700014; ", "X-Microsoft-Antispam-Message-Info": "gJWxF1UZ3mj7iNvLB0VUSb9h/ZRbOOlCOjJTcqzf5y/42xhgod8VuRsaVbOi4uXW0SyNjUlS3D5z5QeV3ETPkdHUlSmkBHtRLSxFv8JOWIDl4MbGAxTWpNEtDiGz6mLJ4V4uJafgMfmIM8w2nEdDo+ejKvZXhMHrtLbDQcNCT1u1kBqNpgO5MnOsKl87KZcHD4M0u+fq2FT9dV/lnZFgvz1OXp8az7S19R06lxYdk+1YD0CtU5jSsJI5QizRYQj9fNC0/2q/OQL2T0X1UYGU53YX8Ly99WvHic61GnHq3pFiISxUe44n9gy5kHsPFjREJ6OJtylGUn2jPruwgJlsXTCt87H5sDq587212KV8J19xAp26BT3FfFYOCx2V5CwneN3ZI5D8rMkhIyW0pE7XCMywMT/w78Nom0gudT+qimBDOFlszKImppFRLWfvlfvQyZykqCROfifg1lYZTYH1dlX/ClInAvLASGTjgw9snL0pQEtLjnoVBmBKuV9yntB8smG9bhNYm2s7ocuAf8mNNbBJe8LiODARf8QucRGrhUi5LNip6SSd6CJSgVP6kFPse1D0i2gX0f8bPwVc1liPP5VUYvfpk8Fp3/ngzY2cxecZA0uDriT8o9ll8cX2OEmGqoafVAD5LX8sIstBq6XpSwJw661j8L/rvqT87EfjMGd0mb8+jkFQ2BGQz1eNQkSLWN+0XNUHihqxOoH1zhX+4dF9o+ESfpx/2fFm01EBnE3RHOJNEXHUw5ImNCmRSGV8jG/J6pOTTMf5YKFay4t/a6Q1+KKOUjMX896rLLkgZ3xhxHdWhpON+47bdt8rbFyX2f6Ik9G2G1w0ADySSVESTGvKcq76VY+TSCwHgsQcas42JFvwwJcViKN8sRCkcdoBs1nv4h+3GM7Ehxc3HgglLi5oDs2aF6QG9NGDxZQH08O8QVT5RdDqbBsbmyQovIGFWW/RiwQdj2TqPrV/ILbxR8HjodjssQAeflMfsijFZWrh7eNNBLOeEQZLqhccxblY/fD+XfyqyoOYvgPnx3EVO+Nx7WATmjcVh2mNWVw3F4e+lY0XnfeKwIfh5IvQTam+jmW/afVttf+JuGWq2hdmxWkt0ygvlJLhymTWjLjAk20v+T2vQqDDCXCie1/V1rODOUCrUU5NzqQC40B+uUZDBHcQLRfNXrXv19zGja7fbbQLO0+QTkW5+1WHUzWv34/HKkjCYCfLsEcwUht4+T2Zu1MGHgTju4vsM/h6eda+gEA9CH6vDkogHl1mB0WfxhpfYrijxzrbaMQDgvz9HRAf3Ewso+utMiqLTD1rd8fRwEUSGdsxU+etttTjyBuMGde5Sc92M8PijaVXTB4x5a3kSdFOfzT2mf31IjKrI5YcqiBso7K18TY+q66j5TIU1tUmxRJktLn/5pjsDBb/Z92BjA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8285.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(52116014)(376014)(366016)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "n53ialL1Uq9Xp9FZHXDT6nROH+ayGh5pIiVn0AGwYFBDFcmPmM3cK1j2h4Bz+Rwm4Iw9x/k5BxFid1epDGVMCw5LdV5HqUzpx4FCGyO4IOUH67+/SgGTpRL1CtPkCBJWgpaGXZ2wYBDleCSgfFuBgCb1h6yTTwKAFTBHngCU+1rs7rkiYwDJRDOe4EVP5qwIwD1zv5QTlmBocAfqCMtdIS65v3DbisEmY/TuFzniQ7MrkVHWsYKqBvnitMqvRHZ6B9ZvDyVvmf+LCokZkNtQtKoAbTdVfXpXMVziVorHs4Y3ufb0IJu7uHtKfWmeLm6/VSH9PhsBbI2x/k42Mul/0m0ZlIskepvz3mT6FxPYxWhblAgtaUTube1uHXAgh36X/Q59BYwhAFDOvI2Yifcc0m42IAPAEHax8kG1vVsdlhutYp1UcNefMaeJUkJunhTV3OM3EHyPywVQ2ujP1jrUPuN/xxiYEEhqmQQCeTNj82SjLE5R2a6d10q2hgKHRyeuVluCdSetFOXv0YumcV9hSSm+n20NpsSF4ylYjpwp8EXmdQTJqN1D27bKkK8oDp5ApuEoav1PypGi8mZD7LL14Gmevyv3rwNlUsI8HbBATDCTjZ0adHvgRxCjobcyAJrWsB11F5sCjLOfG7z2XdhnQJ8Xcbdbx5PAH1yA+a711+aogZMYm+9+SsKvZCefRHkz7JP3ucpoM7AIgOR+e1dfWiy23BSgtOvEbwt3TMXW/4mo+oKJxCnyQj+XmRYUEXZ6nL/qigkmWvYMIEtgaAn4xH4TSeqo9OaSrwvO7iqeEnRvY9li+N7hfI8moaoX/ChDwoNJHDHHlnq08ZYyu9usTwNAa3taXZjY6FOgu4LLw9a6rDkk2kYweN0I3sHtOTl6c/cyjoGhkVGYPriKZw06Bu4ZhJVUQDH/v1yTNrgW/wyy1mdk3nZDGhslc18y+AwCG0LnBdQbRaYeQ84GZe6h6jDfEdjPc+KmzUNFPxfdlg6TGc0l0Hetp+ruCVnPwO0Y+B0Gk4wNP7tbc8Yff+PfDfto1h+D0/YR32jRBvm/Wx4r5DFihBBLowvEY16xxGw0WYghpcz0CKW6CIIL19ab/V/1dswfM+TqN9W/hc5grHSmifA0p9JNp29dvrp+L545AwTBhUjUr1DyoR90BNKf0/cop0Qlz7a9yFJqXnVS5Kgu1wExdHTlLkWK8QsElVfyfT82H/o7bY381zW+uC8QTZJy1p7q+A4gS70f9rBVzPCDLCs3YbU+q/GRaSaOKNnhgsJss70+s8v25nCuD6kd3nP8Dc1lxViUw6qPMuwqd9oR1740MorRpy5/VVKzZ8pprg/nAFRpK/L95vL+Onj33ND4TmLB5+2zzq3nZFQ9Iabc8B2PoodPJhaUoch0JdCQ5gh3oEz4gxAnU24kHARokyOJ59s5yTT1D+MEFJEkHafn4w8hw+t66Cgutm+EyriFznNz3ACJi/ZxTS0h3dCLHmWiNN+GS34+jTcCi8uEveaayk2yzGfSh8nCNgpzdu8rEE1eJ+ozKAXGJfOKoQ2oB3LVrRfrDtyo2pAOAW7bw0s=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "8787114a-6133-41db-3870-08dcac8be6dd", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB8285.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Jul 2024 09:26:45.6175\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "gK2rdWq1ze70giEsVvuJ5M1hVUkvtSO20fH7Rg5qBPt2jxYDg58Bt8P4usMH/fk7", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "GV1PR04MB10606", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This changes is fixing critical error message\n\"gst_value_set_int_range_step: assertion 'start < end' failed\" observed\nwhen building GStreamer caps from a stream configuration whose size\nrange holds a single size.\n\nGStreamer range step definition requires distinct min and max values\ndefinitions, otherwise above error message is output.\n\nlibcamera SizeRange instance may return a single size leading to\nidentical min and max values. Add a conditional check where the min and\nmax of the range are distinct during iterating the supported sizes for\neach pixelformat.\n\nSigned-off-by: Hou Qi <qi.hou@nxp.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 18 +++++++++++++-----\n 1 file changed, 13 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex ec4da435..79f71246 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -359,13 +359,21 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n \t\t\tGValue val = G_VALUE_INIT;\n \n \t\t\tg_value_init(&val, GST_TYPE_INT_RANGE);\n-\t\t\tgst_value_set_int_range_step(&val, range.min.width, range.max.width, range.hStep);\n-\t\t\tgst_structure_set_value(s, \"width\", &val);\n-\t\t\tgst_value_set_int_range_step(&val, range.min.height, range.max.height, range.vStep);\n-\t\t\tgst_structure_set_value(s, \"height\", &val);\n+\t\t\tif (range.min.width == range.max.width) {\n+\t\t\t\tgst_structure_set(s, \"width\", G_TYPE_INT, range.min.width, nullptr);\n+\t\t\t} else {\n+\t\t\t\tgst_value_set_int_range_step(&val, range.min.width, range.max.width, range.hStep);\n+\t\t\t\tgst_structure_set_value(s, \"width\", &val);\n+\t\t\t}\n+\t\t\tif (range.min.height == range.max.height) {\n+\t\t\t\tgst_structure_set(s, \"height\", G_TYPE_INT, range.min.height, nullptr);\n+\t\t\t} else {\n+\t\t\t\tgst_value_set_int_range_step(&val, range.min.height, range.max.height, range.vStep);\n+\t\t\t\tgst_structure_set_value(s, \"height\", &val);\n+\t\t\t}\n \t\t\tg_value_unset(&val);\n \n-\t\t\tgst_caps_append_structure(caps, s);\n+\t\t\tcaps = gst_caps_merge_structure(caps, s);\n \t\t}\n \t}\n \n", "prefixes": [ "v2" ] }