Patch Detail
Show a patch.
GET /api/1.1/patches/20687/?format=api
{ "id": 20687, "url": "https://patchwork.libcamera.org/api/1.1/patches/20687/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20687/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717100913.16640-2-jacopo.mondi@ideasonboard.com>", "date": "2024-07-17T10:09:04", "name": "[RFC,1/9] libcamera: converter: Add interface for feature flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "47d049c8692694c682c1d93b974a341e3f000809", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20687/mbox/", "series": [ { "id": 4455, "url": "https://patchwork.libcamera.org/api/1.1/series/4455/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4455", "date": "2024-07-17T10:09:03", "name": "Handle Converter features differently", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4455/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20687/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20687/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4F98BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 10:09:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DCA963380;\n\tWed, 17 Jul 2024 12:09:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 921C66336F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 12:09:27 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CF32ABE;\n\tWed, 17 Jul 2024 12:08:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GnvCoUfN\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721210929;\n\tbh=oS1K5mHbfgZ71VXWbywrJkWoZXwEDojw9t/G+Go1imc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GnvCoUfN0k0cBkxWs4DT1uYFebRH9cAFPE1LCeCWXJ+DkukYmxKfbiKkYVzaJGXAe\n\tJFJORwMXi0YnXY78fcVK0ogWXPQtSKVa2LLzvsiZlVjmVygTdUA3iCBEq7GE4aB6U+\n\t6ViOCnsssy6PVT3YrXj02vWLiJM+3dfPGMKl5i88=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "Umang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC 1/9] libcamera: converter: Add interface for feature flags", "Date": "Wed, 17 Jul 2024 12:09:04 +0200", "Message-ID": "<20240717100913.16640-2-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "References": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Umang Jain <umang.jain@ideasonboard.com>\n\nThis patch intends to extend the converter interface to have feature\nflags, which enables each converter to expose the set of features\nit supports.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/converter.h | 13 ++++++++++-\n .../internal/converter/converter_v4l2_m2m.h | 2 +-\n src/libcamera/converter.cpp | 22 ++++++++++++++++++-\n .../converter/converter_v4l2_m2m.cpp | 5 +++--\n 4 files changed, 37 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\nindex b51563d7ca6a..7e4783566a44 100644\n--- a/include/libcamera/internal/converter.h\n+++ b/include/libcamera/internal/converter.h\n@@ -17,6 +17,7 @@\n #include <vector>\n \n #include <libcamera/base/class.h>\n+#include <libcamera/base/flags.h>\n #include <libcamera/base/signal.h>\n \n #include <libcamera/geometry.h>\n@@ -32,7 +33,13 @@ struct StreamConfiguration;\n class Converter\n {\n public:\n-\tConverter(MediaDevice *media);\n+\tenum class Feature {\n+\t\tNone = 0,\n+\t};\n+\n+\tusing Features = Flags<Feature>;\n+\n+\tConverter(MediaDevice *media, Features features = Feature::None);\n \tvirtual ~Converter();\n \n \tvirtual int loadConfiguration(const std::string &filename) = 0;\n@@ -61,8 +68,12 @@ public:\n \n \tconst std::string &deviceNode() const { return deviceNode_; }\n \n+\tFeatures getFeatures() const { return features_; }\n+\n private:\n \tstd::string deviceNode_;\n+\n+\tFeatures features_;\n };\n \n class ConverterFactoryBase\ndiff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\nindex b9e59899ee2b..91701dbed58d 100644\n--- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n+++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n@@ -35,7 +35,7 @@ class V4L2M2MDevice;\n class V4L2M2MConverter : public Converter\n {\n public:\n-\tV4L2M2MConverter(MediaDevice *media);\n+\tV4L2M2MConverter(MediaDevice *media, Features features = Feature::None);\n \n \tint loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; }\n \tbool isValid() const { return m2m_ != nullptr; }\ndiff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 2ab461332677..2c3da6d4502b 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -34,14 +34,27 @@ LOG_DEFINE_CATEGORY(Converter)\n * parameters from the same input stream.\n */\n \n+/**\n+ * \\enum Converter::Feature\n+ * \\brief Specify the features supported by the converter\n+ * \\var Converter::Feature::None\n+ * \\brief No extra features supported by the converter\n+ */\n+\n+/**\n+ * \\typedef Converter::Features\n+ * \\brief A bitwise combination of features supported by the converter\n+ */\n+\n /**\n * \\brief Construct a Converter instance\n * \\param[in] media The media device implementing the converter\n+ * \\param[in] features Features flags representing supported features\n *\n * This searches for the entity implementing the data streaming function in the\n * media graph entities and use its device node as the converter device node.\n */\n-Converter::Converter(MediaDevice *media)\n+Converter::Converter(MediaDevice *media, Features features)\n {\n \tconst std::vector<MediaEntity *> &entities = media->entities();\n \tauto it = std::find_if(entities.begin(), entities.end(),\n@@ -56,6 +69,7 @@ Converter::Converter(MediaDevice *media)\n \t}\n \n \tdeviceNode_ = (*it)->deviceNode();\n+\tfeatures_ = features;\n }\n \n Converter::~Converter()\n@@ -163,6 +177,12 @@ Converter::~Converter()\n * \\return The converter device node string\n */\n \n+/**\n+ * \\fn Converter::getFeatures()\n+ * \\brief Gets the supported features by the converter\n+ * \\return The converter Features flag\n+ */\n+\n /**\n * \\class ConverterFactoryBase\n * \\brief Base class for converter factories\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 2e77872e1710..4aeb7dd93676 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -191,10 +191,11 @@ void V4L2M2MConverter::V4L2M2MStream::captureBufferReady(FrameBuffer *buffer)\n * \\fn V4L2M2MConverter::V4L2M2MConverter\n * \\brief Construct a V4L2M2MConverter instance\n * \\param[in] media The media device implementing the converter\n+ * \\param[in] features Features flags representing supported features\n */\n \n-V4L2M2MConverter::V4L2M2MConverter(MediaDevice *media)\n-\t: Converter(media)\n+V4L2M2MConverter::V4L2M2MConverter(MediaDevice *media, Features features)\n+\t: Converter(media, features)\n {\n \tif (deviceNode().empty())\n \t\treturn;\n", "prefixes": [ "RFC", "1/9" ] }