Patch Detail
Show a patch.
GET /api/1.1/patches/2067/?format=api
{ "id": 2067, "url": "https://patchwork.libcamera.org/api/1.1/patches/2067/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2067/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190929190254.18920-13-laurent.pinchart@ideasonboard.com>", "date": "2019-09-29T19:02:53", "name": "[libcamera-devel,v2,12/13] libcamera: Add ControlValidator implementation for Camera", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a798379a0baefd571e2eab7c668f1b96ba1f2df5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2067/mbox/", "series": [ { "id": 512, "url": "https://patchwork.libcamera.org/api/1.1/series/512/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=512", "date": "2019-09-29T19:02:41", "name": "Improve the application-facing controls API", "version": 2, "mbox": "https://patchwork.libcamera.org/series/512/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2067/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2067/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5116C6165A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 29 Sep 2019 21:03:15 +0200 (CEST)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEC7D320\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 29 Sep 2019 21:03:14 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1569783795;\n\tbh=/v+F4BkbSs2L888fNEvyizetOU7Xyh5VfkYLkMZpepU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hhrKocVMRIQveAhM+G0kLxBC8w2aYm2VM9K9iEMEg5662bU1KMKg2xlTNJUn9cRhq\n\ta8quyL4zqoubicLRFPjH5ukmhku3bWbEKrxx5kibFVIEK+xNeyJ1uKP8SdDWNqt8E7\n\t72KYedj7MkWsQ6BHkxxnha1pHg+QeOx2NF/vKTyo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 29 Sep 2019 22:02:53 +0300", "Message-Id": "<20190929190254.18920-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190929190254.18920-1-laurent.pinchart@ideasonboard.com>", "References": "<20190929190254.18920-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 12/13] libcamera: Add ControlValidator\n\timplementation for Camera", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sun, 29 Sep 2019 19:03:15 -0000" }, "content": "Add a new CameraControlValidator class that implements the\nControlValidator interface for a Camera object.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera_controls.cpp | 53 +++++++++++++++++++++++++\n src/libcamera/include/camera_controls.h | 30 ++++++++++++++\n src/libcamera/include/meson.build | 1 +\n src/libcamera/meson.build | 1 +\n 4 files changed, 85 insertions(+)\n create mode 100644 src/libcamera/camera_controls.cpp\n create mode 100644 src/libcamera/include/camera_controls.h", "diff": "diff --git a/src/libcamera/camera_controls.cpp b/src/libcamera/camera_controls.cpp\nnew file mode 100644\nindex 000000000000..341da56019f7\n--- /dev/null\n+++ b/src/libcamera/camera_controls.cpp\n@@ -0,0 +1,53 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * camera_controls.cpp - Camera controls\n+ */\n+\n+#include \"camera_controls.h\"\n+\n+#include <libcamera/camera.h>\n+#include <libcamera/controls.h>\n+\n+/**\n+ * \\file camera_controls.h\n+ * \\brief Controls for Camera instances\n+ */\n+\n+namespace libcamera {\n+\n+/**\n+ * \\class CameraControlValidator\n+ * \\brief A control validator for Camera instances\n+ *\n+ * This ControlValidator specialisation validates that controls exist in the\n+ * Camera associated with the validator.\n+ */\n+\n+/**\n+ * \\brief Construst a CameraControlValidator for the \\a camera\n+ * \\param[in] camera The camera\n+ */\n+CameraControlValidator::CameraControlValidator(Camera *camera)\n+\t: camera_(camera)\n+{\n+}\n+\n+const std::string &CameraControlValidator::name() const\n+{\n+\treturn camera_->name();\n+}\n+\n+/**\n+ * \\brief Validate a control\n+ * \\param[in] id The control ID\n+ * \\return True if the control is valid, false otherwise\n+ */\n+bool CameraControlValidator::validate(const ControlId &id) const\n+{\n+\tconst ControlInfoMap &controls = camera_->controls();\n+\treturn controls.find(&id) != controls.end();\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/include/camera_controls.h b/src/libcamera/include/camera_controls.h\nnew file mode 100644\nindex 000000000000..998a2d155a44\n--- /dev/null\n+++ b/src/libcamera/include/camera_controls.h\n@@ -0,0 +1,30 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * camera_controls.h - Camera controls\n+ */\n+#ifndef __LIBCAMERA_CAMERA_CONTROLS_H__\n+#define __LIBCAMERA_CAMERA_CONTROLS_H__\n+\n+#include \"control_validator.h\"\n+\n+namespace libcamera {\n+\n+class Camera;\n+\n+class CameraControlValidator final : public ControlValidator\n+{\n+public:\n+\tCameraControlValidator(Camera *camera);\n+\n+\tconst std::string &name() const override;\n+\tbool validate(const ControlId &id) const override;\n+\n+private:\n+\tCamera *camera_;\n+};\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_CAMERA_CONTROLS_H__ */\ndiff --git a/src/libcamera/include/meson.build b/src/libcamera/include/meson.build\nindex 1cf47204f2b5..2c74d29bd925 100644\n--- a/src/libcamera/include/meson.build\n+++ b/src/libcamera/include/meson.build\n@@ -1,4 +1,5 @@\n libcamera_headers = files([\n+ 'camera_controls.h',\n 'camera_sensor.h',\n 'control_validator.h',\n 'device_enumerator.h',\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex c8a66cfc93d5..3a3b388a6a34 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -2,6 +2,7 @@ libcamera_sources = files([\n 'bound_method.cpp',\n 'buffer.cpp',\n 'camera.cpp',\n+ 'camera_controls.cpp',\n 'camera_manager.cpp',\n 'camera_sensor.cpp',\n 'controls.cpp',\n", "prefixes": [ "libcamera-devel", "v2", "12/13" ] }