Patch Detail
Show a patch.
GET /api/1.1/patches/20667/?format=api
{ "id": 20667, "url": "https://patchwork.libcamera.org/api/1.1/patches/20667/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20667/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717085444.289997-4-mzamazal@redhat.com>", "date": "2024-07-17T08:54:24", "name": "[v3,03/23] libcamera: vimc: Drop ipa_interface.h header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ab53d83c986e0e8bf68ebef46b26a4ae6064612f", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20667/mbox/", "series": [ { "id": 4454, "url": "https://patchwork.libcamera.org/api/1.1/series/4454/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4454", "date": "2024-07-17T08:54:21", "name": "Software ISP refactoring", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4454/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20667/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20667/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9CB6EC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 08:55:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4318063384;\n\tWed, 17 Jul 2024 10:55:19 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D099663375\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 10:55:09 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-191-Mre3BsdaOXmKxGywkWWb-Q-1;\n\tWed, 17 Jul 2024 04:55:02 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 11B4C1955D45; Wed, 17 Jul 2024 08:55:02 +0000 (UTC)", "from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id EFF111955F40; Wed, 17 Jul 2024 08:55:00 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UTFHIr0B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1721206508;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=QQzWnynFtR/f57WQYuRF0Mn3M1vqfABh1qRLYuu/Hy4=;\n\tb=UTFHIr0BYno+vRjfyFzS5eIFKQ+K+UGtGhf7a7mzG2YyYdn94PuCMfxAQmNU25N8yQJqiI\n\tfazOdXa98JAGbwn5ujVD7D7iymno2ieWTmxN984pMwzodd9WZw3mGpThgNJ82H7Ucf4npZ\n\t2T2jJTdzLzAp4P4Ca1rYLnE9ewRDxqU=", "X-MC-Unique": "Mre3BsdaOXmKxGywkWWb-Q-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v3 03/23] libcamera: vimc: Drop ipa_interface.h header", "Date": "Wed, 17 Jul 2024 10:54:24 +0200", "Message-ID": "<20240717085444.289997-4-mzamazal@redhat.com>", "In-Reply-To": "<20240717085444.289997-1-mzamazal@redhat.com>", "References": "<20240717085444.289997-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Umang Jain <umang.jain@ideasonboard.com>\n\nThe ipa_interface.h header is already included in vimc_ipa_interface.h\ngenerated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\nand pipeline handler as deemed redundant.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/vimc/vimc.cpp | 1 -\n src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n 2 files changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex ebd63fa6..766e9c9c 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -16,7 +16,6 @@\n #include <libcamera/base/file.h>\n #include <libcamera/base/log.h>\n \n-#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n \n #include \"libcamera/internal/mapped_framebuffer.h\"\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 0ec9928e..838a9355 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -24,7 +24,6 @@\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n-#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/vimc_ipa_interface.h>\n #include <libcamera/ipa/vimc_ipa_proxy.h>\n", "prefixes": [ "v3", "03/23" ] }