Patch Detail
Show a patch.
GET /api/1.1/patches/20628/?format=api
{ "id": 20628, "url": "https://patchwork.libcamera.org/api/1.1/patches/20628/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20628/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240709143913.3276983-12-dan.scally@ideasonboard.com>", "date": "2024-07-09T14:39:11", "name": "[v4,11/13] libcamera: mali-c55: Enable links between resizer and video node", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c12fcd0825f9e12ba809a4b7f3ff73a0f2e8c58b", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20628/mbox/", "series": [ { "id": 4448, "url": "https://patchwork.libcamera.org/api/1.1/series/4448/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4448", "date": "2024-07-09T14:39:00", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4448/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20628/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20628/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4763BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Jul 2024 14:39:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0203B6338C;\n\tTue, 9 Jul 2024 16:39:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D35A86337C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Jul 2024 16:39:22 +0200 (CEST)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 763692393;\n\tTue, 9 Jul 2024 16:38:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LcOiVyyO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720535930;\n\tbh=7HjZW+B3x78J3wRUkUtBFxMgqtv/VD1c96N6Ydcnhek=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LcOiVyyOWHPL69QN5Qdn0m6vvhRwUh1ujYaT9HH8l4Ib/T/X2duVDn4L505ajjrA1\n\tolsXyEDdmHMu2FXXB1SfREPA3u/7Uwk1Jh3uXwmpCPy26kg6vfiioUlUWhckRZiuh+\n\t4iuBDY9LZgCuNeFAmvcK7MkxdXDUUSd/qibAUuNs=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v4 11/13] libcamera: mali-c55: Enable links between resizer\n\tand video node", "Date": "Tue, 9 Jul 2024 15:39:11 +0100", "Message-Id": "<20240709143913.3276983-12-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240709143913.3276983-1-dan.scally@ideasonboard.com>", "References": "<20240709143913.3276983-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The mali-c55 driver now expects links to video devices to be enabled\nin order for those devices to be streamed from / to. Enable the media\nlink between the resizers and their associated video device to fulfil\nthe requirement.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex c456a798..512a7489 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -827,6 +827,17 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tStream *stream = streamConfig.stream();\n \t\tMaliC55Pipe *pipe = pipeFromStream(data, stream);\n \n+\t\t/*\n+\t\t * Enable the media link between the pipe's resizer and the\n+\t\t * capture video device\n+\t\t */\n+\t\tconst MediaEntity *rszEntity = pipe->resizer->entity();\n+\t\tret = rszEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n+\t\tif (ret) {\n+\t\t\tLOG(MaliC55, Error) << \"Couldn't enable resizer's link\";\n+\t\t\treturn ret;\n+\t\t}\n+\n \t\tif (isFormatRaw(streamConfig.pixelFormat))\n \t\t\tret = configureRawStream(data, streamConfig, subdevFormat);\n \t\telse\n", "prefixes": [ "v4", "11/13" ] }