Patch Detail
Show a patch.
GET /api/1.1/patches/20612/?format=api
{ "id": 20612, "url": "https://patchwork.libcamera.org/api/1.1/patches/20612/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20612/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240705144209.418906-24-stefan.klug@ideasonboard.com>", "date": "2024-07-05T14:41:59", "name": "[v4,23/23] libtuning: agc: rkisp1: Increase y-target", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "394b0d5b1f8a7c4879e8c6dc4763fa7a6b103dc9", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20612/mbox/", "series": [ { "id": 4446, "url": "https://patchwork.libcamera.org/api/1.1/series/4446/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4446", "date": "2024-07-05T14:41:36", "name": "Add ccm calibration to libtuning", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4446/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20612/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20612/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16C94BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Jul 2024 14:43:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DDA56337C;\n\tFri, 5 Jul 2024 16:43:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4B956337C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Jul 2024 16:43:11 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 655D24CC;\n\tFri, 5 Jul 2024 16:42:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SCR/TkSV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190562;\n\tbh=KOXY8z/WG7DDdH7okIOTda5cjmJJnPzWdbxjb9pXn6k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SCR/TkSVxwKiPBxs1rH1PWTwand3At5f54L7wMYgBJcOcaTnSV0q8vmEYLmVJYyu8\n\teamWfnBvAKVroBSf8FakrgR+FYTCPBj3ZcguSdWvoRqfI8N7Dk6ThnqJgfXABIyr+E\n\tkaBiCy1T0h//FDtIQLQEZUcea1f2jW6+KQdotlK8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v4 23/23] libtuning: agc: rkisp1: Increase y-target", "Date": "Fri, 5 Jul 2024 16:41:59 +0200", "Message-ID": "<20240705144209.418906-24-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240705144209.418906-1-stefan.klug@ideasonboard.com>", "References": "<20240705144209.418906-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the addition of gamma out correction the relative luminance target\nwas set too low. As brightness is a bit subjective it is difficult to\ncome up with the \"correct\" value. With 0.5 the patch 22 on the macbeth\nchart (neutral grey, 18% reflectance) ended up a bit below 50% grey,\nwhich seems reasonable.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\nindex 19a5555b6111..7147028a774a 100644\n--- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n@@ -64,7 +64,7 @@ class AGCRkISP1(AGC):\n return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}\n \n def _generate_y_target(self) -> list:\n- return 0.16\n+ return 0.5\n \n def process(self, config: dict, images: list, outputs: dict) -> dict:\n output = {}\n", "prefixes": [ "v4", "23/23" ] }