Patch Detail
Show a patch.
GET /api/1.1/patches/20576/?format=api
{ "id": 20576, "url": "https://patchwork.libcamera.org/api/1.1/patches/20576/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20576/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240704100728.7003-2-laurent.pinchart@ideasonboard.com>", "date": "2024-07-04T10:07:28", "name": "[v2,2/2] test: utils: Extend utils::hex() test to 8-bit and 16-bit values", "commit_ref": "131039f6330f4c1a4a36f0b4d381f0033b9ecf46", "pull_url": null, "state": "accepted", "archived": false, "hash": "793e511d2e4577298395d6c116ab3736b76b7538", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20576/mbox/", "series": [ { "id": 4444, "url": "https://patchwork.libcamera.org/api/1.1/series/4444/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4444", "date": "2024-07-04T10:07:27", "name": "[v2,1/2] libcamera: base: utils: Implement hex() for 8-bit and 16-bit values", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4444/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20576/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20576/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FAC6BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Jul 2024 10:07:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50F0162E23;\n\tThu, 4 Jul 2024 12:07:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2F1962C99\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2024 12:07:50 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00EEC502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2024 12:07:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jq3m31L8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720087642;\n\tbh=Vm9wRSTV0IeMd0LOvRW/+SEM/plQTMEztMPGz278Z0E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Jq3m31L8qqlZRDCQZ8z8DpP0Xd49exOWGBsBaLtuAc/DIMfDrtMhHSnJJPEEIpKou\n\tU220Hhnz+/L28YGpZ7kGEreoTXK+3FMP2XtMi6AI0RKX/sCUR9RFRYvtf8wEGMdQfi\n\txvKNVlD248Qllqx8yVGCJVFiCJcfgnJG2see9i5g=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 2/2] test: utils: Extend utils::hex() test to 8-bit and\n\t16-bit values", "Date": "Thu, 4 Jul 2024 13:07:28 +0300", "Message-ID": "<20240704100728.7003-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240704100728.7003-1-laurent.pinchart@ideasonboard.com>", "References": "<20240704100728.7003-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the utils::hex() function supports 8-bit and 16-bit integers,\nextend the unit test to cover them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/utils.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/test/utils.cpp b/test/utils.cpp\nindex 41af954b326f..d25475cb93b9 100644\n--- a/test/utils.cpp\n+++ b/test/utils.cpp\n@@ -176,6 +176,14 @@ protected:\n \t\tstd::ostringstream os;\n \t\tstd::string ref;\n \n+\t\tos << utils::hex(static_cast<int8_t>(0x42)) << \" \";\n+\t\tref += \"0x42 \";\n+\t\tos << utils::hex(static_cast<uint8_t>(0x42)) << \" \";\n+\t\tref += \"0x42 \";\n+\t\tos << utils::hex(static_cast<int16_t>(0x42)) << \" \";\n+\t\tref += \"0x0042 \";\n+\t\tos << utils::hex(static_cast<uint16_t>(0x42)) << \" \";\n+\t\tref += \"0x0042 \";\n \t\tos << utils::hex(static_cast<int32_t>(0x42)) << \" \";\n \t\tref += \"0x00000042 \";\n \t\tos << utils::hex(static_cast<uint32_t>(0x42)) << \" \";\n@@ -184,6 +192,15 @@ protected:\n \t\tref += \"0x0000000000000042 \";\n \t\tos << utils::hex(static_cast<uint64_t>(0x42)) << \" \";\n \t\tref += \"0x0000000000000042 \";\n+\n+\t\tos << utils::hex(static_cast<int8_t>(0x42), 6) << \" \";\n+\t\tref += \"0x000042 \";\n+\t\tos << utils::hex(static_cast<uint8_t>(0x42), 1) << \" \";\n+\t\tref += \"0x42 \";\n+\t\tos << utils::hex(static_cast<int16_t>(0x42), 6) << \" \";\n+\t\tref += \"0x000042 \";\n+\t\tos << utils::hex(static_cast<uint16_t>(0x42), 1) << \" \";\n+\t\tref += \"0x42 \";\n \t\tos << utils::hex(static_cast<int32_t>(0x42), 4) << \" \";\n \t\tref += \"0x0042 \";\n \t\tos << utils::hex(static_cast<uint32_t>(0x42), 1) << \" \";\n", "prefixes": [ "v2", "2/2" ] }