Patch Detail
Show a patch.
GET /api/1.1/patches/20568/?format=api
{ "id": 20568, "url": "https://patchwork.libcamera.org/api/1.1/patches/20568/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20568/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703225230.3530-8-laurent.pinchart@ideasonboard.com>", "date": "2024-07-03T22:52:26", "name": "[v1,07/11] pipeline: rkisp1: Use the extensible parameters format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d58b301a2af8365da1e587946f1c79ec6c9b24d1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20568/mbox/", "series": [ { "id": 4442, "url": "https://patchwork.libcamera.org/api/1.1/series/4442/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4442", "date": "2024-07-03T22:52:19", "name": "rkisp1: Support BLS on i.MX8MP", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4442/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20568/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20568/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F6D2BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 22:53:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4C0863360;\n\tThu, 4 Jul 2024 00:53:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0F5E6333F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2024 00:52:58 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67B994CC;\n\tThu, 4 Jul 2024 00:52:30 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tL9BVUCM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720047150;\n\tbh=a+RDbzjuVWfP6u+dlSZHdo7GnIYF03J6zF8u12lGnJo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tL9BVUCMm5tHUVxA2/nmPkQhsAXdWkUxWyMviMA1jMUHcrXbuTCLstguyYrRP9/Ii\n\tyfdc0vK7jC25Qhi93Op2Uaypr+da3ACAyaU2jq7ab+srhGXwFc2okC2Z9med3tBMa/\n\t6TRNtJePBVWwO07KVyzox4fMDrGwyKDdN5/BEbZo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v1 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat", "Date": "Thu, 4 Jul 2024 01:52:26 +0300", "Message-ID": "<20240703225230.3530-8-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240703225230.3530-1-laurent.pinchart@ideasonboard.com>", "References": "<20240703225230.3530-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nNow that the IPA module supports the extensible parameters format,\nswitch to it when available. If the kernel driver doesn't support the\nnew format, setFormat() will adjust paramFormat to the legacy format,\nwhich will be passed to the IPA module, preserving backward\ncompatibility.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex f5c01a2566d2..177ded134dbc 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -799,7 +799,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t}\n \n \tV4L2DeviceFormat paramFormat;\n-\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n+\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n \tret = param_->setFormat(¶mFormat);\n \tif (ret)\n \t\treturn ret;\n", "prefixes": [ "v1", "07/11" ] }