Patch Detail
Show a patch.
GET /api/1.1/patches/20536/?format=api
{ "id": 20536, "url": "https://patchwork.libcamera.org/api/1.1/patches/20536/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20536/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703141726.252368-23-stefan.klug@ideasonboard.com>", "date": "2024-07-03T14:17:11", "name": "[v3,22/23] libtuning: lsc: Prevent negative values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "39d6859585a85afa581fa9214c50547e6fefce55", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20536/mbox/", "series": [ { "id": 4437, "url": "https://patchwork.libcamera.org/api/1.1/series/4437/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4437", "date": "2024-07-03T14:16:49", "name": "Add ccm calibration to libtuning", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4437/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20536/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20536/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58E14BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 14:18:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1766363372;\n\tWed, 3 Jul 2024 16:18:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1534762E22\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2024 16:18:38 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9263:c199:9587:576])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E39984CA;\n\tWed, 3 Jul 2024 16:18:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wi/tT4V/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720016290;\n\tbh=faXPQZCwK6fG+KAnkat5u5LDzhhbxj3syAQB9obo2P8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Wi/tT4V/G9YbZ9e8PE0p+efUaTPBftMH1PRfL53h9Jrmbewyf60F3PHQmMPM0eO5G\n\twSBsw/oe2ZYzRTChrFAITXlB+JGYhnmCPFl4q8Xw2kV5m0QSrfI7Dr7Pva/vgPn/oM\n\tb/A008VKf9iAu4d8cukD6CqEN0nujtFz2LAst/O0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 22/23] libtuning: lsc: Prevent negative values", "Date": "Wed, 3 Jul 2024 16:17:11 +0200", "Message-ID": "<20240703141726.252368-23-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240703141726.252368-1-stefan.klug@ideasonboard.com>", "References": "<20240703141726.252368-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In cases where the calibration image contains super dark areas, or when\nan invalid blacklevel was supplied, the grid might get close to zero or\nnegative. This would have bad effects on the 1/grid later. So clamp the\nvalues to a small positive number.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/tuning/libtuning/modules/lsc/lsc.py | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/libtuning/modules/lsc/lsc.py b/utils/tuning/libtuning/modules/lsc/lsc.py\nindex 344a07a3d443..e0ca22ebe9bd 100644\n--- a/utils/tuning/libtuning/modules/lsc/lsc.py\n+++ b/utils/tuning/libtuning/modules/lsc/lsc.py\n@@ -59,7 +59,10 @@ class LSC(Module):\n def _lsc_single_channel(self, channel: np.array,\n image: lt.Image, green_grid: np.array = None):\n grid = self._get_grid(channel, image.w, image.h)\n- grid -= image.blacklevel_16\n+ # Clamp the values to a small positive, so that the following 1/grid\n+ # doesn't produce negative results.\n+ grid = np.maximum(grid - image.blacklevel_16, 0.1)\n+\n if green_grid is None:\n table = np.reshape(1 / grid, self.sector_shape[::-1])\n else:\n", "prefixes": [ "v3", "22/23" ] }