Patch Detail
Show a patch.
GET /api/1.1/patches/20492/?format=api
{ "id": 20492, "url": "https://patchwork.libcamera.org/api/1.1/patches/20492/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20492/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240701075720.46076-5-umang.jain@ideasonboard.com>", "date": "2024-07-01T07:57:20", "name": "[4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h header", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "226cb74f8743362d5e053e35b5b8a68562ee85ed", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20492/mbox/", "series": [ { "id": 4432, "url": "https://patchwork.libcamera.org/api/1.1/series/4432/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4432", "date": "2024-07-01T07:57:16", "name": "Frop base IPA headers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4432/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20492/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20492/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8FADBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Jul 2024 07:57:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D9FC62E18;\n\tMon, 1 Jul 2024 09:57:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45DF1619C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2024 09:57:33 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AE25B63D;\n\tMon, 1 Jul 2024 09:57:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sW6uoC8m\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719820626;\n\tbh=mebeLj8xipFX0xl9eGQH11pIpoEsGlhBi9U7nKdg+nQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sW6uoC8mUp+yDx+f7kV4V9kg7VMH4YE6o3X3m9QbFf3/alhpx7HuR3urq+rAuDEyZ\n\tHyPzz93cj5IfpgGbl2JSHkJ8kTMhhcUJeyhcevfAgqMVGHNYSpRcwoRz53LnWmzhbf\n\tWpeRKR1nTgIDSVWFByoEojr0Hy1k25QP/gnSznl4=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 4/4] libcamera: ipa: soft_simple: Drop ipa_interface.h header", "Date": "Mon, 1 Jul 2024 13:27:20 +0530", "Message-ID": "<20240701075720.46076-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240701075720.46076-1-umang.jain@ideasonboard.com>", "References": "<20240701075720.46076-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipa_interface.h header is already included in soft_ipa_interface.h\ngenerated from module_ipa_interface.h.tmpl. Drop it from software-isp\nIPA as deemed redundant.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b7746ce0..3cc873a2 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -19,7 +19,6 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n \n-#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/soft_ipa_interface.h>\n \n", "prefixes": [ "4/4" ] }