Patch Detail
Show a patch.
GET /api/1.1/patches/20491/?format=api
{ "id": 20491, "url": "https://patchwork.libcamera.org/api/1.1/patches/20491/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20491/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240701075720.46076-4-umang.jain@ideasonboard.com>", "date": "2024-07-01T07:57:19", "name": "[3/4] libcamera: vimc: Drop ipa_interface.h header", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "ab53d83c986e0e8bf68ebef46b26a4ae6064612f", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20491/mbox/", "series": [ { "id": 4432, "url": "https://patchwork.libcamera.org/api/1.1/series/4432/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4432", "date": "2024-07-01T07:57:16", "name": "Frop base IPA headers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4432/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20491/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20491/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2868EBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Jul 2024 07:57:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2576562E1D;\n\tMon, 1 Jul 2024 09:57:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B263362C9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2024 09:57:31 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 710FF63D;\n\tMon, 1 Jul 2024 09:57:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WSvmRhY9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719820625;\n\tbh=/p8GAnO67PCEozvXh00SfA6IeizXJKjQymzbyKWOXvE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WSvmRhY9cAoPyEeBcISzo0EznePmkzvDG83ZA/D0Z3SDvMB4O0vi0XE2O+UZYFvIY\n\tFjHgLJTRGwkWEMw3++M7lJN8mswj7OrA4eKPpj+ITcXGMoMOUsQQcPofHGx1hp/40i\n\tCIoGSCh4qHhrZMQm8UdZnzasOEI/fawvjG2d35sI=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header", "Date": "Mon, 1 Jul 2024 13:27:19 +0530", "Message-ID": "<20240701075720.46076-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240701075720.46076-1-umang.jain@ideasonboard.com>", "References": "<20240701075720.46076-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipa_interface.h header is already included in vimc_ipa_interface.h\ngenerated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\nand pipeline handler as deemed redundant.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/vimc/vimc.cpp | 1 -\n src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n 2 files changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex ebd63fa6..766e9c9c 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -16,7 +16,6 @@\n #include <libcamera/base/file.h>\n #include <libcamera/base/log.h>\n \n-#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n \n #include \"libcamera/internal/mapped_framebuffer.h\"\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 0ec9928e..838a9355 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -24,7 +24,6 @@\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n-#include <libcamera/ipa/ipa_interface.h>\n #include <libcamera/ipa/ipa_module_info.h>\n #include <libcamera/ipa/vimc_ipa_interface.h>\n #include <libcamera/ipa/vimc_ipa_proxy.h>\n", "prefixes": [ "3/4" ] }