Patch Detail
Show a patch.
GET /api/1.1/patches/20479/?format=api
{ "id": 20479, "url": "https://patchwork.libcamera.org/api/1.1/patches/20479/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20479/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628104828.2928109-21-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:47:13", "name": "[v2,20/25] tuning: rkisp1: Add some static modules", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e828f2d8283bbe34d91efd2a850403279bc1da20", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20479/mbox/", "series": [ { "id": 4430, "url": "https://patchwork.libcamera.org/api/1.1/series/4430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4430", "date": "2024-06-28T10:46:53", "name": "Add ccm calibration to libtuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20479/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20479/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11B7EBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:49:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEE1062C97;\n\tFri, 28 Jun 2024 12:49:37 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A33362C97\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:49:36 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF0A3BEB;\n\tFri, 28 Jun 2024 12:49:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tDY0yTWO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571751;\n\tbh=DEyP5KWxI+ngvZ94GoRI/LiVkkcXh0a2kV3ld23SNc8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tDY0yTWOH5HOG68T9diM9GL8jL4K57oDz3p1x/oo8gKeGSD7hUao4SLKe/eOl91I+\n\tbHjcKJ+KeP89L12sj8GrA1K/Qd5isyLAfLZG8Z73UCrg/cLj0ps2szLhV/jv/UXLbU\n\tCXRZ8FjvXLWiw811PsK92sAyLSrqCIN37/vTbtmc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 20/25] tuning: rkisp1: Add some static modules", "Date": "Fri, 28 Jun 2024 12:47:13 +0200", "Message-ID": "<20240628104828.2928109-21-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "References": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add awb, gamma, cproc and filter by default to the tuning file. These\ndon't need any configuration.\n\nWhile at it, sort the modules alphabetically.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/rkisp1.py | 18 ++++++++++++++----\n 1 file changed, 14 insertions(+), 4 deletions(-)", "diff": "diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex fae35783c656..c5036c65557b 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -15,11 +15,22 @@ from libtuning.generators import YamlOutput\n from libtuning.modules.lsc import LSCRkISP1\n from libtuning.modules.agc import AGCRkISP1\n from libtuning.modules.ccm import CCMRkISP1\n-\n+from libtuning.modules.static import StaticModule\n \n coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n \n+awb = StaticModule('Awb')\n+color_processing = StaticModule('ColorProcessing')\n+filter = StaticModule('Filter')\n+gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n+\n tuner = lt.Tuner('RkISP1')\n+tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n+tuner.add(awb)\n+tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n+tuner.add(color_processing)\n+tuner.add(filter)\n+tuner.add(gamma_out)\n tuner.add(LSCRkISP1(\n debug=[lt.Debug.Plot],\n # This is for the actual LSC tuning, and is part of the base LSC\n@@ -39,11 +50,10 @@ tuner.add(LSCRkISP1(\n # values. This can also be a custom function.\n smoothing_function=lt.smoothing.MedianBlur(3),\n ))\n-tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n-tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n+\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n-tuner.set_output_order([AGCRkISP1, CCMRkISP1, LSCRkISP1])\n+tuner.set_output_order([AGCRkISP1, awb, CCMRkISP1, color_processing, filter, gamma_out, LSCRkISP1])\n \n if __name__ == '__main__':\n sys.exit(tuner.run(sys.argv))\n", "prefixes": [ "v2", "20/25" ] }