Patch Detail
Show a patch.
GET /api/1.1/patches/20423/?format=api
{ "id": 20423, "url": "https://patchwork.libcamera.org/api/1.1/patches/20423/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20423/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240627012204.1949820-1-qi.hou@nxp.com>", "date": "2024-06-27T01:22:04", "name": "gstreamer: Fix critical warning \"gst_value_set_int_range_step: assertion 'start < end' failed\"", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7f4b26aba4a58da9ed447449715eee2aaa0f8905", "submitter": { "id": 195, "url": "https://patchwork.libcamera.org/api/1.1/people/195/?format=api", "name": "Qi Hou", "email": "qi.hou@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20423/mbox/", "series": [ { "id": 4421, "url": "https://patchwork.libcamera.org/api/1.1/series/4421/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4421", "date": "2024-06-27T01:22:04", "name": "gstreamer: Fix critical warning \"gst_value_set_int_range_step: assertion 'start < end' failed\"", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4421/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20423/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20423/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D2DCBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Jun 2024 01:22:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E80E162C96;\n\tThu, 27 Jun 2024 03:22:49 +0200 (CEST)", "from EUR02-AM0-obe.outbound.protection.outlook.com\n\t(mail-am0eur02on20615.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2606::615])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4745619C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jun 2024 03:22:46 +0200 (CEST)", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)\n\tby DB9PR04MB9305.eurprd04.prod.outlook.com (2603:10a6:10:36f::18)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.35;\n\tThu, 27 Jun 2024 01:22:44 +0000", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd]) by\n\tPAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd%7]) with mapi id 15.20.7698.025;\n\tThu, 27 Jun 2024 01:22:43 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"JYU4GxRe\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=VpOYdJdL6PP5IBtUwMoA8cPHSFOxzNYSwUQTtLZAX66NEPNTkFmFCp6bhXk8+k/eRUbViw4hskzM+seFE518x3JPozG86v9lysVhAHre4bdQuiSQs2z2y+yP0rW4pcKa3i9h8cRTD+1cTZqpOJrxLF7AAOLoG4m+BrXrgvgTMaparWUmMpE+I9m7hbnM5pbRJuA1DYSFdPQnlu3pNULgv+341amege5MkXqhiiqt/NQYBm/3gIfy99bXjwqtTsPNIs7pfbyD92S6oBhqtkQBPMVo7Y5GzHun/9decPmEMSGIUz7tDAXMGnRjZ2tlzM79w57qWDAXQwOa81NUSiKseA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=UPMhItE6h4oeNRqIh3EfvpE3ZCV4iKNPovAaDXBEc04=;\n\tb=bI52u7M3acRnnoyxG0tRYcyDXLTsTTsdHu4Nh3cecq9Xf39PNorejEbFPjkIZ3XmbfAOlxu/Mo6AcmENrk+2R4SMZvKTErtu8itsHDTxVKyq9SAbCpV5JMMuR4Fb5mOsR7YU88GrkvlG/nrOXvlZB53evGqv24euHRwWL5eQ8iT3uJ52AwopeWgpymOBa5f0N9uAv/DQR6Fe2aFWpzEJFzKYfrho0O6sWJI5ydMtN/w3+xWpHl1GF7lfNwOoJjksLJTS2DdIVeg3QYjGxsWECnrxebkKEfDWbyG5236PPUgK8seNvHbeWQ8yAAODaZPTj0lJFAJBEh8M3RIjCI9h5w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=UPMhItE6h4oeNRqIh3EfvpE3ZCV4iKNPovAaDXBEc04=;\n\tb=JYU4GxReheSjl7iwLYBry4c9Ud1IVHNHD+vpv0jDjYlyAWnuSEN4mtBps8J6tFFbp/rj6G7akZub3BHPhD+p9YraWUt242088VBnwmIJBQFnKFhcRKxo1ztE13sAttVFZJ8SNJ8t12JpA8B7e3AV0HrIP/D1NhWPvRRqfkob+88=", "From": "Hou Qi <qi.hou@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jared.hu@nxp.com,\n\tqi.hou@nxp.com,\n\tjulien.vuillaumier@nxp.com", "Subject": "[PATCH] gstreamer: Fix critical warning\n\t\"gst_value_set_int_range_step: assertion 'start < end' failed\"", "Date": "Thu, 27 Jun 2024 10:22:04 +0900", "Message-Id": "<20240627012204.1949820-1-qi.hou@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI2PR01CA0005.apcprd01.prod.exchangelabs.com\n\t(2603:1096:4:191::23) To AS8PR04MB8278.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3ff::22)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8285:EE_|DB9PR04MB9305:EE_", "X-MS-Office365-Filtering-Correlation-Id": "e359b1ba-db3c-4c0f-15cd-08dc9647a2f1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|366016|52116014|376014|1800799024|38350700014; ", "X-Microsoft-Antispam-Message-Info": "1dsgWlrKGZlmMqix0eC0/8BZFFxDMJJAjZVaJmEPTCVgujpxY1Szcr99/XBfgXbb4VFgDrBOZdzmWFOZ/qC5/8AGanTOrvdGbLj2XORsLfAozqjMFKYTZaWR3/QTzIUXauzorsAsfXSwctlNNSh0aXTIfIaw41AfD/m6JtBRzxu1iLnnVJ4O2iURQuPB/wd5R+LbXnH0BNGayLOxC6sGcyErEuE8V05Wc+70h9dvDWzAgwEqht9o4cxK/zXk6PFKqldLO+BjDUa5xYohRCLb1vETYNDr8pLciMj2HhRP1b5EEzf+5axUHYjDZ3xQAKgLFylfaM2pmbWgIyjRbwXviynhn2lGonD2x0aRMjEKUsl0vAlhG+PLoaxF2b65Gy6rVIdUeubH56faddLpF44umIAsrQkeJhfUd8fvczV7Dn4VNfuH9GmaCOft3Ig8JgoCNnyG6IpVe6eNZXh46IOPVrJ0IrjRwSHXYV0OGs18YR/YBb65kfxeqlFCM7LG3ajykCKQe8xdvui92EGRtGviczQLTEzTcHZp4KHhQ1qb2HxhgtjM6S7liyJ/re8Fh8TR8B1l/qSIqUYuGxYATRzee2X40NcGDMthTfkNE7bsv8duLeZsKjYucrRnBcd4hvX3zCQLPWelP89wJprpaTP18FEDYQfZNA5DeqLZk2o5v+GvIaPLRmOPmMh5PJdPDAn8dWvZooEwNi47Cs54ScVGNbIrQ5Gtozd9iEAdWbmu3FAnOiS/z+gdCUiJuo25nwe0bvRkZdhcIwxf9z0+102nMbPMi9ZrdYE0aDT5TOS2uwV+Sq11N337y6PU3ev5tBUDM1xGO9FpuZcRk7CZVZjFJNhg+Q+OImlFja0MVIGGY+NRyTDWAYIZCu07VhczG7LC12LwGQttaKM4dVYiHwBnUYBcP3XjleNLkYAyjQPBGaFSSBxl2BL684xjbRsLFnqU32PhZFPbr8IjkkuTWN4+53ZghWNewSifaiCN2fhDkxim92d2vNY6a/GtnwuFD2wjmxOorr+8O0ViIE6FaVXx0XCAamxLtkvUUFRXwract4xDgIdt6reut6jV08NHQ7v/FKHHFA5aSnanl0tg+SA2mn5zjmGIT25x0oxP4Ct14e/ayrC7DgwWlQjOmsxIUfSO7EqgUx7fMQ31b4mqRaiw9XVbGXjslp9aXn1HFa1EFtcJV2hxNkXEb3D1YfWP41MJjlZ3yLAJPMs0GONjandYsK2RaG7N1yuRvcDnyh95J6Tca1jCFu/B2WP8tsDO2UwdICB/vyW7HF6DOFM7dE8sZCf6Me5oZ3Ao8yB17KvOXdQ6HRENNmWty0yjdf7NpmJxhPPtKgUa7uKbzAp61x55EZN2mVsRdptOqAPk0uvRklo=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8285.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "VH0EndgCMQCvBxMGNpmUdeCwrWzDl0GZ1lrOunBc97BSlcNiMALybfx1ASLI21RoA9RFwGpMQgimjtEacNGzP9PJ0mGII9Rw9kzkB/1zcdqfXgEB9RSBXjzEyIZFXs9kSICPts6F7A+OlBRVSN7iFxlROb8nxYOJ1VZgaorKrc0epR9pla7wkhscZ/hujU8kcqNJhpBqJJUA/Vps56F40YYF0/FPBEo3vy7RirwTSPX6Ie7tlUf8GEyQ7D6Y1ZM8cVHhWRCA5CgrFkXGoFpBiw8Gn4zAS5ZR3IUJZqkNEQuPz8El4IEKx/EtmfGM+e1cLW3Fz6dI2OIvM6v9JOAEC+OUwgEnb8YoQThEvHNR0b1gYWntR9fuDeTPY7tTsShcaAlyEegUe8W3fzbxVU2/g0es2CvU7lwwKVl3xja06CH+ZOq1dc/wZ207sXav+n5RqDcoa0sHrUWjt638+7pgCjGmt5BmD/6vtA8l+KY/6wPmH8m+IAgk3yaG2qYSzBWqPKPPIi1PPiwFIYjNnyHrydddCjsKOcvunvA2ldPioS1l/O+c8qRsGscOam4VePq1ZvYWP7gzbQpxY7+66J+7xjJt61h4wRMFaAa2786NVd6OAIfXrV01V4hJ+e1n9xV0fgU/zaezkYKuWicwIpqlLKfpUdGPWFxEJbVy5BcMxL8JzVyVWrBnziesawKQ4waInT3RitydZVMgDl4C3wyCHhoH8Ym6MYcwvdVpJgmi7LJZMxVYwAXmivj9Mv4irFIOlLxMbArSMOUVA5GkSEDgrdmrWYm3Gj/+OPTkig7mUHZ5cIs4i58GLZZyDfOqANj94u+5a5CvcW6YkI3ifzLgN67OlzDgaMqu8+rEMrpWSQ/s76lA3doGoUZ/R8yfOVXi4zpdccSuINsA4rXQIkJNdAvjJHXO7wtXypN9xLucwWayV4KgF7YkJDmPMSkZE5KvrebBfzX+6Wa0v4CMo8HR9B9ZFu1TlIs5kWMhCmXp7tp/COyWZ+DfoWqGiEglcHjQnztQXL3bSom9zcWyQLg/j50W6Zs9k2VIa5FTtoF9fkMade54Far+XGtHwfNk1C8KF8AIP6s+7F6YdnG3QhQ7+Gp0+ccBVFjKSYd6PUaMuIoNjId60nSyxLOg4bpr//DK4CMNX144p8pNZnMjBu+XIUdwCRTX7BweYgpkpK/gjK3VlLF2SxqZg0KixwGYjpqT8mEHAVmiomGyi0vLORmKIk2EAo13siP0WJEchzjPP63jLsCMqcTnGqlvJzYvBMzOfpaEe9yGWgiFhSpT023erUQOlsVuz8ymKASBMN77QKZN8yeyYGAjRcGiZ7FgOS09xLHkkkmiIGvKyBl2plXhd7/w5lTMqDwtBiLIhIjajeyOj86w/bbbJcs+EbQE9PtR4t1pR5j7gUdHKRKWT9Fpl1RSG1E5cuhXJ02S8UjypSvUOOgCq0nCSoyLDJBGaF6nxHwJsiOLLBsTCcppNwI+A6pfokTW7uAnM6NPEkG9XdQh51gkcIC+GKYAY+74ScMXZN9MBuzhIJ4W0h7QOikJeC8adfy6YIMZCp8rBGXv6cI=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "e359b1ba-db3c-4c0f-15cd-08dc9647a2f1", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8278.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Jun 2024 01:22:43.7586\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "ZQDNWbZrcsqBPzFHiwJmDFXU607YrZr2ETTJ9r4AIRmSS6jWhGE4JQnepn8KqcMT", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB9PR04MB9305", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This changes is fixing critical error message\n\"gst_value_set_int_range_step: assertion 'start < end' failed\" observed\nwhen building GStreamer caps from a stream configuration whose size\nrange holds a single size.\n\nGStreamer range step definition requires distinct min and max values\ndefinitions, otherwise above error message is output.\n\nLibcamera SizeRange instance may define a single size leading to\nidentical min and max values. Add a test to avoid building GStreamer\nrange step from a single-size SizeRange to avoid such error.\n\nSigned-off-by: Hou Qi <qi.hou@nxp.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex ec4da435..b6672b9f 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -354,7 +354,7 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n \t\t}\n \n \t\tconst SizeRange &range = formats.range(pixelformat);\n-\t\tif (range.hStep && range.vStep) {\n+\t\tif (range.hStep && range.vStep && range.min != range.max) {\n \t\t\tGstStructure *s = gst_structure_copy(bare_s);\n \t\t\tGValue val = G_VALUE_INIT;\n \n", "prefixes": [] }