Patch Detail
Show a patch.
GET /api/1.1/patches/20390/?format=api
{ "id": 20390, "url": "https://patchwork.libcamera.org/api/1.1/patches/20390/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20390/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240625190423.291429-5-jacopo.mondi@ideasonboard.com>", "date": "2024-06-25T19:04:17", "name": "[v2,4/6] libcamera: mali-c55: Simplify bufferReady()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9c8ac22179241956c6f87fbeeef692ede126f6b6", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20390/mbox/", "series": [ { "id": 4418, "url": "https://patchwork.libcamera.org/api/1.1/series/4418/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4418", "date": "2024-06-25T19:04:13", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4418/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20390/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20390/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94449BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jun 2024 19:04:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 329A7654B0;\n\tTue, 25 Jun 2024 21:04:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E745654A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2024 21:04:37 +0200 (CEST)", "from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94479512;\n\tTue, 25 Jun 2024 21:04:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GAzV4Q+4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719342254;\n\tbh=ObRRX/fwFXV2Ki9Jz9kflXj2hbhWSo5z5sSVCOrRi94=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GAzV4Q+4gYCjvyDlUsm5pMPYHQiZwNserQeriAnotRWCeYYgroIumBJi1WMWVcFw5\n\tw3jHxQQR9sWumcE/xtbVFDOz2C4yrrt8j8AZAZtPo1w4eQ1BY4CEOnkv9fYtCkXbNl\n\tZsJR9CJP0WPjhLqOLKkti4Gpw7P0CbWt/kcWP0wo=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 4/6] libcamera: mali-c55: Simplify bufferReady()", "Date": "Tue, 25 Jun 2024 21:04:17 +0200", "Message-ID": "<20240625190423.291429-5-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>", "References": "<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Daniel Scally <dan.scally@ideasonboard.com>\n\nThe PipelineHandler::completeBuffer() base class function returns\na boolean to indicate if there still are pending buffers in the\nRequest.\n\nSimplify the bufferReady() function in the Mali-C55 pipeline handler\nusing the completeBuffer() return value.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 796e2ca60e94..ee73a092eb5b 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -895,12 +895,8 @@ void PipelineHandlerMaliC55::bufferReady(FrameBuffer *buffer)\n {\n \tRequest *request = buffer->request();\n \n-\tcompleteBuffer(request, buffer);\n-\n-\tif (request->hasPendingBuffers())\n-\t\treturn;\n-\n-\tcompleteRequest(request);\n+\tif (completeBuffer(request, buffer))\n+\t\tcompleteRequest(request);\n }\n \n void PipelineHandlerMaliC55::registerMaliCamera(std::unique_ptr<MaliC55CameraData> data,\n", "prefixes": [ "v2", "4/6" ] }